| Summary: | man-pages-%lang packages group ownership of man directories conflicts with everything | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | David Walser <luigiwalser> |
| Component: | RPM Packages | Assignee: | Thierry Vignaud <thierry.vignaud> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | fundawang, guillomovitch, lmenut, mageia, mageia, n54, pmdenielou, thierry.vignaud, tmb |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | i586 | ||
| OS: | Linux | ||
| See Also: | https://bugs.mageia.org/show_bug.cgi?id=3697 | ||
| Whiteboard: | |||
| Source RPM: | man-pages-{cs,es,fr,hu,id,it,ja,ko,pt_BR,ru,zh} | CVE: | |
| Status comment: | |||
| Bug Depends on: | |||
| Bug Blocks: | 8665 | ||
|
Description
David Walser
2013-02-12 23:12:54 CET
David Walser
2013-02-12 23:14:00 CET
CC:
(none) =>
thierry.vignaud
David Walser
2013-02-12 23:14:06 CET
CC:
(none) =>
mageia
David Walser
2013-02-12 23:14:34 CET
CC:
(none) =>
mageia
David Walser
2013-02-12 23:14:44 CET
CC:
(none) =>
tmb
David Walser
2013-02-12 23:14:58 CET
CC:
(none) =>
fundawang
David Walser
2013-02-12 23:17:22 CET
Blocks:
(none) =>
8665 The only package from that list that does own those directories directly, rather than using find_lang, is wireless-tools. I tried to fix it to use find_lang, and for some unknown reason it didn't work. I also accidentally left one package the list of those that are using %find_lang --with-man: - mplayer It looks like the exact change I proposed to find-lang.pl was also proposed in Bug 3697. See Also:
(none) =>
https://bugs.mageia.org/show_bug.cgi?id=3697
David Walser
2013-02-12 23:37:15 CET
CC:
(none) =>
n54 This issue was also raised on the mailing list in July 2011, but it's a bigger issue now because of the behavior change in rpm 4.11. https://www.mageia.org/pipermail/mageia-dev/2011-July/006501.html Looks like find-lang.pl was fixed in rpm-mageia-setup-1.168-1.mga3. Now we just need to rebuild the affected packages and fix the ownership in the man-pages-%lang packages. Yay progress :o) Thanks Thierry and Luc! All needed packages have been rebuilt except for wireless-tools. Thanks Luc. Thanks Luc for your help. So we need someone to change the man-lang packages to not use root:man, as far as I understand. What about wireless-tools? CC:
(none) =>
pierre-malo.denielou Sadly, I've just discovered and reported in bug 3697 that rpm-mageia-setup-1.168 has introduced an annoying regression. CC:
(none) =>
lmenut OK I believe I've fixed the man-pages-%lang packages. wireless-tools still needs to be fixed to correctly use find_lang and build. I really don't understand why it's failing. I ran the find-lang perl script in the perl debugger, and what happens is in the File::Find::find subroutine, it runs that for every file in the package. When it gets to the man pages, it hits a line in the code: -f $File::Find::name or -l $File::Find::name or return; It appears to be returning there, as in the debugger it does not continue past that line in that subroutine. When I just make a small perl script to run -f on one of the man pages files, it does not evaluate to false, so it makes no sense that it's doing that during find-lang. What *should* happen is that evaluates to true and it moves past that into the else-if ladder, and the filename matches the regular expression in the last elsif block and gets added to the list of files. I just fixed the spec file, by adding --all-name option to %find_lang invocation. The problem comes from the pkg_match function, which apparently tries to filter out files found in the buildroot, but not part of a given subpackage, based on file name. It may works correctly for /usr/share/locale subdirectories, but far less with individual man page file names... CC:
(none) =>
guillomovitch Thanks Guillaume! wireless-tools-30-0.pre9.4.mga3 built successfully. This should be fixed now. Status:
NEW =>
RESOLVED |