Bug 8911

Summary:	Proftpd - Run the testsuite at build time
Product:	Mageia	Reporter:	claire robinson <eeeemail>
Component:	RPM Packages	Assignee:	José Jorge <lists.jjorge>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	Normal	CC:	bersuit.vera, juan.baptiste, luigiwalser, marja11, nic
Version:	Cauldron
Target Milestone:	---
Hardware:	i586
OS:	Linux
Whiteboard:
Source RPM:	proftpd	CVE:
Status comment:

Description claire robinson 2013-01-31 10:36:54 CET

See bug 8691

Proftpd ships with a comprehensive testsuite to be used at build time which is not used.

Please make it so it is used, to check for regressions.

claire robinson 2013-01-31 10:37:06 CET

Whiteboard: (none) => MGA2TOO

Comment 1 David Walser 2013-01-31 17:19:14 CET

I tried locally adding %check make check to the SPEC, but while it doesn't do absolutely nothing, I don't think actually runs the tests.  The output ends in test -z """" && (cd tests; make check) but then it doesn't do the second part obviously.  I cd'd into the BUILD/proftpd-1.3.4b/tests directory and did make check manually there and got an error.

CC: (none) => juan.baptiste, luigiwalser

David Walser 2013-01-31 17:19:24 CET

CC: (none) => bersuit.vera

Comment 2 Nic Baxter 2015-02-12 05:20:53 CET

Is this still valid?

CC: (none) => nic

Comment 3 David Walser 2015-02-12 14:29:14 CET

We still don't run make check in the SPEC.  I haven't checked to see whether it works in 1.3.5.

Marja Van Waes 2015-03-28 19:21:34 CET

CC: (none) => marja11
Whiteboard: MGA2TOO => MGA4TOO

Comment 4 Samuel Verschelde 2016-10-15 21:54:19 CEST

Assigning to maintainer José Jorge.

Assignee: bugsquad => lists.jjorge
Whiteboard: MGA4TOO => (none)

Comment 5 José Jorge 2016-11-09 21:46:43 CET

The test suite seems not so comprehensive, when I see how Fedora uses it :

http://pkgs.fedoraproject.org/cgit/rpms/proftpd.git/tree/proftpd.spec

So I am not sure we should enable such tests, which are not fully maintained upstream.

Comment 6 José Jorge 2017-06-18 14:21:15 CEST

I will not enable the tests, please re-open if you are willing to take maintainership of this package and enable by yourself the tests.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 7 José Jorge 2017-06-18 14:21:34 CEST

Err

Resolution: FIXED => WONTFIX