Bug 8757

Summary: /usr/lib/rpm/mageia/gi-find-deps.sh incorrectly matches imports github
Product: Mageia Reporter: Joseph Wang <joequant>
Component: RPM PackagesAssignee: Mageia Bug Squad <bugsquad>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: Normal CC: cjw, fundawang
Version: Cauldron   
Target Milestone: ---   
Hardware: All   
OS: Linux   
URL: https://build.opensuse.org/package/view_file?file=gi-find-deps.sh&package=gobject-introspection&project=openSUSE%3AFactory
Whiteboard:
Source RPM: rpm-mageia-setup-1.166-2.mga3.src.rpm CVE:
Status comment:
Attachments: Regexp change

Description Joseph Wang 2013-01-20 15:17:13 CET
Description of problem:

Line 62 reads

                        for module in $(grep -h -P -o "imports.gi.([^\s'\";]+)\
" $file | grep -v "imports.gi.version" | sed 's,imports.gi.,,'); do

It should read

                        for module in $(grep -h -P -o "imports\.gi\.([^\s'\";]+)\
" $file | grep -v "imports.gi.version" | sed 's,imports.gi.,,'); do

As it is, this matches "imports github" which is incorrect....

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
Comment 1 Funda Wang 2013-01-20 15:37:28 CET
Would you mind providing a patch?

CC: (none) => fundawang

Comment 2 Joseph Wang 2013-01-20 16:29:20 CET
Created attachment 3420 [details]
Regexp change
Comment 3 Christiaan Welvaart 2013-01-20 17:57:00 CET
This script was taken from opensuse so I added their svn url as reference, AFAICS the problem is still there as well.

URL: (none) => https://build.opensuse.org/package/view_file?file=gi-find-deps.sh&package=gobject-introspection&project=openSUSE%3AFactory
CC: (none) => cjw

Comment 4 Christiaan Welvaart 2014-10-21 11:22:10 CEST
It looks like this issue was fixed in rpm-mageia-setup 1.168-1.mga3 (:

Status: NEW => RESOLVED
Resolution: (none) => FIXED