Bug 8413

Summary:	jpg background images do not show with lightdm-gtk-greeter
Product:	Mageia	Reporter:	Derek Jennings <derekjenn>
Component:	RPM Packages	Assignee:	Jani Välimaa <jani.valimaa>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	jani.valimaa
Version:	Cauldron	Keywords:	PATCH
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	3beta1
Source RPM:	lughtdm-1.4.0-6.mga3	CVE:
Status comment:

Description Derek Jennings 2012-12-17 15:05:36 CET

With lightdm-gtk-greeter in mga3beta1 the background is black

Selecting any .png image in /etc/lightdm/lightdm-gtk-greeter.conf  works OK, but any jpg image does not.

It appears to be the same as this bug report
https://bugs.launchpad.net/lightdm/+bug/1086199

Comment 1 Jani Välimaa 2012-12-17 15:30:55 CET

I've noticed same some times ago, but haven't found any solution, yet.

Assignee: bugsquad => jani.valimaa
Status: NEW => ASSIGNED
CC: (none) => jani.valimaa

Comment 2 Derek Jennings 2012-12-20 19:39:47 CET

Here is a small patch I worked out to fix this bug.
It works for me :-)


--- lightdm/src/lightdm-gtk-greeter.c	2012-08-30 18:39:09.000000000 +0100
+++ lightdm/src/lightdm-gtk-greeter.c	2012-12-20 18:30:03.216355000 +0000
@@ -801,6 +801,7 @@
            g_warning ("Failed to load background: %s", error->message);
         g_clear_error (&error);
         g_free (path);
+	background_pixbuf=gdk_pixbuf_add_alpha (background_pixbuf,FALSE,255,255,255);
     }
     else
         g_debug ("Using background color %s", value);

Whiteboard: (none) => 3beta1
Keywords: (none) => PATCH

Comment 3 Jani Välimaa 2012-12-20 21:11:42 CET

Thx, for your patch.

Modified it a bit [1] to avoid error [2] in log if background image loading fails before adding alpha channel.

New release should be in mirrors in any minute, please test it.

[1] http://svnweb.mageia.org/packages/cauldron/lightdm-gtk-greeter/current/SOURCES/lightdm-gtk-greeter-1.3.1-add-alpha-channel.patch?revision=333428&view=markup
[2] gdk_pixbuf_add_alpha: assertion `GDK_IS_PIXBUF (pixbuf)' failed

Comment 4 Derek Jennings 2012-12-21 00:33:36 CET

lightdm-gtk-greeter-1.3.1-3.mga3  is now displaying .jpg backgrounds OK

Comment 5 Jani Välimaa 2012-12-21 10:22:55 CET

Closing as fixed. Feel free to reopen if needed.

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED