| Summary: | drakx-finish-install should enable nonfree repo if nonfree packages are installed (live install | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Derek Jennings <derekjenn> |
| Component: | Installer | Assignee: | Olivier Blin <mageia> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | release_blocker | CC: | davidwhodgins, eeeemail, ennael1, mageia, thierry.vignaud, tmb, wassi |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.mageia.org/show_bug.cgi?id=9651 | ||
| Whiteboard: | 3final | ||
| Source RPM: | drakxtools | CVE: | |
| Status comment: | |||
| Attachments: |
Enable nonfree media if draklive has install nonfree packages
reuploaded patch Revised patch to use subroutine Output of journalctl -a |
||
|
Description
Derek Jennings
2012-12-13 01:06:54 CET
Derek Jennings
2012-12-13 01:07:28 CET
Whiteboard:
(none) =>
3beta1
Thierry Vignaud
2012-12-13 10:19:41 CET
CC:
(none) =>
thierry.vignaud
claire robinson
2013-01-10 22:36:04 CET
CC:
(none) =>
eeeemail, ennael1, tmb
Manuel Hiebel
2013-01-27 00:02:41 CET
Summary:
draklive-install should enable nonfree repo if nonfree packages are installed =>
drakx-finish-install should enable nonfree repo if nonfree packages are installed (live install Created attachment 3620 [details]
Enable nonfree media if draklive has install nonfree packages
Here is a simple proposed patch.
finish-install runs automatically after reboot following installation of Mageia Live. One of its tasks is to add online media.
This patch simply enables Nonfree and Nonfree Updates repositories if there are already nonfree packages installed by draklive
Created attachment 3624 [details] Revised patch to use subroutine This revised patch uses the subroutine in attachment 3622 [details] to enable Nonfree media on the first boot so long as there are already nonfree packages installed. Thierry can you have a look on that patch so that we can have it for beta 4?
Dave Hodgins
2013-03-25 02:56:21 CET
CC:
(none) =>
davidwhodgins
Dave Hodgins
2013-03-25 02:56:31 CET
Whiteboard:
3beta5 =>
3beta4
Manuel Hiebel
2013-04-07 22:06:02 CEST
See Also:
(none) =>
https://bugs.mageia.org/show_bug.cgi?id=9651 Created attachment 3709 [details]
Output of journalctl -a
With the latest iso images, draklive-finish-install is no
longer running the network configuration, or adding the
repositories.
Confirmed. Even with network configured in live mode and working after reboot, it is no missing the media config after installation. It seems to exit normally but just skip these parts, looking at Dave's log.. Apr 07 22:53:05 localhost finish-install[1667]: ignoring ask_network Apr 07 22:53:05 localhost finish-install[1667]: ignoring ask_urpmi Apr 07 22:53:05 localhost finish-install[1667]: ignoring ask_authentication Apr 07 22:53:05 localhost finish-install[1667]: ignoring ask_users Apr 07 22:53:05 localhost finish-install[1667]: calling ask_encrypt_home Apr 07 22:53:05 localhost finish-install[1667]: calling ask_glx Apr 07 22:53:05 localhost finish-install[1667]: modified file /etc/sysconfig/finish-install Apr 07 22:53:05 localhost finish-install[1667]: ### Program is exiting ### Hm, I think this is a fallout of me adding "Live Core" and "Live Nonfree" medias at end of live iso build in order to be able to provide grub2 and broadcom-wl packages to those installing without network Connection, so drakx skips media adding as it detects already configured medias. @blino, @tv: is there some way to tell drakx / finish-install to add online medias anyway ? Or atleast add the question... I think I could add a "urpmi.addmedia --distrib --mirrorlist" as one of the post-install scripts that runs once, but I think that would be a "hack" CC:
(none) =>
mageia Fixed by blino in drakxtools-15.37-1.mga3 Status:
NEW =>
RESOLVED oops, the fix in drakxtools-15.37-1.mga3 was only about comment 7, not all of this br Status:
RESOLVED =>
REOPENED
Dave Hodgins
2013-04-14 20:28:58 CEST
Whiteboard:
3beta4 =>
3RC While it now adds the repositories, only the Live Core, Live Nonfree, Core Release and Core Updates repositories are enabled. the Nonfree Release and Nonfree Updates still need to be enabled. Also, as the network configuration is completely skipped, the user is never given an opportunity to set the hostname. confirmed See also bug 9758 Still present after i586 RC install ... # urpmq --list-media active Core Release Nonfree Release Core Release2 Core Updates Is this fixed in Final first builds? I have just committed a fix in svn (r8197) This should also fix enabling nonfree repositories when configuring updates from the installer. Though, this will not fix bug 9758, since rpmdrake tools use different code. Status:
REOPENED =>
ASSIGNED Thanks Olivier, bug 8368 is similar too.
Dave Hodgins
2013-05-12 03:58:23 CEST
Whiteboard:
3RC =>
3final The fix needs to be pushed, and the iso images rebuilt. Yep, pushed them last night, will be on next isos Still valid 2nd build (15th May) (In reply to claire robinson from comment #21) > Still valid 2nd build (15th May) Did kernel-firmware-nonfree get removed at "remove unneeded packages / languages" ? according to svn commit r8197 that's the one being tracked... So it does not exactly a usable way... @blino: how about just doing something like checking installed rpm release tags like rpm -qa | grep ".nonfree" to enable nonfree medias and checking for ".tainted" for tainted medias... Yes, I think it does for me. Initial bug (enabling nonfree/tainted if such packages being installed) is fixed with latest urpmi kernel-firmware-nonfree is bug #10115 Status:
ASSIGNED =>
RESOLVED |