| Summary: | draksambashare asks to launch drakwizard which does not exist | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | papoteur <yvesbrungard> |
| Component: | RPM Packages | Assignee: | Mageia tools maintainers <mageiatools> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | anaselli, i18n-bugs, luke.nukem.jones, mageia, mageia, marja11, nikos769, thierry.vignaud |
| Version: | Cauldron | Keywords: | Junior_job |
| Target Milestone: | --- | ||
| Hardware: | i586 | ||
| OS: | Linux | ||
| URL: | http://svnweb.mageia.org/soft/drakx-net/trunk/bin/draksambashare?view=markup | ||
| Whiteboard: | MGA5TOO | ||
| Source RPM: | drakx-net | CVE: | |
| Status comment: | |||
| Attachments: | last step | ||
|
Manuel Hiebel
2012-11-18 00:01:55 CET
Keywords:
(none) =>
Junior_job First of all... I can't believe this bug has not been fixed yet!!! Just grep for "drakwizard sambashare" and delete this sentence. 2nd... The command "diskdrake --smb" mentioned above seems to do something different. It shows the Samba servers, not the shares. You could replace this sentence with something like... To manage your shares got to... Configure Your Computer (MCC) --> Local Disks --> Common use of partitions (I don't use English Mageia) CC:
(none) =>
231036448 it's here: http://gitweb.mageia.org/software/drakx-net/tree/bin/draksambashare#n1150 Assignee:
bugsquad =>
thierry.vignaud
Luke Jones
2015-12-03 10:11:26 CET
CC:
(none) =>
luke.nukem.jones
Luke Jones
2015-12-03 11:00:14 CET
Status:
NEW =>
ASSIGNED
Rémi Verschelde
2016-05-17 14:35:05 CEST
Assignee:
luke.nukem.jones =>
pkg-bugs
Samuel Verschelde
2016-08-27 16:36:37 CEST
Assignee:
pkg-bugs =>
mageiatools Is this just a matter of removing that line? or do we have to add a new command that works? I don't use mcc for samba...
We could change
N("If you have previously create some shares, they will appear in this configuration. Run 'drakwizard sambashare' to manage your shares.")
with
N("If you have previously create some shares, they will appear in this configuration.")
In any cases that breaks translations though... so we need to decide when change
that lineCC:
(none) =>
anaselli (In reply to Angelo Naselli from comment #3) > > In any cases that breaks translations though... so we need to decide when > change > that line I think there's still enough time to update the translations, if the pot and po files get updated at the same time as that string is shortened, because we're not yet near a releasable 6RC http://meetbot.mageia.org/mageia-qa/2016/mageia-qa.2016-08-25-19.03.log.html#l-83 However, it would need someone to remember to package the translation updates between 6RC and 6final, unless someone has time to remove the "Run 'drakwizard sambashare' to manage your shares." -sentence from that string in all translations. http://gitweb.mageia.org/software/drakx-net/tree/po/drakx-net.pot#n1665 CC'ing i18n CC:
(none) =>
i18n-bugs, marja11 hmm not always easy for instance: #: ../bin/draksambashare:1154 +#, fuzzy, c-format msgid "" "If you have previously create some shares, they will appear in this " -"configuration. Run 'drakwizard sambashare' to manage your shares." +"configuration." msgstr "" "妿æ¨ä¹åå·²ç¶å»ºç«äºä¸äºå±äº«ï¼å®åæåºç¾å¨æ¤è¨å®ä¸ãå·è¡ 'drakwizard " "sambashare' ä¾ç®¡çæ¨çå±äº«" I can remove that sentence, but i cannot manage other things, give me the go and i release new file and update_n_merge for po files. No, we won't break translations at that point, especially for such a minor bug that's already open for 4 years. Just wait until we reopen Cauldron _after_ mga6 release CC:
(none) =>
thierry.vignaud Thierry I agree, but this way of working shows that after the release the bug comes back into forgiveness... What is the bad side effect in this case? I think just having the old string into some localization e.g. no changes, Am I wrong? So... (In reply to Angelo Naselli from comment #7) > > What is the bad side effect in this case? I think just having the old string > into some localization e.g. no changes, Am I wrong? So... Unfortunately that is not true: instead of showing the old translated string, that contains two sentences, the new string (containting the first sentence) will be shown in English for all languages in which this string isn't updated. No problems, just recall to wake up someone after the release then... commit b704ef9609f144a1610b245db332b8174b1394ac
Author: Thierry Vignaud <thierry.vignaud@...>
Date: Sun Aug 28 18:25:18 2016 +0200
kill reference to "drakwizard sambashare" (mga#8112)
---
Commit Link:
http://gitweb.mageia.org/software/drakx-net/commit/?id=b704ef9609f144a1610b245db332b8174b1394ac
Ok, I did it in git. A couple languages got fuzzy (I fixed the others), mainly hebrew & chineses. I think I could have fixed he.po but I wasn't sure enough Status:
ASSIGNED =>
RESOLVED (In reply to Thierry Vignaud from comment #11) > Ok, I did it in git. > A couple languages got fuzzy (I fixed the others), mainly hebrew & chineses. > I think I could have fixed he.po but I wasn't sure enough Thanks, Thierry :-) I've had a few lessons in Hebrew, Arabic and even Chinese in some very distant past, I'll have a look whether I can figure it out for those languages note to myself: in vim, use: ":set rl" to set for a RTL language ":set norl" to set back to normal My 2cents on the matter, when it comes to translations. There are always some stuff left untranslated, for various reasons. Personally, in a .po file, when more than 90% of the strings have been translated I consider this translation done. So, I don't think that you should make a big deal out of it. And from a different point of view: better to have the right string in a foreign language (English), than having the wrong string in your native language. (In reply to Marja van Waes from comment #12) > I'll have a look whether I can figure it out for those > languages Sorry, I didn't manage. > > ":set rl" to set for a RTL language > ":set norl" to set back to normal Even if that wasn't the reason for not managing: The above is not enough: vim's behaviour is unpredictable. While editing a line the letters move, which makes it hard to see what you're doing, and words on one line can even become LTR while the rest of the text is still RTL (In reply to Marja van Waes from comment #14) > (In reply to Marja van Waes from comment #12) > > > I'll have a look whether I can figure it out for those > > languages > > Sorry, I didn't manage. > > > > > ":set rl" to set for a RTL language > > ":set norl" to set back to normal > > Even if that wasn't the reason for not managing: The above is not enough: > vim's behaviour is unpredictable. While editing a line the letters move, > which makes it hard to see what you're doing, and words on one line can even > become LTR while the rest of the text is still RTL vim is not reliable with Arabic, at least on a non-Arabic locale. I'll try it later at home CC:
(none) =>
mageia |
Created attachment 3109 [details] last step The wizard draksambashare suggests at the last step to run "drakwizard sambashare". But this option in drawizard is no more available. It could be diskdrake --smb instead.