Bug 758

Summary: Quickly make xdm less austere
Product: Mageia Reporter: Georges Eckenschwiller <paiiou>
Component: RPM PackagesAssignee: Mageia Bug Squad <bugsquad>
Status: RESOLVED OLD QA Contact:
Severity: enhancement    
Priority: Normal Keywords: Junior_job, PATCH
Version: Cauldron   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: xinitrc CVE:
Status comment:
Attachments: The patch
New patch
Source rpm

Description Georges Eckenschwiller 2011-04-10 18:31:46 CEST
Hello,

The display manager xdm can be made less austere ââby adding a image.

For this, simply add one line to Xsetup_0 applying the patch attached.

Reproducible: 

Steps to Reproduce:
Comment 1 Georges Eckenschwiller 2011-04-10 18:33:52 CEST
Created attachment 222 [details]
The patch
Comment 2 Ahmad Samir 2011-04-10 22:04:44 CEST
qiv was used to put a background for xdm, the problem is it interfered with other display managers.

See: https://qa.mandriva.com/show_bug.cgi?id=15758

(Also xv is in the nonfree tool as it's a shareware).
Comment 3 Georges Eckenschwiller 2011-04-11 08:49:57 CEST
This would leave the display command from imagemagick.

Would there also conflict with other display manager?

Personally, I've tried that xv.
Comment 4 Georges Eckenschwiller 2011-04-11 10:11:08 CEST
By searching on the internet I also found the command xsetbg (package xli by Mandriva)
Comment 5 Ahmad Samir 2011-04-12 07:42:07 CEST
I am not sure it's related to the command used.
Comment 6 Georges Eckenschwiller 2011-04-12 15:47:22 CEST
Hello, 

I just downloaded the package xli of Mandriva. 
I installed it without problems (rpm -ivh). 

I added the line /usr/bin/xsetbg -onroot /usr/share/mga/backgrounds/default.jpg in 
Xsetup_0 file 

I rebooted with kdm/xfce4: OK, with the wallpaper. 
I then modified with MCC to start with xdm/xfce4 
still OK: with the wallpaper, however it was not the optimal size 

For me, the solution with a package xli would be the best. 
Can you integrate the xli package in Mageia ?
Comment 7 Georges Eckenschwiller 2011-04-12 16:17:21 CEST
By changing the line, the picture is correctly sized: 
/usr/bin/xsetbg -onroot -fullscreen /usr/share/mga/backgrounds/default.jpg
Comment 8 Ahmad Samir 2011-04-12 21:24:27 CEST
What https://qa.mandriva.com/show_bug.cgi?id=15758 is about, is if you try to change the default background in e.g. KDM, using kdm settings kcm (in systemsettings -> Login Screen), to something other than /usr/share/mga/backgrounds/default.jpg, that setting doesn't work, i.e. the background stays /usr/share/mga/backgrounds/default.jpg .
Comment 9 Georges Eckenschwiller 2011-04-13 10:47:51 CEST
I just reinstall kdm (which I had already deleted) 

But I can not find menu systemsettings -> Login Screen 
That would make it part of kde? 
KDE is not installed and the hard drive of this machine is almost full.
Comment 10 Georges Eckenschwiller 2011-04-13 17:20:04 CEST
(In reply to comment #9)
> I just reinstall kdm (which I had already deleted) 
> 
> But I can not find menu systemsettings -> Login Screen 
> That would make it part of kde? 
By searching on the internet, I found that this is kde4-workspace

> KDE is not installed and the hard drive of this machine is almost full.
After uninstalling several applications, I could install kde4-workspace.

By restarting with kdm, I found that:
- I have the bootsplash from plymouth
- then I have briefly the image default.jpg
- and then I get the image selected, stably
Comment 11 Georges Eckenschwiller 2011-04-13 17:28:54 CEST
(In reply to comment #9)
> I just reinstall kdm (which I had already deleted) 
> 
> But I can not find menu systemsettings -> Login Screen 
> That would make it part of kde? 
By searching on the internet, I found that this is kde4-workspace

> KDE is not installed and the hard drive of this machine is almost full.
After uninstalling several applications, I could install kde4-workspace.

By restarting with kdm, I found that:
- I have the bootsplash from plymouth
- then I have briefly the image default.jpg
- and then I get the image selected, stably
Comment 12 Georges Eckenschwiller 2011-04-13 20:27:14 CEST
I could not find how to file Xsetuo_0 interferes with kdm.
Since in the directory / usr/share/X11/xdm I do not see the connection with kdm.

In fact, we should be able to find a way to limit the action of xsetbg.
It would take only when xdm is demand.

My knowledge does allow me to find how.
Comment 13 Ahmad Samir 2011-04-14 02:31:04 CEST
Xsetup_0 isn't shipped in the xdm package, but actually in the xinitrc package which is not used only by xdm.
Comment 14 Georges Eckenschwiller 2011-04-14 08:29:35 CEST
Hello,

Finally, I think I found a solution, using the file /var/run/xdm.pid

Lines to be inserted in Xsetup_0 would include:


if [ -r /usr/share/mga/backgrounds/default.jpg -a -x /usr/bin/xsetbg -a -f /var/run/xdm.pid ]; then
    /usr/bin/xsetbg -onroot -fullscreen /usr/share/mga/backgrounds/default.jpg
fi

It remains to integrate the package xli
Comment 15 Georges Eckenschwiller 2011-04-14 09:02:23 CEST
Hello,

Finally, I think I found a solution, using the file /var/run/xdm.pid

Lines to be inserted in Xsetup_0 would include:


if [ -r /usr/share/mga/backgrounds/default.jpg -a -x /usr/bin/xsetbg -a -f /var/run/xdm.pid ]; then
    /usr/bin/xsetbg -onroot -fullscreen /usr/share/mga/backgrounds/default.jpg
fi

It remains to integrate the package xli
Comment 16 Georges Eckenschwiller 2011-04-17 10:28:49 CEST
Can you edit the xinitrc package including the 3 lines. 
I open a separate report for package xli. 
Thank you
Comment 17 Georges Eckenschwiller 2011-05-15 16:35:55 CEST
To display the wallpaper, in place of the xli, it is possible to use the package qiv which already exists.

It would then add three lines a Xsetup_0:

if [ -r /usr/share/mga/backgrounds/default.jpg -a -x /usr/bin/qiv -a -f
/var/run/xdm.pid ]; then
/usr/bin/qiv -x /usr/share/mga/backgrounds/default.jpg
fi

This would make xdm more pleasant.
Comment 18 Georges Eckenschwiller 2011-06-21 17:46:36 CEST
Created attachment 598 [details]
New patch

The time would it not well chosen to add the patch attached.

I checked with pstree and ps-ef : /usr/bin/xdm is only used with XDM.
Or KDM or GDM or LXDM or SLiM not use it.

Païou

Attachment 222 is obsolete: 0 => 1

Comment 19 Georges Eckenschwiller 2011-09-03 14:18:08 CEST
What about this proposal? 

Y is there a reason not to act upon?
Manuel Hiebel 2011-09-03 21:21:05 CEST

Keywords: (none) => Junior_job, PATCH

Manuel Hiebel 2011-10-29 13:21:24 CEST

Source RPM: (none) => xinitrc

Comment 20 Georges Eckenschwiller 2011-11-13 10:00:41 CET
Created attachment 1056 [details]
Source rpm

I research how to build packages according to the standards Mageia.
I was able to rebuild the xinitrc package including the patch.

To integrate the deposit Mageia, 
- just check Version, Release, and the Changelog in the
specfile. 
- Then rebuild in the environment Mageia.

Attachment 598 is obsolete: 0 => 1

Comment 21 Georges Eckenschwiller 2011-12-10 10:29:03 CET
Now that lxdm can connect properly, xdm can remain in the state.

Status: NEW => RESOLVED
Resolution: (none) => OLD