Bug 7429

Created attachment 2780 [details]
Patch to fix the problem.

This is a patch to fix the problem. Please apply it.

Assigning to Thierry Vignaud.

Assignee: bugsquad => thierry.vignaud

See with Dexter Morgan, he is the one that commited pok's changes

Assignee: thierry.vignaud => dmorganec

(In reply to comment #3)
> See with Dexter Morgan, he is the one that commited pok's changes

Those were to rpm, not rpm-mageia-setup, and just fixed things, not caused breakage.  Building ruby gem packages should be simpler and compatible with mdv now.  It certainly wouldn't have anything to do with what changed in ruby 1.9.3.

CC: (none) => luigiwalser

Hi,

(In reply to comment #4)
> (In reply to comment #3)
> > See with Dexter Morgan, he is the one that commited pok's changes
> 
> Those were to rpm, not rpm-mageia-setup, and just fixed things, not caused
> breakage.  Building ruby gem packages should be simpler and compatible with mdv
> now.  It certainly wouldn't have anything to do with what changed in ruby
> 1.9.3.

So what should we do now? Who will commit the patch to the svn, release a new version and prepare a new package?

Regards,

-- Shlomi Fish

I think it's probably OK for you to update the code in the /soft/ svn tree as needed Shlomi, and then issue a release yourself.

Funda did this just the other day, so here is a (semi) template of what to do with his commits as examples (NOTE, he never submitted his build to the BS, so you should also test it and make sure his changes are sensible and valid. You should also double check any commits done since the previous release generally just in case someone has made some bogus changes, committed them and never pushed to production. If you find problems you should mock the committer mercilessly until they cry, or just send them a friendly pointer/query if you prefer! :p).


1. First commit the code changes needed. Make sure to reference where the patch came from if appropriate (i.e. if it came from Mdv, please say so). Also do not forget to bump the version in the appropriate places and update the news file.
http://svnweb.mageia.org/soft?view=revision&revision=5759

2. Build a tarball. I'm not sure of the exact procedure here but it's typically a matter of running ./autogen.sh and running "make dist".

3. Update the package and make sure the new tarball works as expected and you can install your updated package and it solves the bug. See here: http://svnweb.mageia.org/packages?view=revision&revision=289992 Note: don't commit this change yet.

4. Tag the svn release. This doesn't seem to have been done of late, so I wouldn't worry too much about it.

5. Now this is "official", you can commit the package change made in 3, upload the binary via mgarepo and and submit it for build.


When changing RPM stuff it's quite easy to break the build system which requires sysadmin intervention. So testing is key here, and blind submits will be very much frowned upon :)


If you do anything wrong, I'm sure the resident guardian of commits, Thierry, will notice and give you a friendly pointer (or ridicule you in public depending on the severity of the mistake!) :)

Hope that helps.

Col

CC: (none) => mageia

(In reply to comment #6)
> I think it's probably OK for you to update the code in the /soft/ svn tree as
> needed Shlomi, and then issue a release yourself.

Thanks, Colin!

I did all that and now my changes are in Cauldron core/updates_testing.

Regards,

-- Shlomi Fish

Fixed since 1.159

Status: NEW => RESOLVED
Resolution: (none) => FIXED