Bug 6448

Summary: No plugins for VPN OpenL2TP, there are errors in ppp.spec file
Product: Mageia Reporter: Alex Loginov <loginov_alex>
Component: RPM PackagesAssignee: Mageia Bug Squad <bugsquad>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: thierry.vignaud
Version: 2Keywords: Junior_job, PATCH
Target Milestone: ---   
Hardware: All   
OS: Linux   
See Also: https://bugs.mageia.org/show_bug.cgi?id=5741
Whiteboard:
Source RPM: ppp CVE:
Status comment:

Description Alex Loginov 2012-06-13 19:29:15 CEST
It's necessary to change spec file:

1)
-perl -pi -e "s|^(LIBDIR.*)\\\$\(DESTDIR\)/lib|\1\\\$(INSTROOT)%{_libdir}|g" pppd/Makefile.linux pppd/plugins/Makefile.linux pppd/plugins/{pppoatm,radius,rp-pppoe}/Makefile.linux
+perl -pi -e "s|^(LIBDIR.*)\\\$\(DESTDIR\)/lib|\1\\\$(INSTROOT)%{_libdir}|g" pppd/Makefile.linux pppd/plugins/Makefile.linux pppd/plugins/{pppoatm,radius,rp-pppoe,pppol2tp}/Makefile.linux

2)
-%makeinstall INSTROOT=%{buildroot} SUBDIRS="pppoatm rp-pppoe radius"
+%makeinstall INSTROOT=%{buildroot} SUBDIRS="pppoatm rp-pppoe radius pppol2tp"
Alex Loginov 2012-06-13 19:30:28 CEST

Summary: No plugins for VPN OpenL2TP, there are errors in spec file => No plugins for VPN OpenL2TP, there are errors in ppp.spec file

Manuel Hiebel 2012-06-25 05:31:01 CEST

Keywords: (none) => PATCH
See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=5741
Source RPM: ppp-2.4.5 => ppp

Comment 1 Alex Loginov 2012-07-11 12:09:23 CEST
When will new version be?
Comment 2 Manuel Hiebel 2012-07-11 17:33:19 CEST
since there is no maintainer, I don't know ;)

CC: (none) => thierry.vignaud

Thierry Vignaud 2012-07-23 14:28:46 CEST

Keywords: (none) => Junior_job

Comment 3 Thierry Vignaud 2012-07-28 17:04:29 CEST
It doesn't compile:
cc -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fPIC -I. -I../.. -I../../../include -fPIC -c -o pppol2tp.o pppol2tp.c
In file included from pppol2tp.c:49:0:
/usr/include/linux/if_pppox.h:84:26: error: field 'pppol2tp' has incomplete type
/usr/include/linux/if_pppox.h:99:28: error: field 'pppol2tp' has incomplete type

(http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20120728150238.tv.valstar.26525/log/ppp-2.4.5-9.mga3/build.0.20120728150238.log)
Comment 4 Alex Loginov 2012-07-28 21:27:29 CEST
No problem: ftp://ftp.mageialinux.ru/mageia2/SRPMS/ppp-2.4.5-7.mrc.mga2.src.rpm
Comment 5 Thierry Vignaud 2012-08-06 20:01:23 CEST
I fixed build in cauldron.
Please test
Comment 6 Thierry Vignaud 2012-08-06 20:20:53 CEST
ppp-2.4.5-9.mga3 is the one you want to test
Comment 7 Alex Loginov 2012-08-17 10:34:17 CEST
OK

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 8 Thierry Vignaud 2012-08-21 14:35:03 CEST
Do you want us to backport this as an update for mageia 2?
Comment 9 Alex Loginov 2012-08-21 18:10:01 CEST
Yes.