Bug 6055

I confirm.
scilab-cli.desktop and scilab-adv-cli.desktop:
Icon=/usr/share/scilab-cli/icons/scilab.xpm
Directory scilab-cli does not exists.

CC: (none) => loginov_alex

scilab-5.4.0-2.mga3.i586 have bug also.

Keywords: (none) => Junior_job
Hardware: x86_64 => All
Version: 2 => Cauldron

Created attachment 4935 [details]
spec with fix

This patch for spec fixes this bug and deletes double desktop file.

Alex, can you also fix the desktop categories so that Scilab (and Xcos) are not listed both in Science::Physics and Science::Math, but only in Science::Physics?

(In reply to Rémi Verschelde from comment #4)
> Alex, can you also fix the desktop categories so that Scilab (and Xcos) are
> not listed both in Science::Physics and Science::Math, but only in
> Science::Physics?

Why Physics?
I understand your point that been listed in both is a problem, but Scilab can be used to do mathematics without any link to an application domain.
For Xcos, I agree that it's only physics.

Is it possible to put Scilab in Science::Maths and Xcos in Science::Physics?

(In reply to Claire Revillet from comment #5)
> 
> Why Physics?
> I understand your point that been listed in both is a problem, but Scilab
> can be used to do mathematics without any link to an application domain.
> For Xcos, I agree that it's only physics.
> 
> Is it possible to put Scilab in Science::Maths and Xcos in Science::Physics?

I admit the proposal was arbitrary, it's just that I don't like it being in two categories :) Science::Engineering would be good, but I don't think there is such a category. Scilab in Science::Math and Xcos in Science::Physics would be fine by me.

Created attachment 4942 [details]
spec with fix

Done for Icons and Categories.

Created attachment 4943 [details]
Done for Icons and Categories.

Attachment 4935 is obsolete: 0 => 1
Attachment 4942 is obsolete: 0 => 1

Created attachment 4944 [details]
spec with fix

Attachment 4943 is obsolete: 0 => 1

Alex, please use the desktop-file-utils (desktop-file-edit for example) to alter .desktop files

(In reply to Samuel VERSCHELDE from comment #10)
> Alex, please use the desktop-file-utils (desktop-file-edit for example) to
> alter .desktop files

or patches. sed will not allow to detect future upstream changes in the desktop files. Patches will allow it because they'll fail and need re-diff. It's a good thing if patches fail: it forces us to ask ourselves "is that patch still pertinent?"

In this case we had own %{_real_vendor}-%{name}.desktop with Categories=Science;Math;
I deleted %{_real_vendor}-%{name}.desktop.
With help sed I returned our Categories permanently in the future, but in upstream's desktop files.

Alex. You are an experienced packager and that's great. However, contributing to the core of Mageia requires not only packaging skills, but also the ability to respect the policies.

Here, I'm asking you to use a patch instead of sed to alter the .desktop files, so that future changes from upstream in the .desktop files are automatically detected during build (the patch will fail if the the desktop file has changed, which will allow us to review if the patch is still needed or not).

Created attachment 4955 [details]
spec with fix

Attachment 4944 is obsolete: 0 => 1

Created attachment 4956 [details]
patch for desktop

This patch fixes Icons, Categories and adds Russian.

Patch and spec file committed with only a small change to the spec: naming of the patch. Submitted to cauldron.

Patch was sent into upstream http://bugzilla.scilab.org/show_bug.cgi?id=13229

Let's put updates for mga4.

Updated in Cauldron and in Mageia 4, uploaded by stormi.

Advisory:
========================

Updated scilab:
- add Russian comments in desktop files
- fix icons for scilab-cli, scilab-adv-cli
- fix categories in desktop files
- delete double Scilab from Menu

========================

Updated packages in core/updates_testing:
========================
scilab-5.5.0-0.beta1.4.mga4

from SRPMS:
scilab-5.5.0-0.beta1.4.mga4.src.rpm

Assignee: stormi => qa-bugs

Claire and Yann could you test the fixes please and ensure scilab still works as expected. It would be useful if you could give a quick procedure here how to test scilab too so that we can refer to it the next time it is updated.

Thanks!

Testing complete Mageia 4 i586. I did not specifically test in KDE, but I can confirm that the similar fix pushed to cauldron does the trick in KDE, and given the simplicity of the fix, I consider it good.

Whiteboard: (none) => MGA4-32-OK

Testing complete Mageia 4 x86_64.

Whiteboard: MGA4-32-OK => MGA4-32-OK MGA4-64-OK

Validating update, advisory uploaded. Please push to 4 core/updates.

Keywords: (none) => validated_update
Whiteboard: MGA4-32-OK MGA4-64-OK => MGA4-32-OK MGA4-64-OK advisory
CC: (none) => sysadmin-bugs

Update pushed:
http://advisories.mageia.org/MGAA-2014-0058.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED