| Summary: | check the option of mgaapplet-upgrade-helper before the launch | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Jeff Robins <jeffrobinsSAE> |
| Component: | RPM Packages | Assignee: | Mageia tools maintainers <mageiatools> |
| Status: | REOPENED --- | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | Normal | CC: | doktor5000, marja11, thierry.vignaud |
| Version: | Cauldron | Keywords: | Junior_job |
| Target Milestone: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | MGA2TOO | ||
| Source RPM: | mgaonline | CVE: | |
| Status comment: | |||
|
Description
Jeff Robins
2012-05-23 08:07:55 CEST
indeed it was working fine yesterday :/ sysadmin, any change in the api ? Priority:
Normal =>
High
Manuel Hiebel
2012-05-23 08:23:04 CEST
CC:
(none) =>
mageia-webteam Release 2 has been added to api now. Can you try again ? CC:
(none) =>
boklm Unfortunately I needed to start the upgrade and the upgrade worked once I used the proper switch/option, so I started the upgrade process. I'd rather not take a chance and quit the process. I'm on package 1374 of 2210. After looking at Manuel's post he may have missed that I used the wrong switch/option when I ran it initially (I spelled out the whole word "distribution"). I'm just reporting that the program doesn't provide an error and provides a misleading output when the wrong switches/options are used. I had a look at the mgaapplet-upgrade-helper script and it just looks like there is no check for invalid switches/options. Thank you, Jeff My bad, it seems the option was changed since 2010.2 sorry :/ http://svnweb.mageia.org/soft/mgaonline/trunk/mgaapplet-upgrade-helper?revision=4158&view=markup 48 $::rpmdrake_options{$1}[0] = $2; 49 } elsif ($opt =~ /--new_distro_version=(.*)/) { 50 $new_distro_version = $1; with mgaapplet-upgrade-helper --new_distro_version=2 it works fine /me change the wiki ok sorry all Keywords:
(none) =>
Junior_job What are you saying? The --new_distro_version option never changed and is named this since its introduction in 2008 yes sorry, I was wrong at any point on this bug... Closing then Status:
NEW =>
RESOLVED I still think there is a problem because the script will run without checking for required arguments. I did not supply "new_distro_version" and the script still ran like I did and gave me a congratulations message. Also, we should probably fix the spelling of successful. --Jeff Status:
RESOLVED =>
REOPENED You're not supposed to run it anyway. Mgapplet is the one that starts it. There are instructions for running it manually in the Release Notes, which I freely admit I screwed up. If we never provided instructions on how to run the program manually, then I could see the argument for not checking the arguments. TBH, I would add argument checking anyway because it shouldn't be too much work and the program isn't time critical. Providing some documentation on the script would also be helpful, even if it's just with the "--help" argument. --Jeff
Manuel Hiebel
2012-10-31 20:15:05 CET
Version:
1 =>
Cauldron
Nicolas Vigier
2014-03-24 10:52:23 CET
CC:
boklm =>
(none)
Florian Hubold
2015-11-24 17:39:52 CET
CC:
(none) =>
doktor5000 Assigning to tv who, I believe, is the maintainer for mgaonline. Are you? If so, please update the maintainers database. Assignee:
bugsquad =>
thierry.vignaud
Marja Van Waes
2017-03-29 08:09:55 CEST
CC:
(none) =>
marja11 |