Bug 5941

Also observed on i586DVD install

CC: (none) => john
Hardware: x86_64 => All

Valid still for 3rd set of ISOs 18/05

For having those icons, there must be fitting .desktop files in ~/Desktop/
But I wouldn't know how to get them there.
KDE seems to somehow create them on first start.

Imho this is only a minor problem.

Priority: Normal => Low
Severity: normal => minor

Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Since I didn't change anything, it should be.
I will investigate it further.

Status: NEW => ASSIGNED

Created attachment 3248 [details]
lxde-desktop-icons

After noticing mga3beta1 still has this problem I took a look and came up with this little patch to go into mageia-lxde-config-Default

It is a .desktop file to go into /etc/xdg/autostart
When a user logs in with lxde it will drop icons for Home and Trash on the desktop if they do not already exist.

The icons are only visible in LXDE so it will not clutter up other DE desktops.

WDYT?

I can see that mageia-lxde-config.tar.xz source has gone from svn. This bug probably related with that. Any further ideas?

CC: (none) => tarakbumba

It would add those icons, even if the user chose to delete them.
So I think, it's better not to have those icons there.

@Atilla: The sources have never been stored in SVN at mageia. We use a binary repository for storing tarballs as storing them in SVN is a bad idea that does not scale well. Use "mgarepo co/up/upload/del" rather than "svn co/up".

CC: (none) => mageia

valid 3RC

Whiteboard: 3beta1 3beta2 (MGA2) => 3beta1 3beta2 (MGA2) 3RC

Created attachment 3752 [details]
This patch adds capability to add icons to desktop

I have worked on this. I think we need to adjust lxde-common package to get things in order. I've found the solution to using startlxde.sh to add icons to desktop. Attached patch does this. However i can not find a way to determine lxde's first run. So, i used openbox user configuration files for this.

Attachment 3248 is obsolete: 0 => 1

Created attachment 3753 [details]
mageia-lxde-config desktop files and specfile diff

Addition to my above comment and patch, mageia-lxde-config package needs to be updated with required desktop files.

(In reply to Colin Guthrie from comment #9)
Thank you Colin. I' m still a learning apprentice and this was new for me. Mandriva used to include source tarballs on svn if i remember correctly.

(In reply to Atilla ÃNTAÅ from comment #11)
> Created attachment 3752 [details]
> This patch adds capability to add icons to desktop
> 
> I have worked on this. I think we need to adjust lxde-common package to get
> things in order. I've found the solution to using startlxde.sh to add icons
> to desktop. Attached patch does this. However i can not find a way to
> determine lxde's first run. So, i used openbox user configuration files for
> this.

Looks good to me.  I have also been taking a look at this recently and have not found any better way of detecting first run.

valid 3RC 3rd build (19th april)

Fixed in cauldron. Closing as resolved-fixed.

Fixed in cauldron. Closing as resolved-fixed.

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

So, no we do have what I said in comment #8
The user is forced to have those icons or use some ugly workarround like deleting that desktop file...
Just deleting those icons from ~/Desktop/ will recreate them on next login.

That's what the German users are complaining about in the forums.

My suggestion would be, to create a dummy config file, e.g. ~/.config/.lxde/mga-firstrun (can be named differently), if it does not already exist.

If it does not exist add those icons, if it does, don't do anything.

I seem to be not the only user, who does not want such (or any) icons on his desktop.

Any comments? If not, I'll implement it tonigth and ask for further comments based on my implementation.

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Sounds like a good solution Oliver. Users shouldn't be forced to have those icons on the desktop if they choose to delete them, but they should be present on first run.

(In reply to Oliver Burger from comment #18)
I don't understand why desktop icons recreated at every login. I have locally tested latest changes to lxde-common and it worked for me. Especially startlxde script included in lxde-common package, should detect if it is first run or not. 

I reviewed my patch and see that i messed up. Please wait before committing any changes. I' ll rediff startlxde script to work appropirately.

Created attachment 3846 [details]
This patch adds capability to add icons to desktop version2

I have rediffed my proposal patch.It should fix this issue. Logic is startlxde script detects if it is first run (checks ~/.config/openbox/lxderc.xml is available) it installs icons to desktop. 

I have tested locally and it worked for me. Somehow committed before patch have been modified??

I have asked to my mentor commit changes. After that i'll ask for freeze push at devel mailing list. Please be patient.

Attachment 3752 is obsolete: 0 => 1

(In reply to Atilla ÃNTAÅ from comment #21)
Hopefully fixed in svn permanently. Should be pushed soon. Please install lxde-common and mageia-lxde-Default-config packages when pushed, and feedback.

Cauldron and the Mga 3 installation media still have  lxde-common-0.5.5-13.mga3 with the problem described in Comment 18.
Can we get  lxde-common-0.5.5-14.mga3 into Updates Testing so we can validate it and released as an update?

On my LXDE box (a very standard Mageia2) I never had a file called "~/.config/openbox/lxderc.xml" but only "~/.config/openbox/rc.xml" and of course, the .desktop files are recreated after every reboot. I needed to manually ln -s the rc.xml to lxderc.xml in order to fix the annoyance.

CC: (none) => muie1121

Valid 4beta1 from DVD 64 with default LXDE installation.

Whiteboard: 3beta1 3beta2 (MGA2) 3RC => 4beta1 3beta1 3beta2 (MGA2) 3RC

report.bug.xz can be found in attachment 4479 [details]

lxde-common-0.5.5-18.mga4 package submitted to core/updates_testing.

This package should fix mageia specific .desktop files creation in user's desktop directory.(mga#5941) 
**********************************************************
Please test and feedback. Thanks!

I have uploaded a patched/updated package for Mageia 3.

Suggested advisory:
========================

Updated lxde-common package to fix :
No Mageia specific and trash desktop files in LXDE. To achieve fix, a rediffed lxde-common-0.5.5-add-mageia-desktop-icons.patch is used.

References:
https://bugs.mageia.org/show_bug.cgi?id=5941
========================

Updated packages in core/updates_testing:
========================
lxde-common-0.5.5-13.1.mga3.i586.rpm
lxde-common-0.5.5-13.1.mga3.x86_64.rpm

Source RPMs: 
lxde-common-0.5.5-13.1.mga3.src.rpm

Assignee: oliver.bgr => qa-bugs

*** Bug 10286 has been marked as a duplicate of this bug. ***

CC: (none) => isolde

Yaaay, it worked !!!  On 32-bit that is, I'll report back on 64-bit as soon as possible.

Whiteboard: advisory => advisory MGA3-32-OK

Looks good on 64-bit as well.  Many thanks, Atilla, and also to the others who helped.

Update validated.

See comment 28 for advisory and SPRM.

Could sysadmin please push from core/updates_testing to core/updates.

Thank you.

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs
Whiteboard: advisory MGA3-32-OK => advisory MGA3-32-OK MGA3-64-OK

(In reply to Carolyn Rowse from comment #31)
Your welcome :)

Then, i' m closing this bug report as Resolved - Fixed.

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

No, you're not closing it until the sysadmins have pushed the update to all users :)

Status: RESOLVED => REOPENED
CC: (none) => stormi
Resolution: FIXED => (none)

(In reply to Samuel VERSCHELDE from comment #34)
Ok. Waiting then :)

Update pushed:
http://advisories.mageia.org/MGAA-2014-0003.html

Status: REOPENED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED