Bug 5800

Summary:	partitionning wizard fails on RAID upgrade
Product:	Mageia	Reporter:	Thierry Vignaud <thierry.vignaud>
Component:	Installer	Assignee:	Pascal Terjan <pterjan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	j2p
Version:	Cauldron	Keywords:	NEEDINFO
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	MGA2TOO
Source RPM:	drakxtools	CVE:
Status comment:

Description Thierry Vignaud 2012-05-09 11:42:25 CEST

partitionning wizard fails on RAID upgrade: when one tries to select a RAID instead of a disk in the pull down menu, the partitionning wizard
complains:
"Error: Not an ARRAY reference at (...)diskdrake/hd_gtk.pm line 441"

Only solution is back to custom partitioning...

Comment 1 Pascal Terjan 2012-05-09 11:50:40 CEST

Hmm raids were not listed there in the past afaik. I'll try to have a look tonight.

Comment 2 Thierry Vignaud 2012-05-09 12:19:45 CEST

They are since commit r265764 of yours on Feb 4 2010, as a side effect of:
"partitioning wizard: offer to install on dmraid and existing lvm"

The error was there since (at least for soft raids). I fixed it, it resulted in the bogus "use empty space" bug you fixed which reintroduced it.

Comment 3 Pascal Terjan 2012-05-10 01:27:15 CEST

It is broken because $kind->{val} is not an array with raid2real_kind.

push @kinds, diskdrake::hd_gtk::raid2real_kind($_) foreach @{$all_hds->{raids}};

In diskdrake there is only one tab for all raids, which contain a list of raid volumes, each being handled as a partition.
Then you can select one and put for example lvm on it but not several partitions.

The introduction of raid2real_kind added another kind with type 'raid' but val not being a list of partitions but a single partition (raid volumes are handled as partitions not disks).

Comment 4 Marja Van Waes 2012-05-26 13:04:05 CEST

Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Comment 5 jean pierre pagani 2012-06-01 09:29:34 CEST

i have the same problem with raid 0 when i want to update to mageia2

i reinstall back to  mageai1

CC: (none) => j2p

Manuel Hiebel 2012-08-18 15:47:06 CEST

Keywords: NEEDINFO => (none)
Source RPM: (none) => drakxtools
Whiteboard: (none) => MGA2TOO

Comment 6 Dick Gevers 2014-11-25 12:49:45 CET

@tv, pascal or other: in case still valid please revise whiteboard and keyword

Keywords: (none) => NEEDINFO

Comment 7 Thierry Vignaud 2015-04-03 21:03:27 CEST

Fixed in git.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 8 Mageia Robot 2015-04-03 21:06:42 CEST

commit 5cc6ac8d00328f695a529bcbf81efa86412b8341
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Mar 27 11:25:04 2015 -0400

    do not offer to select RAID as it result in a crash
    
    rationale: we only show top storage devices which are the ones that work
    Fix mga#5800
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=5cc6ac8d00328f695a529bcbf81efa86412b8341