Bug 4825

Summary: gi-find-deps.sh doesn't handle scripts without .py
Product: Mageia Reporter: Anssi Hannula <anssi.hannula>
Component: RPM PackagesAssignee: Mageia Bug Squad <bugsquad>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: cjw, fundawang, mageia, rwobben, thierry.vignaud
Version: CauldronKeywords: PATCH
Target Milestone: ---   
Hardware: All   
OS: Linux   
URL: https://build.opensuse.org/package/view_file?expand=1&file=gi-find-deps.sh&package=gobject-introspection&project=GNOME%3AFactory
Whiteboard:
Source RPM: rpm-mageia-setup CVE:
Status comment:
Attachments: Patch with syncs with OpenSuse (adding file based probing for python files)

Description Anssi Hannula 2012-03-06 19:20:29 CET
/usr/lib/rpm/mageia/gi-find-deps.sh only detects *.py files as Python scripts. However there can be Python scripts in /usr/bin without *.py ending.

I guess it should run 'file' for files in /usr/bin/ to see if they are python scripts. Example affected package is gcdemu (1.5.0+), I had to add the Typelib() dependencies myself.
Manuel Hiebel 2012-03-07 00:04:42 CET

Assignee: bugsquad => boklm

Comment 1 Marja Van Waes 2012-05-26 13:05:57 CEST
Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Comment 2 Marja Van Waes 2012-07-06 15:06:22 CEST
Please look at the bottom of this mail to see whether you're the assignee of this  bug, if you don't already know whether you are.


If you're the assignee:

We'd like to know for sure whether this bug was assigned correctly. Please change status to ASSIGNED if it is, or put OK on the whiteboard instead.

If you don't have a clue and don't see a way to find out, then please put NEEDHELP on the whiteboard.

Please assign back to Bug Squad or to the correct person to solve this bug if we were wrong to assign it to you, and explain why.

Thanks :)

**************************** 

@ the reporter and persons in the cc of this bug:

If you have any new information that wasn't given before (like this bug being valid for another version of Mageia, too, or it being solved) please tell us.

@ the reporter of this bug

If you didn't reply yet to a request for more information, please do so within two weeks from now.

Thanks all :-D
Manuel Hiebel 2012-10-20 22:05:26 CEST

Assignee: boklm => bugsquad

Comment 3 Thierry Vignaud 2012-10-24 01:21:47 CEST
Care to propose a patch?

CC: (none) => thierry.vignaud

Comment 4 claire robinson 2012-11-30 17:24:48 CET
[16:19] <DimStar> Hi all.. I see you have a 'bug' reported on gi-find-deps (https://bugs.mageia.org/show_bug.cgi?id=4825). I suggest you resync this script with the openSUSE package (where the script originated anyway)
[16:19] <[mbot> [ Bug 4825 gi-find-deps.sh doesn't handle scripts without .py ]
[16:20] <DimStar> current / latest variant can be found at https://build.opensuse.org/package/show?package=gobject-introspection&project=GNOME%3AFactory
[16:20] <DimStar> that specific bug has been addressed (accerciser was the test case)
[16:21] <MrsB> DimStar: would you mind adding your comments to the bug please
[16:22] <MrsB> hi btw
[16:22] <DimStar> MrsB: yes :) I'd have to make a user... not really being a Mageia user, that does not make too much sense (I'm the 'author' of the gi-find-deps.sh script over at openSUSE...)
[16:23] <MrsB> That's ok, i can do it if you're happy for me to paste them there :)
[16:23] <DimStar> sure..
roelof Wobben 2013-01-01 11:37:00 CET

Keywords: NEEDINFO => PATCH
URL: (none) => https://build.opensuse.org/package/view_file?expand=1&file=gi-find-deps.sh&package=gobject-introspection&project=GNOME%3AFactory
CC: (none) => r.wobben

Comment 5 Colin Guthrie 2013-01-22 15:17:39 CET
Created attachment 3422 [details]
Patch with syncs with OpenSuse (adding file based probing for python files)

Speaking with DimStar on IRC for other reasons, he mentioned this bug.

I've taken his latest file and sync'ed it with ours.

I've taken care to include the changes introduced by Funda in r7159 in bug #8757 and also fed that fix back to DimStar so he can fix his package.

I've NOT integrated the changed typelib dep finding as it requires a patch to gobject-instrospection pkg to include the dep extraction tool.

Can someone more versed in this stuff please review and apply the patch if appropriate?

Many thanks.
Comment 6 Colin Guthrie 2013-01-22 15:18:19 CET
Adding Funda to CC as he was last to change the gobject stuff a couple days ago. He's likely clued up more than me on it.

CC: (none) => fundawang, mageia

Comment 7 Colin Guthrie 2013-01-22 15:18:56 CET
Oh upstream stuff is here:
https://build.opensuse.org/package/show?package=gobject-introspection&project=GNOME%3AFactory
Comment 8 Colin Guthrie 2013-01-22 16:07:29 CET
For what it's worth, the typelib dep extraction tool is proposed for upstream cleaning which would mean we would need to carry less ad-hoc binary tools in our code if we could use it directly:

https://bugzilla.gnome.org/show_bug.cgi?id=665672

Not relevant for my above patch, but relevant over all.
Comment 9 Samuel Verschelde 2013-08-26 15:52:10 CEST
rpm-mageia-setup has been synced with SUSE by Jani Välimaa on 2013-07-31 so maybe this problem has been solved now. Anssi, Colin, can you confirm?

Source RPM: rpm-mageia-setup-build => rpm-mageia-setup

Comment 10 Christiaan Welvaart 2014-11-25 19:35:35 CET
I fixed a bug related to this report in cauldron with rpm-mageia-setup 2.6-4.mga5 (for virt-manager). That problem was in gobjectintrospection.attr, not gi-find-deps.sh . Since it works now can we close this bug?

CC: (none) => cjw

Comment 11 Thierry Vignaud 2014-11-25 20:51:53 CET
as you which my lord

Status: NEW => RESOLVED
Resolution: (none) => FIXED