Bug 4508

Summary:	Gnucash financial quotes (currency exchange) broken again.
Product:	Mageia	Reporter:	Edward d'Auvergne <true.bugman>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	davidwhodgins, jquelin, sysadmin-bugs, tmb
Version:	1	Keywords:	Triaged, validated_update
Target Milestone:	---
Hardware:	x86_64
OS:	Linux
URL:	https://rt.cpan.org/Public/Bug/Display.html?id=74660
Whiteboard:
Source RPM:	perl-Finance-Quote-1.170.0-1.mga1.noarch.rpm	CVE:
Status comment:

Description Edward d'Auvergne 2012-02-13 14:45:14 CET

Description of problem:

Yahoo have changed their finance page again!  So this breaks perl-Finance-Quote and hence the part of Gnacash that relies on it.  There is a very simple patch attached to https://rt.cpan.org/Public/Bug/Display.html?id=74660 against the 1.17 version which should fix this (according to the report).  This has also been reported on the development mailing list at http://sourceforge.net/mailarchive/forum.php?thread_name=BD4DB5ADC9269C784E2EB7E6%40bayswater.msalexander.com&forum_name=finance-quote-devel.


Version-Release number of selected component (if applicable):

1.17


How reproducible:

100%


Steps to Reproduce:
1.  Install Gnucash and perl-Finance-Quote.
2.  Open Gnucash.
3.  Click on 'Tools->Price Editor'.
4.  Click on 'Get Quotes' (this may require some accounts in different currencies).
5.  See the error message "Unable to retrieve quotes for these items: ...".

Comment 1 Edward d'Auvergne 2012-02-13 14:47:32 CET

The script:

     #!/usr/bin/perl -w
     use strict;
     use Finance::Quote;

     my $quoter = Finance::Quote->new();
     my $exchange_rate = $quoter->currency("AUD", "USD");

     print "AUD -> USD = $exchange_rate\n";

taken from the development mailing list message http://sourceforge.net/mailarchive/forum.php?thread_name=BD4DB5ADC9269C784E2EB7E6%40bayswater.msalexander.com&forum_name=finance-quote-devel is quicker and easier for reproducing the problem.

Comment 2 Manuel Hiebel 2012-02-14 00:22:00 CET

Hi, thanks for reporting this bug.
Assigned to the package maintainer.

(Please set the status to 'assigned' if you are working on it)

Keywords: (none) => Triaged
Assignee: bugsquad => jquelin

Comment 3 Jerome Quelin 2012-02-15 09:45:06 CET

upstream patch doesn't apply cleanly on a 1.17 tarball. i'll adapt it so it applies, but it may be a bit longer.

Status: NEW => ASSIGNED

Comment 4 Jerome Quelin 2012-02-15 10:34:08 CET

ok, i recreated the patch: it applies nicely & fix the problem.
however, svn is down currently and i cannot commit + submit. will do that later on.

Comment 5 Jerome Quelin 2012-02-15 11:44:46 CET

fixed in svn, perl-Finance-Quote-1.170.0-1.1.mga1 on its way to mga1 in core/updates_testing

==> qa, please validate & push to mageia 1 updates

note: package is noarch, so no need to test on both x86_64 & i586.

CC: (none) => jquelin
Assignee: jquelin => qa-bugs

Comment 6 Dave Hodgins 2012-02-15 21:25:46 CET

Testing complete.

Before the update ...
$ ./getcurrencyquotes
Use of uninitialized value $exchange_rate in concatenation (.) or string at ./getcurrencyquotes line 8.
AUD -> USD =

After the update ...
$ ./getcurrencyquotes
AUD -> USD = 1.0691

Could someone from the sysadmin team push the srpm
perl-Finance-Quote-1.170.0-1.1.mga1.src.rpm
freom Core Updates Testing to Core Updates.

Advisory: This bug fix update for perl-Finance-Quote allows gnucash
to retrieve currency quotes from the new version of Yahoo's finance
page.

https://bugs.mageia.org/show_bug.cgi?id=4508

Keywords: (none) => validated_update
CC: (none) => davidwhodgins, sysadmin-bugs

Comment 7 Thomas Backlund 2012-02-16 12:12:25 CET

update pushed

Status: ASSIGNED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED

Comment 8 Edward d'Auvergne 2012-02-16 21:22:02 CET

The fix works perfectly in Gnucash!  Thanks for the awesomely quick update.