| Summary: | [debloat] consider moving Suggests: seahorse to task-gnome | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Frederik Himpe <fhimpe> |
| Component: | RPM Packages | Assignee: | Thierry Vignaud <thierry.vignaud> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | release_blocker | CC: | guillomovitch, thierry.vignaud, yochenhsieh |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | gnome-keyring | CVE: | |
| Status comment: | |||
|
Description
Frederik Himpe
2012-01-31 10:00:32 CET
I haven't checked yet, but why would KDE result in gnome-keyring being installed? I don't expect such a dependency. Because Totem's Mozilla plugin is installed by default. In rpmsrate: 5 CAT_VIDEO CAT_GNOME || CAT_KDE totem-mozilla It was added by goetz 1.5 years ago: "suggest seahorse for key management (bug #60198)" http://svn.mandriva.com/viewvc/packages/cooker/gnome-keyring/current/SPECS/gnome-keyring.spec?r1=556308&r2=556309& https://qa.mandriva.com/show_bug.cgi?id=60198 says "without Seahorse, there's no way to manage your gnome-keyring passwords" Keywords:
(none) =>
Junior_job IMO, totem-mozilla should be removed from CAT_KDE. If you add a GNOME dependency in KDE you'll get a load of GNOME stuff. The installer doesn't use task-gnome (only -minimal), so the suggested change would mean that any default GNOME install wouldn't be able to manage their keyring. Further, I think the suggests is in the right place (gnome-keyring). Putting it in task-gnome-minimal seems wrong. Please file a new bug to remove totem-mozilla from rpmsrate (or reopen this and reassign). I don't think it is up to me to touch that. Keywords:
Junior_job =>
(none) You're playing with words here, task-gnome can be replaced by task-gnome-minimal in this bug description.
It's the job of all of us to reorient the bugs reports to the right place.
Last but not least, I don't care if this suggests is moved to task-gnome or to task-gnome-minimal, it's just bloating the installs
As for "the suggests is in the right place (gnome-keyring)" I don't agree since stuff _LINKED_ with libgnome-keyring ends in installing gnome-keyring too which then got seahorse installed too.
For example the very basesystem was previously:
- systemd & initscripts > lib64glib2.0_0 > glib2.0-common > libgio > libgvfs >
libgnome-keyring > gnome-keyring > seahorse > libgpg > gnugpg >
dirmngr
+ gnome-keyring > libgtk > gtk+ > colord > libcolord
+ libgvfs > libavahi > avahi
+ libgio > libfam > libgamin > gamin
+ libgio > libfuse > fuse
+seahore > libldap > openldap
The BASESYSTEM, aka the MINIMAL INSTALL!!!!!
I've fixed that by breaking one of the suggests so it's better.
But still: now, any app using gvfs (thus any gtk+ app) will:
- <foobar> requires libgvfs
- libgvfs requires gvfs
- gvfs suggests gvfs-smb
- gvfs-smb requires libgnome-keyring.so.0
- libgnome-keyring requires gnome-keyring
- gnome-keyring requires seahorse
And then we go back to the above cycle:
gnome-keyring > seahorse > libgpg > gnugpg > dirmngr
> libgtk > gtk+ > colord > libcolord
+ libgvfs > libavahi > avahi
+ libgio > libfam > libgamin > gamin
+ libgio > libfuse > fuse
+seahore > libldap > openldap
Due to that single suggests, we got seahorse, openldap, avahi, gamin, fuse gnupg, dirmngr.
I don't think one just installing say minimal X11 + only xmms or rhythmbox expects to end having openldap, avahi, ...
We should thus:
1) move the suggest on seahorse higher in the stack, in task-gnome-minimal
2) replace the requires in libgnome-keyring on gnome-keyring by a suggestsPriority:
Normal =>
release_blocker (In reply to comment #5) > You're playing with words here, task-gnome can be replaced by I've removed myself as gnome-keyring maintainer. Reassigning to you. Status:
REOPENED =>
ASSIGNED Will moving this suggest cause any other problem or regression? If one want to install a minimal system, he/she will have to install seahorse manually. That should not be a problem. CC:
(none) =>
yochenhsieh The issue was discussed on -dev mailing list, and the final decision was to just change the rpmsrate content to avoid bloating kde installation with gnome content. Status:
ASSIGNED =>
RESOLVED |