Bug 4349

Hi, thanks for reporting this bug.
Assigned to the package maintainer.

bad that they don't have an svn or git repo ...

(Please set the status to 'assigned' if you are working on it)

Keywords: (none) => Triaged
Assignee: bugsquad => thierry.vignaud

Better having a checkbox for preventing it to popup again

Summary: Drop the "make a backup first" dialog box in diskdrake => [diskdrake] add a checkbox to the "make a backup first" dialog box
Keywords: (none) => USABILITY
Priority: Normal => Low

(In reply to comment #1)
> bad that they don't have an svn or git repo ...

also bad: I looked at their diff regarding the version they synced up;
like some people @mdv, they do not credit their changes, whom 90% were backports from our changes in later drakxtools (which we wrote when working @mdv)

Created attachment 1690 [details]
PCLOS diff to remove dialog

If it's any help this AFAICT is the patch that made the change in PCLOS.

Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Yes - still valid.

Ping ping ;)

Whiteboard: (none) => MGA2TOO

I tested the PCLOS change mentioned in #4 in mga3 drakxtools and it removes the dialog.
I really don't see the need for a checkbox.
Can we implement this as it is in Cauldron and review it if there are complaints?

Created attachment 2658 [details]
drakxtools-14.33-pcl-remove_diskdrake_warning-hd_gtk.pm.patch

Created attachment 2659 [details]
spec diff

Probably not the way to do it having read the NO PATCHES warning, but it worked for testing ;)

(In reply to comment #2)
> Better having a checkbox for preventing it to popup again

I agree.

Cauldron users are very different from average users, they know a lot more about Mageia and what is good or wrong to do. And they are more likely to have back ups.

Please don't remove the warning.

PCLOS removed the warning in the 2010 release and I (or rather Google) can find no mention of any problems. 

You cannot use mcc without a root password, so you should have a clue what you are doing.

gparted does not have a warning dialog before it launches.

Don't forget that you are only *launching* the application at this point, not actually doing anything with it. 
Most dangerous operations have their own confirmation boxes before actually making changes.

I could reluctantly live with a checkbox, but will it ever be implemented?

I still favour immediate complete removal - when it's gone I'm sure no one will miss it.

I am the cautious types that would like it to ask with a dialog like that before changing any system drive.

That said i do not want it to be in the way when i just want to format a stick, backup drive or other external thing.

And when i intend to format a stick it should not let me by accident damage something the system use.


So: i wish it to 
 not pup up initially,
 not when manipulating removeables,
 not when just wanting to wiew how anythingis configured

-BUT-

It SHOULD pop up for the first action on anything used by the system.
(= is in fstab, LVM, LUKS, RAID)

CC: (none) => fri

(In reply to Barry Jackson from comment #11)
> Don't forget that you are only *launching* the application at this point,
> not actually doing anything with it. 
> Most dangerous operations have their own confirmation boxes before actually
> making changes.
> 

Actually some irreversible operations made by diskdrake have no confirmation dialogs, or some actions can't be canceled once initiated (e.g. if you click "Create" to create a partition, there is no "Cancel" button, even though you haven't done anything yet, so you're forced to create a partition).

So a warning is needed for users who don't know diskdrake, so that they know it's not just a tool to inspect what is the content of their filesystem. A checkbox to remove the warning would be nice.

CC: (none) => remi

Destructible options should have such a dialog box, the same way as e.g. gparted or gnome-disks handles it. E.g. for formatting something (should not matter if it's removeable or not) or repartitioning a disk it should show up.

CC: (none) => doktor5000

(In reply to Florian Hubold from comment #14)
> Destructible options should have such a dialog box, the same way as e.g.
> gparted or gnome-disks handles it. E.g. for formatting something (should not
> matter if it's removeable or not) or repartitioning a disk it should show up.

Exactly, but not to initially launch the application GUI.

Pinging Suggest

To get ride the message popup i suggest:

If standart user starts the drakdisks (diskdrake), not enable the erase, expert, unmount, format for every device contained in fstab, and enable the format and unmount for removable media
If root user, enable all options

CC: (none) => neoser10

1) I do not see the need for disabling expert.  I.e expert includes setting partition label, which is very useful for external media.

2) i do think a popup warning is due at least on the first action on anything that is used by the system, or the change user tries affects fstab / LVM / LUKS / RAID.  (including changing label on a mounted unit as label may be used for mounting)

Whiteboard: MGA2TOO => MGA6TOO

 Wishing this bug ...

 ##### Happy 10th Birthday! #####

Hurray, Hurray, Hurray! ;)

Did you not this bug in your calendar??

I understand we need to protect users from shooting themselves in the foot with this GUI, but that there should also be possible to do things on external media while protecting users from formatting wrong drive or accidentally updating fstab to include it, which breaks future boots.

We now have isodumper which in part does this, it can i.e format external USB, but it is less known to users, so would be good to have linked from panel in MCC.
I would also like the upgraded interface 
Bug 27744 - Current isodumper gui could use some improvements

I now issued:
Bug 29966 - Add isodumper to Mageia Control Center

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=29966
Whiteboard: MGA6TOO => MGA8TOO

I think that Thierry's suggestion in comment 2 was perfectly adequate.

@Morgan no it was not in my calendar, but I noticed it a week ago and thought it was fitting to commemorate the occasion!

Yep checkbox sounds fine to me.