| Summary: | fwbackups fails to backup trying to open file/folder <fdopen> | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Paul Thompson <paul.d.thompson.jr> |
| Component: | RPM Packages | Assignee: | QA Team <qa-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | davidwhodgins, doktor5000, sysadmin-bugs, tmb |
| Version: | 1 | Keywords: | PATCH, Triaged, validated_update |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://forums.mageia.org/en/viewtopic.php?f=11&t=1555 | ||
| Whiteboard: | |||
| Source RPM: | fwbackups | CVE: | |
| Status comment: | |||
| Attachments: | backup.py ... FIXED | ||
Hi, thanks for reporting this bug. Assigned to the package maintainer. Keywords:
(none) =>
PATCH, Triaged Just adding the URL to the forum report for reference, and here's the relevant redhat bugreport https://bugzilla.redhat.com/show_bug.cgi?id=725933 and the patch: http://pkgs.fedoraproject.org/gitweb/?p=fwbackups.git;a=blob;f=fwbackups-1.43.4-fdopen.patch Status:
NEW =>
ASSIGNED There is now fwbackups-1.43.4-2.1.mga1 in core/updates_testing to validate ------------------------------------------------------- Suggested advisory: ------------------- This update addresses the following issue: It was reported [1] that fwbackups would fail due to trying to backup files or folders referred to as "<fdopen>" (which is actually a C function) and failed to do a backup because of this. This issue has been fixed. [1] https://forums.mageia.org/en/viewtopic.php?f=11&t=1555 ------------------------------------------------------- Steps to reproduce: - install/update to update candidate - try to to a backup Assignee:
doktor5000 =>
qa-bugs
Florian Hubold
2011-12-15 10:56:44 CET
Summary:
fwbackups basic bug in backup.py AND SOLUTION =>
fwbackups fails to backup trying to open file/folder <fdopen> I've not been able to reproduce this bug. I tried with manual backup to a local tar.gz and a couple of auto backups, one from a user directory and one of /var/www both to a remote ssh tar.gz. Are there any specific circumstances where this happens? I notice strange permissions on the manually backup $ ll *.gz -rwx--x--x 1 claire claire 884648 Dec 16 11:49 Backup-OneTime-2011-12-16_11-49.tar.gz* The auto backups are: $ ls -l *.gz -rw-r--r-- 1 claire claire 5613289 2011-12-16 11:58 Backup-fwbackupstest-2011-12-16_12-00.tar.gz -rw-r--r-- 1 claire claire 1204958 2011-12-16 12:03 Backup-fwbackupstest2-2011-12-16_12-05.tar.gz I've not updated to the new version yet. (In reply to comment #0) > > there is a bug that produces ...<fdopen>" failed: No such file or directory For reference, what did you backup so you hit this bug? Paul, could you report what conditions caused this to fail please? As part of our QA process we attempt to recreate the failure and prove that the new package corrects it. So far I've been unable to make it fail :\ Failing that, could you please test that the updated package in core/updates_testing corrects the issue you are having and let us know which architecture you are using (i586 or x86_64) Thanks. Testing complete on i586 for the srpm fwbackups-1.43.4-2.1.mga1.src.rpm On mageia 1, if you select the simple option to include disk information when creating a backup set, then when you run the backup, the backup completes, but does not include the disk information file, and shows a status of error. With the update installed, the disk information (output of fdisk -l) is included in the backup. Note that the option is only available if fwbackups is run as root. Method to activate the bug found bug looking at the patch, and the source. CC:
(none) =>
davidwhodgins Well done Dave!
Using Dave's method
Before
------
Dec 21 11:26:10 :: WARNING : There was an error while performing the backup!
Dec 21 11:26:10 :: ERROR : Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/fwbackups/__init__.py", line 135, in run
retval = self.__functorun(*self.__args)
File "/usr/lib/python2.7/site-packages/fwbackups/operations/backup.py", line 498, in start
self.deleteListFiles(pkgListfiles)
File "/usr/lib/python2.7/site-packages/fwbackups/operations/backup.py", line 180, in deleteListFiles
os.remove(file)
OSError: [Errno 2] No such file or directory: '<fdopen>'
Dec 21 11:26:10 :: INFO : Canceling the current operation!
Spelling mistake in this last INFO line, should be two L's in cancelling.
Backup contains rpm package list but no disk information.
After
-----
Dec 21 11:31:21 :: INFO : Starting one-time backup operation
Dec 21 11:31:24 :: INFO : Finished one-time backup
Backup contains Disk information and rpm package list as .txt files.
Update validated.
advisory:
-------------------
This update addresses the following issue:
It was reported [1] that fwbackups would fail due to trying to backup files or
folders referred to as "<fdopen>" (which is actually a C function) and failed
to do a backup because of this. This issue has been fixed.
[1] https://forums.mageia.org/en/viewtopic.php?f=11&t=1555
-------------------------------------------------------
SRPM: fwbackups-1.43.4-2.1.mga1.src.rpm
Could sysadmin please push from core/updates_testing to core/updates
Thankyou!Keywords:
(none) =>
validated_update Update pushed. Status:
ASSIGNED =>
RESOLVED |
Created attachment 1222 [details] backup.py ... FIXED there is a bug that produces ...<fdopen>" failed: No such file or directory this can be solved by opening backup.py and replacing on or near line 121 which should have "return fh.name" with "return path" This solution was achieved by following doktor5000 suggestion. BTW: This package was installed from the MAGeia 1 distro.