Bug 3437

Summary:	[Patch] lxpanel- Use notify-send instead of xmessage
Product:	Mageia	Reporter:	Derek Jennings <derekjenn>
Component:	RPM Packages	Assignee:	Oliver Burger <oliver.bgr>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	Normal	CC:	oliver.bgr
Version:	Cauldron	Keywords:	PATCH, Triaged
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	lxpanel-0.5.8	CVE:
Status comment:

Description Derek Jennings 2011-11-24 18:49:52 CET

Description of problem:
While testing an updated lxpanel for bug 3143 I noticed that Low Battery alerts were sent by lxpanel battery monitor using xmessage.
(xmessage is not a dependency of lxpanel so it has to installed separately)

The notifications produced by xmessage are very ugly and are not consistent with standard system messages in Mageia which use notification-daemon.

This patch will set lxpanel battery monitor to use notify-send for low battery messages which go to notification-daemon for a consistent Mageia look and feel.
The spec file will need a 'Requires:  libnotify'

--- lxpanel-0.5.8.orig/src/plugins/batt/batt.c	2011-07-29 13:37:01.000000000 +0100
+++ lxpanel-0.5.8/src/plugins/batt/batt.c	2011-11-24 17:46:47.000000000 +0000
@@ -435,7 +435,7 @@
 
     /* Apply more default options */
     if (! lx_b->alarmCommand)
-        lx_b->alarmCommand = g_strdup("xmessage Battery low");
+        lx_b->alarmCommand = g_strdup("notify-send 'Battery low'");
     if (! lx_b->backgroundColor)
         lx_b->backgroundColor = g_strdup("black");
     if (! lx_b->chargingColor1)

Comment 1 Manuel Hiebel 2011-11-24 22:56:20 CET

Hi, thanks for reporting this bug.
Assigned to the package maintainer.

Keywords: (none) => PATCH, Triaged
Assignee: bugsquad => oliver.bgr

Comment 2 Oliver Burger 2011-11-24 23:00:25 CET

Thanks for the report and for the patch, I will push an update.

Oliver

Oliver Burger 2011-11-24 23:01:54 CET

Status: NEW => ASSIGNED

Comment 3 Oliver Burger 2011-11-25 15:56:00 CET

I just pushed an update for lxpanel including your libnotify patch.

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

Comment 4 Oliver Burger 2011-11-27 22:22:55 CET

Sorry, I again did the same thing with the bug.

Reopened and assigned to qa.

Please test.

Oliver

Status: RESOLVED => REOPENED
CC: (none) => oliver.bgr
Resolution: FIXED => (none)
Assignee: oliver.bgr => qa-bugs

Comment 5 Oliver Burger 2011-11-27 22:24:27 CET

Arghs, this was a Cauldron bug no Mga1.

Sorry for the fuzz, rsolved fixed and reassigned to me :/

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED
Assignee: qa-bugs => oliver.bgr