Bug 32817

Hi Fabrice,

Yes it is acceptable and I don't see something wrong, this looks good.

CC: (none) => geiger.david68210

"Human theme
This theme works with: GTK 2.24 (with murrine), GTK 3.24, and GTK 4.12.
It is mainly intended for Mate and Xfce desktop environments.
 Before start
To meet the truth (this is not required):
remove gtk3-nocsd
install gtk3-classic
use Pango 1.42- or 1.51+"

Citing explicit versions of dependencies is generally not a good idea; better "at least, >=..."

(In reply to Fabrice Creuzot from comment #0)
> I made a SPEC to submit a new package into Mageia 8, 9 & Cauldron.
> It's a very simple package.
> https://build.opensuse.org/package/view_file/home:luigifab/mageia-test/human-
> theme-gtk.spec
Can you say something about what it is (we can guess: another theme!) - but what benefit, how does it differ, why is it better?

> I'd like to push it into Mageia and become its maintainer.
(In reply to David GEIGER from comment #1)
> Yes it is acceptable and I don't see something wrong, this looks good.
This is one of the best requests for a new package we have had: the offer to maintain it.
DavidG's stamp of approval is important - thank you for that. Assigning to you rather than all packagers, as you have already looked at it. You can discuss directly to Fabrice on the bug.

Summary: Review request for human-theme-gtk => human-theme-gtk: NEW PKG REQUEST
Severity: normal => enhancement
Assignee: bugsquad => geiger.david68210

For explicit versions in the readme:

- GTK 2.24 & 3.24 are the latest versions (2.24.x - 3.24.x)

- GTK 4.12... for me like 4.0 and up to 4.20, these are alpha or beta versions, the theme works with 4.0 to 4.11 but for example: in 4.0 there is a 1px offset for the menubar, in 4.2 there is a 1px offset for the entry but not for the menubar, in 4.4 there is a 1px offset for the menubar and for radio/check buttons, in 4.6 there is a problem with line height with some widgets, but not in 4.10... ; in v2.2.0 I've removed all these "hacks".

- Pango 1.42- (< 1.43) and 1.51+ (>= 1.51): see images (except icons): https://github.com/luigifab/human-theme/issues/4#issuecomment-617922464

Some of these "bugs" can be fixed by updating some CSS/XML lines.
For a while, I made a trigger: https://github.com/luigifab/human-theme/blob/549779dc6ffc9f781a2947345d919b5e756acf5a/opensuse/human-theme-gtk.spec#L59
But it hasn't passed openSUSE's quality check, and because it uses 1.51, I removed it (in all packages).

With Pango 1.51 there is almost same rendering as Pango 1.42.

I checked Mageia package DB, and sadly (for me), you are using Pango 1.48 in 8, and 1.50 in 9 and cauldron. So it's better for me to propose the package for 9 and cauldron only.

Remaining rendering problems in 1.50 can't be fixed by CSS/XML, but it's usable if I remember correctly.

---

For gtk3-classic (https://github.com/lah7/gtk3-classic), it's no required, but without, mainly, you won't have alternating row colours for treeview (https://github.com/lah7/gtk3-classic/wiki/Treeview:-Alternating-Colours-CSS).

I also restored dual text color for progress bars (https://github.com/luigifab/human-theme/issues/8#issuecomment-1773768753). But my patch is incomplete, so it is available only with my build of gtk3 (https://gist.github.com/luigifab/0fce786cdb93b5687069a82f490ea95e#file-gtk-3-24-40-deb-sh).

I already tried to create RPM packages for Fedora/openSUSE, but I don't really use these distros, so I removed it (https://gist.github.com/luigifab/0fce786cdb93b5687069a82f490ea95e/6029cd0d7f058fda236ab4b1307fbfb8b2f914cf#file-gtk3_rpm_3-24-23-sh).

---

Yes it's another theme, but NOT a flat theme, with same rendering between GTK 2, 3, and 4.

Created attachment 14357 [details]
theme preview

Theme preview with Mageia 9 Xfce.

With rpmlint I get:

human-theme-gtk.src: W: no-%build-section => yes normal
human-theme-gtk.noarch: W: no-packager-tag => normal?
human-theme-gtk.noarch: W: invalid-license CC-BY-SA
human-theme-gtk.noarch: W: incoherent-version-in-changelog 2.2.0-1 2.2.0-1.mga9

For version, should I use?
- 2.2.0-1.mga8
- 2.2.0-1.mga9 for 9 and cauldron

Mageia 8 is EOL since Nov 2023. No packages get pushed anymore to Mageia 8.

Oh, sorry, yes, I forgot that we are already in 2024.