Bug 32689

Summary:	Please add a dracut-mageia specific repository in our git system
Product:	Infrastructure	Reporter:	Jybz <j.biernacki+mga>
Component:	Others	Assignee:	Sysadmin Team <sysadmin-bugs>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	Normal	CC:	dan, mageia, mageia, sysadmin-bugs, thierry.vignaud
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:		CVE:
Status comment:
Attachments:	local git folder of SVN extraction

Description Jybz 2024-01-05 10:56:07 CET

Currently dracut take sources from upstream.
http://svnweb.mageia.org/packages/updates/9/dracut/current/SPECS/dracut.spec?view=markup#l20

Then, it applies mageia specific patches:
http://svnweb.mageia.org/packages/updates/9/dracut/current/SOURCES/0512-mgainstaller-Add-a-module-used-to-generate-the-Magei.patch?view=markup
and patches over patches:
http://svnweb.mageia.org/packages/updates/9/dracut/current/SOURCES/0514-mgainstaller-fix-network-interface-renaming-mga-1765.patch?view=markup
and
http://svnweb.mageia.org/packages/updates/9/dracut/current/SOURCES/0519-mgainstaller-add-wpa_supplicant-to-support-WPA-WPA2-.patch?view=markup

now working on arm architecture, it became harder to provide a patch over a patch over a patch over a patch, mostly for files regarding exclusively mageia and not the upstream project dracut.

Please, add a git repository for specific dracut-mageia files.

Comment 1 Dan Fandrich 2024-01-05 11:03:54 CET

How many of the patches could be upstreamed?

CC: (none) => dan

Comment 2 Jybz 2024-01-05 11:14:15 CET

For Mageia specific files, I would say none. It regards mageia/drakx, nothing regarding dracut.
Look at the whole file name:
> modules.d/90mgainstaller/mgainstaller-mount-stage2.sh
> modules.d/90mgainstaller/module-setup.sh
> modules.d/90mgainstaller/parse-mgainstaller.sh
> modules.d/90mgakadeploy/module-setup.sh (http://svnweb.mageia.org/packages/updates/9/dracut/current/SOURCES/0513-kadeploy-Add-a-kd-deploy-module.patch?view=markup)
> modules.d/90mgalive/mgalive-genrules.sh (http://svnweb.mageia.org/packages/updates/9/dracut/current/SOURCES/0511-mgalive-A-module-to-mount-Mageia-Live-media.patch?view=markup)

we might also include this one in the git:
http://svnweb.mageia.org/packages/updates/9/dracut/current/SOURCES/50-mageia.conf?view=markup

Jybz 2024-01-05 14:05:59 CET

CC: (none) => mageia, thierry.vignaud

Comment 3 Martin Whitaker 2024-01-05 19:51:19 CET

I really don't understand why the Mageia dracut modules are applied as patches instead of as additional sources.

Comment 4 Jybz 2024-01-05 22:37:07 CET

Because we do not have a repository for them?
(I know, it could be a file inside src, but they are patches...)

Comment 5 Nicolas Lécureuil 2024-01-05 23:38:39 CET

(In reply to Martin Whitaker from comment #3)
> I really don't understand why the Mageia dracut modules are applied as
> patches instead of as additional sources.

yes would be simpler to use patches when needed but additionnal sources for our own files.

http://svnweb.mageia.org/packages/updates/9/dracut/current/SOURCES/0512-mgainstaller-Add-a-module-used-to-generate-the-Magei.patch?view=markup

for exemple, can be changed into a patch and 3 new sources.


Simpler/cleaner

CC: (none) => mageia

Comment 6 Jybz 2024-04-20 23:46:43 CEST

Created attachment 14504 [details]
local git folder of SVN extraction

I played a lot with git apply, git am, and modifying files directy as sometime the patch was not able to by apply.

Please consider to create a git repo with our specific files.

If someone dislike the job, please do it on your way.

If no repository is created, I will fill a bug report asking to apply a patch on a patch in order to fix a bug tomorrow evening.