Bug 31533

Summary: Tigervnc 1.13 final has been released.
Product: Mageia Reporter: Alan Richter <arichter>
Component: RPM PackagesAssignee: Nicolas Salguero <nicolas.salguero>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: Normal    
Version: Cauldron   
Target Milestone: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/TigerVNC/tigervnc/releases
Whiteboard:
Source RPM: tigervnc-1.12.0-4.mga9.src.rpm CVE:
Status comment:

Description Alan Richter 2023-02-09 22:57:56 CET
Description of problem:
Tigervnc 1.13 final has been released. 

Version-Release number of selected component (if applicable):
Cauldron is currently at 1.12 and should be revved to 1.13

How reproducible:
This isn't a bug but keeping up to date is always nice.  

I've tested 1.13 on MGA8 and MGA9 and have not found any issues although I have not tried the Java components. 

Here are the changes I made for mga9:

--- rpmbuild.old/SOURCES/tigervnc-xserver211.patch      2022-05-12 05:06:37.000000000 -0600
+++ rpmbuild.new/SOURCES/tigervnc-xserver211.patch      2023-02-09 13:28:13.000000000 -0700
@@ -88,51 +88,3 @@
  extern _X_EXPORT void
  LogVWrite(int verb, const char *f, va_list args)
  _X_ATTRIBUTE_PRINTF(2, 0);
---- xserver/hw/vnc/xorg-version.h      2021-11-09 08:51:28.000000000 +0100
-+++ xserver/hw/vnc/xorg-version.h.new  2022-05-09 15:43:08.449940297 +0200
-@@ -33,8 +33,8 @@
- #error "X.Org older than 1.16 is not supported"
- #endif
- 
--#if XORG_AT_LEAST(1, 21, 0)
--#error "X.Org newer than 1.20 is not supported"
-+#if XORG_AT_LEAST(22, 0, 0)
-+#error "X.Org newer than 21.1 is not supported"
- #endif
- 
- #endif
---- xserver/hw/vnc/xvnc.c      2021-11-09 08:51:28.000000000 +0100
-+++ xserver/hw/vnc/xvnc.c.new  2022-05-09 15:43:24.315020280 +0200
-@@ -69,7 +69,31 @@ extern char buildtime[];
- #undef VENDOR_RELEASE
- #undef VENDOR_STRING
- #include "version-config.h"
--#include "site.h"
-+
-+/* Default logging parameters. */
-+#ifndef DEFAULT_LOG_VERBOSITY
-+#define DEFAULT_LOG_VERBOSITY         0
-+#endif
-+#ifndef DEFAULT_LOG_FILE_VERBOSITY
-+#define DEFAULT_LOG_FILE_VERBOSITY    3
-+#endif
-+
-+/*
-+ * The vendor string identifies the vendor responsible for the
-+ * server executable.
-+ */
-+#ifndef VENDOR_STRING
-+#define VENDOR_STRING "The X.Org Foundation"
-+#endif
-+
-+/*
-+ * The vendor release number identifies, for the purpose of submitting
-+ * traceable bug reports, the release number of software produced
-+ * by the vendor.
-+ */
-+#ifndef VENDOR_RELEASE
-+#define VENDOR_RELEASE        6600
-+#endif
- 
- #define XVNCVERSION "TigerVNC 1.12.0"
- #define XVNCCOPYRIGHT ("Copyright (C) 1999-2021 TigerVNC Team and many others (see README.rst)\n" \
diff -Naur rpmbuild.old/SPECS/tigervnc.spec rpmbuild.new/SPECS/tigervnc.spec
--- rpmbuild.old/SPECS/tigervnc.spec    2023-02-09 07:42:11.000000000 -0700
+++ rpmbuild.new/SPECS/tigervnc.spec    2023-02-09 14:48:46.000000000 -0700
@@ -1,6 +1,6 @@
 Name:           tigervnc
-Version:        1.12.0
-Release:        %mkrel 4
+Version:        1.13.0
+Release:        %mkrel 1
 Summary:       Viewer for the VNC remote display system
 Group:         Networking/Remote access
 License:        GPLv2+
@@ -236,6 +236,7 @@
 
 %files server
 %doc HOWTO.md
+%{_datadir}/metainfo/org.tigervnc.vncviewer.metainfo.xml
 %config(noreplace) %{_sysconfdir}/pam.d/tigervnc
 %config(noreplace) %{_sysconfdir}/tigervnc/vncserver-config-defaults
 %config(noreplace) %{_sysconfdir}/tigervnc/vncserver-config-mandatory


Steps to Reproduce:
1.
2.
3.
Comment 1 Lewis Smith 2023-02-10 21:04:32 CET
Thank you Alan for the notification and the precise changes you have researched. Can you say briefly why they were necessary? And for Mageia 8?

BTAIM assigning this to NicolasS who put up v1.12 is has maintained that since.

Assignee: bugsquad => nicolas.salguero

Comment 2 Alan Richter 2023-02-10 21:51:36 CET
The changes necessary to build 1.13 vs 1.12 is to add a single file to %files, specifically: %{_datadir}/metainfo/org.tigervnc.vncviewer.metainfo.xml, and to remove some of the changes that were necessary for 1.12 to build with Xorg 1.21.

1.13 builds and runs fine on MGA8 using the addition of the metainfo.xml file to the 1.11 tigervnc.spec file.
Comment 3 Nicolas Salguero 2023-03-06 15:58:31 CET
Hi,

tigervnc-1.13.0-1.mga9 was made by daviddavid.

Best regards,

Nico.

Resolution: (none) => FIXED
Status: NEW => RESOLVED