Bug 31293

Summary:	Mageia patch leads to annoying pop-up for XFCE when kdialog is installed
Product:	Mageia	Reporter:	christian barranco <chb0>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	davidwhodgins, fri, herman.viaene, sysadmin-bugs
Version:	8	Keywords:	advisory, validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	xdg-utils-1.1.3-5.mga8.src.rpm	CVE:
Status comment:
Attachments:	Patch to restore behavior for url_scheme_handler_xfce functions

Description christian barranco 2022-12-17 21:47:05 CET

Description of problem:
pop-up windows stating "xdg-settings: default-url-scheme-handler not implemented for xfce" when some applications try to run 'xdg-settings get default-url-scheme-handler https' and kdialog is installed

Version-Release number of selected component (if applicable):


How reproducible: always


Steps to Reproduce:
1. Install MGA8 XFCE
2. Install kdialog package (which can be the case already when kde and xfce desktops are installed on the same machine)
3. Run in a terminal: xdg-settings get default-url-scheme-handler https
4. A pop-up window will open stating "xdg-settings: default-url-scheme-handler not implemented for xfce"

Actually, this pop-up will appear when any application (based on electron for instance) will test default-url-scheme-handler at start-up.
The thing is it is not a hard error as url-scheme-handler is not implemented for XFCE. But the user will have to click on Ok on the pop-up to continue.

As a matter of fact (or of code), xdg-settings functions handling url-scheme-handler for XFCE like get_url_scheme_handler_xfce(), check_url_scheme_handler_xfce() and set_url_scheme_handler_xfce() will always exit with an error.
However, the default behavior of the source code is to echo the error to std err but not to display a pop-up.
This pop-up behavior has been introduced by the Mageia patch called xdg-utils-1.1.1-email_loop.patch

There is no explanation of the purpose of this patch in the patch itself or in the package spec file.

Removing this patch would solve this bug. But what would be the consequence?

Another way to solve this bug is not to call the exit_failure_operation_impossible() function for url_scheme_handler_xfce(), check_url_scheme_handler_xfce() and set_url_scheme_handler_xfce()
To do so, the patch attached can be used.

I have successfully tested this patch but, as I don't know this patch very well and I don't know the purpose of the other MGA patch, I didn't want to push any update before getting a feedback from the community.

Comment 1 christian barranco 2022-12-17 21:49:01 CET

Created attachment 13580 [details]
Patch to restore behavior for url_scheme_handler_xfce functions

Patch mentioned in the initial bug report

christian barranco 2022-12-17 21:50:59 CET

Keywords: (none) => PATCH

Comment 2 Lewis Smith 2022-12-20 20:50:34 CET

Sorry to have left this.
Do you know whether this applies also to Mageria 9? If so, please change the Version to Cauldron, and add MGA8TOO in Whiteboard.

See no particular packager for this, so assigning globally.

Assignee: bugsquad => pkg-bugs

Comment 3 christian barranco 2022-12-20 21:24:12 CET

Hi Lewis

The package to update is xdg-utils
There is no official maintainer for it.

I can take care of it. However, I'd like some feedback from some people who might have worked on this package before, to make sure I don't overlook anything.


I will make a test on MGA9, but I am almost sure the issue will be the same because there is the same patch for MGA9 too.

Comment 4 christian barranco 2022-12-20 21:36:35 CET

I confirm the issue with Cauldron as well

Version: 8 => Cauldron
Whiteboard: (none) => MGA8TOO

Comment 5 christian barranco 2023-01-02 09:19:33 CET

Ni. It looks like there is no objection. So, I will proceed with the update.

Assignee: pkg-bugs => chb0

Comment 6 christian barranco 2023-01-02 16:19:29 CET

Ready for QA.

xdg-utils-1.1.3-5.1.mga8.noarch.rpm

Assignee: chb0 => qa-bugs
Version: Cauldron => 8
Whiteboard: MGA8TOO => (none)

Comment 7 Morgan Leijström 2023-01-02 16:41:21 CET

What exactly triggers the problem before the update?
Does the system need to be xfce only?
I don not see it on my main system, which mainly use Plasma, but also have XFCE and Gnome.

[morgan@svarten ~]$ xdg-settings get default-url-scheme-handler https
firefox.desktop

[morgan@svarten ~]$ sudo rpm -qa | grep xdg-utils
xdg-utils-1.1.3-5.mga8

[morgan@svarten ~]$ sudo rpm -qa | grep task-xfce
task-xfce-minimal-4.14-2.mga8
task-xfce-plugins-4.14-2.mga8
task-xfce-4.14-2.mga8
[morgan@svarten ~]$

CC: (none) => fri

Comment 8 christian barranco 2023-01-02 16:58:47 CET

Hi Morgan.
As explained in Description, the issue has been triggered by an electron application (signal-desktop) testing default-url-scheme-handler at start-up.
To reproduce the issue, you need to be connected under a XFCE session (and have kdialog installed, which should be the case if you have Plasma already installed).

Comment 9 Herman Viaene 2023-01-04 17:02:42 CET

MGA8-64 Xfce on Acer Aspire 5253. This laptop has Xfce and MATE as desktops, but kdialog is already installed.
No installation issues.
Before the update I see the popup as described above, after the update I see at the CLI:
$ xdg-settings get default-url-scheme-handler https
xdg-settings: default-url-scheme-handler not implemented for XFCE
and no popup.
If Morgan agrees, he can OK this update as far as I am concerned.

CC: (none) => herman.viaene

Comment 10 Morgan Leijström 2023-01-04 17:28:36 CET

Thanks Herman

CC: (none) => sysadmin-bugs
Keywords: PATCH => validated_update

Dave Hodgins 2023-01-11 04:57:45 CET

CC: (none) => davidwhodgins
Keywords: (none) => advisory

Comment 11 Mageia Robot 2023-01-13 18:38:27 CET

An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2023-0002.html

Resolution: (none) => FIXED
Status: NEW => RESOLVED