Bug 30880

Also noted in https://bugs.mageia.org/show_bug.cgi?id=30867#c4

IMO it is enough to fix in source, to be included in next build.

Summary: mageia - 1.0 => Firefox about dialogue say "mageia - 1.0"
Severity: enhancement => minor
Assignee: bugsquad => pkg-bugs
CC: (none) => fri

Hi
It is easy to change in the spec file.
What should it be? Was it intended to show the Mageia version (ie 8.0 currently) ?

CC: (none) => chb0

If it can automatically update to show correct version, good.

If it need manual edit for each Mageia release, I think it is better to simply remove that line so we do not forget to update later.

The line displayed above already say it is built for Mageia anyway:

    "Mozilla Firefox for Mageia"

Hi.
I looked at what is set for Manjaro and Linux Mint.
With both their distribution names - 1.0
For instance, Manjaro - 1.0

I don't know the reason but it might be so it is normal to have as well Mageia - 1.0

(In reply to christian barranco from comment #4)
> Hi.
> I looked at what is set for Manjaro and Linux Mint.
> With both their distribution names - 1.0
> For instance, Manjaro - 1.0
> 
> I don't know the reason but it might be so it is normal to have as well
> Mageia - 1.0

So possibly an upstream bug, maybe a wontfix, but still a bug.

Still valid in Bug 31415 - Firefox 102.7

Still valid in 115.3.1

1) It is confusing it say 1.0. If it cant say a correct version (is it supposed to be Mageia relase?), say no version.

2) mageia should be spelled with capital M.

I know, very minor issue, but it look sloppy.

Source RPM: firefox.102.3.0-1.mga8.x86_64 => firefox-115.3.1-1.mga9.src.rpm
Whiteboard: (none) => MGA8TOO
Version: 8 => 9

Still valid 115.5

But I also note same defect is in flatpak of Firefox, 

"mozilla-flatpak 1.0"

I assume the problem is upstream, a defect in how it present itself.

Feel free to close as wontfix // waiting for upstream to fix their stuff.

Whiteboard: MGA8TOO => MGA8TOO, MGA9TOO

(In reply to Morgan Leijström from comment #7)
> Still valid 115.5
> 
> But I also note same defect is in flatpak of Firefox, 
> 
> "mozilla-flatpak 1.0"
> 
> I assume the problem is upstream, a defect in how it present itself.
> 
> Feel free to close as wontfix // waiting for upstream to fix their stuff.

It is not fully upstream. To fix this, it is just required to update our distribution.ini file, used to build Firefox.

A patch is attached.

Created attachment 14195 [details]
distribution.ini patch

To update the distribution version seen on the About pop-up.

CC de facto packager

For future versions - 
No need to hold up the version curently in testing

CC: (none) => nicolas.salguero

Hi,

The following modifications were pushed in the repository:
  - For Mageia 9, 1.0 was replaced by 9.0.
  - For Cauldron, 1.0 was replaced by 10.0.

Best regards,

Nico.

Thank you.

We will validate next build then :)

Isn't better to have it auto-changed as the distro version change, so no one will forget about it?
A simple single "sed" line in firefox spec file should do the trick, something like:

--- firefox.spec 
+++ firefox.spec
@@ -575,6 +575,7 @@
 # Add distribution.ini
 %{__mkdir_p} %{buildroot}%{mozappdir}/distribution
 %{__cp} %{SOURCE26} %{buildroot}%{mozappdir}/distribution
+sed -i 's/version=.*/version=%{distro_release}/g' %{buildroot}%{mozappdir}/distribution
 
 # (lm) touch and %ghost bookmarks.html to a proper uninstall
 touch %{buildroot}%{mozappdir}/browser/defaults/profile/bookmarks.html

Regards.

CC: (none) => arusanu

I committed:
%{__sed} -i 's/^\(version=\).*\(\.0\)$/\1%{distro_release}\2/g' %{buildroot}%{mozappdir}/distribution/distribution.ini

This also affects firefox-beta :
121.0b7 (64 bits)
...
mageia - 1.0

CC: (none) => geex+mageia