Bug 29724

Summary: Igbinary session not supported since upgrade to php 8.1
Product: Mageia Reporter: Raphael Gertz <mageia>
Component: BackportsAssignee: QA Team <qa-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: Normal CC: andrewsfarm, tarazed25
Version: 8Keywords: validated_backport
Target Milestone: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/igbinary/igbinary/issues/349
Whiteboard: MGA8-64-OK
Source RPM: php-igbinary-3.2.6-2.mga8.src.rpm CVE:
Status comment:

Description Raphael Gertz 2021-12-04 00:24:41 CET
Description of problem:
The problem was reported upstream.

Since upgrading to php 8.1 the support of igbinary session is not available.

Thus it's not possible to use it for session support :
PHP Warning:  session_start(): Cannot find session serialization handler &quot;igbinary&quot; - session startup failed in /var/www/[...]/vendor/symfony/http-foundation/Session/Storage/NativeSessionStorage.php on line 149
Uncaught PHP Exception RuntimeException: "Failed to start the session." at /var/www/[...]/vendor/symfony/http-foundation/Session/Storage/NativeSessionStorage.php line 150\n
PHP Warning:  session_start(): Cannot find session serialization handler &quot;igbinary&quot; - session startup failed in /var/www/[...]/vendor/symfony/http-foundation/Session/Storage/NativeSessionStorage.php on line 149

Version-Release number of selected component (if applicable):
php-igbinary-3.2.6-2.mga8

How reproducible:
Always

Steps to Reproduce:
1. Enable backports sources
2. Install php & php-memcached & php-igbinary
3. See errors in log
Comment 1 Raphael Gertz 2021-12-04 00:27:30 CET
Hi,

I disabled session serialize handler in commit 1760651 and submited it to mga8 backports_testing.

$ svn di -r 1760650:1760651
Index: SPECS/php-igbinary.spec
===================================================================
--- SPECS/php-igbinary.spec     (révision 1760650)
+++ SPECS/php-igbinary.spec     (révision 1760651)
@@ -4,7 +4,7 @@

 Name:          php-%{modname}
 Version:       3.2.6
-Release:       %mkrel 2
+Release:       %mkrel 3
 Group:         Development/PHP
 Summary:       PHP igbinary extension
 License:       BSD-3-Clause
@@ -54,7 +54,7 @@
 cat > %{buildroot}%{_sysconfdir}/php.d/%{inifile} << EOF
 extension = %{soname}
 ; Use igbinary as session serializer
-session.serialize_handler=igbinary
+;session.serialize_handler=igbinary
 EOF

 %files

Please replace backport version with this new one until upstream bug is fixed.

Best regards
Comment 2 Lewis Smith 2021-12-05 19:49:08 CET
Thank you for the report, the upstream bug URL, and the work you have done to temporarily fix the problem.
Assigning this to MarcK who deals with 'php-igbinary'.

Assignee: bugsquad => mageia

Comment 3 Marc Krämer 2021-12-05 22:43:15 CET
@Raphael, would you please stop modifying my maintained packages!
If you want to take over, just ask. But STOP modifying packages without asking!
Comment 4 Marc Krämer 2021-12-05 22:53:36 CET
I fully agree your upstream bug report and your changes look ok. I'm greatfull if you want to help with php packages or anything else. But please don't just modify packages you don't own. If we allow this, we don't need ownership of packages.
I'd love to have someone else to care about php and talk/discuss about what we do or maybe change.
Comment 5 Marc Krämer 2021-12-05 22:59:00 CET
btw. it looks like we had already such a patch and I removed it by accident.
Comment 6 Marc Krämer 2021-12-05 23:35:23 CET
Updated php-igbinary package due to a compile error concerning session-support

Update in core/backports_testing:
php-igbinary-debugsource-3.2.6-5.mga8
php-igbinary-3.2.6-5.mga8
php-igbinary-debuginfo-3.2.6-5.mga8

SRPM:
php-igbinary-3.2.6-5.mga8.src.rpm

Component: RPM Packages => Backports
Assignee: mageia => qa-bugs

Comment 7 Raphael Gertz 2021-12-07 05:13:59 CET
Hi,

(In reply to Marc Krämer from comment #3)
> @Raphael, would you please stop modifying my maintained packages!
> If you want to take over, just ask. But STOP modifying packages without
> asking!

Sorry, my health is not enough reliable for me to take care of php packages or other critical stuff seriously.

I just need it to work on my server. And when something is broken I try to fix it as best as possible upstream and in distribution before forgetting.

I just want to avoid broken packages and regression for next distribution release, there is enough pain in the ass when upgrading each time...

You are free to improve or fix it any other way that fit you, sorry I forgot to check if the package was owned.

I though it was more confortable for the packager to just validate the fix and not redo all the investigating and patching.

Best regards
Comment 8 Len Lawrence 2021-12-08 16:29:16 CET
mga8, x64

Updated php-igbinary from backports testing.
$ urpmq --requires-recursive php-igbinary | sort -u
bash
bash-completion
chkconfig
coreutils
cracklib-dicts
....
shadow-utils
sthttpd|lighttpd|nginx|apache
systemd
tcb
util-linux

It would seem unlikely that a random choice from this very long list could be presuaded to show evidence of php-igbinary use.

$ urpmq --requires php-igbinary | sort -u
config(php-igbinary)[== 3.2.1-4.mga8]
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
php[>= 3:8.0.0]
php-common[>= 3:8.0]
php-session[>= 3:8.0.0]

and these are too general to be any use.
Giving this an OK on the basis of a clean install.

Whiteboard: (none) => MGA8-64-OK
CC: (none) => tarazed25

Comment 9 Len Lawrence 2021-12-08 16:30:08 CET
s/presuaded/persuaded/
Comment 10 Thomas Andrews 2021-12-09 19:44:26 CET
Validating.

Raphael, a suggestion for next time: Submit your patch/fix suggestion in an attachment. The maintainer can then look it over, and if approved, can implement it, and no one's toes are stepped on.

Keywords: (none) => validated_backport
CC: (none) => andrewsfarm

Comment 11 Thomas Backlund 2021-12-10 23:29:27 CET
moved

Status: NEW => RESOLVED
Resolution: (none) => FIXED