Bug 2776

Summary: some switches forgotten in the spec file of mythplugin (for cauldron-tainted-release an 1-tainted-update-testing)
Product: Mageia Reporter: Philippe Didier <philippedidier>
Component: RPM PackagesAssignee: Mageia Bug Squad <bugsquad>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: mageia
Version: Cauldron   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: mythplugins-0.24.1-20110909.1 CVE:
Status comment:

Description Philippe Didier 2011-09-19 02:17:34 CEST
Hi Colin !

You seem to have forgotten to modify to lines in the spec file (which don't prevent from build but let missing warning about potential patent infringements...)

line 76   %if %with plf 
line 119  %if %with plf 

ought to be
line 76  %if %{build_tainted} 
line 119 %if %{build_tainted}
Philippe Didier 2011-09-19 02:22:06 CEST

CC: (none) => mageia

Comment 1 Colin Guthrie 2011-09-19 10:13:53 CEST
oops... that'll teach me for trying to do it quickly for the update.

I don't think it's serious enough to bother resubmitting to the the updates tree (feel free to disagree if you really feel differently) so have corrected in svn and will submit a fresh batch of updates whenever there are sufficient upstream changes to justify it. Hope that's OK?

I think the fact that a package is in tainted repository is information enough regarding software patents and any text in the description is merely a courtesy, hence why I don't think it's worth updating things immediately (as the QA process is already mostly complete).

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 2 Philippe Didier 2011-09-19 11:33:16 CEST
No problem indeed ... there's no emergency, that's not really a bug... only a cosmetic correction and doesn't need new submit...

(I'm having a look on packages which may be rebuilt with FAAC since it's in tainted repo ... after some discussions ;-)   and I looked into your spec files for mythtv and mythtvplugin : happy to see you add BR faac-devel and you found a way to clean the spec from old plf references using specific mageia options now )

You corrected in the svn => you closed this report as fixed

Everything OK