Bug 27746

Debian-LTS has issued an advisory on August 10, 2018:
https://www.debian.org/lts/security/2018/dla-1463

I wasn't tracking their advisories at the time, so I missed it.

Fix for the issue Zombie reported is here:
https://github.com/pts/sam2p/commit/8b2b7151991e07ef262857c2325e95c3b2867f80

Whiteboard: (none) => MGA7TOO
Summary: sam2p security vulnerability CVE-2018-12601 => sam2p missing update for security issue CVE-2018-12578 and CVE-2018-12601
Source RPM: sam2p-0.49.3-2.mga7.src => sam2p-0.49.3-2.mga7.src.rpm

Hi, thanks for reporting this bug.
As there is no maintainer for this package I added the committers in CC.

(Please set the status to 'assigned' if you are working on it)

CC: (none) => cjw, jani.valimaa, olav, ouaurelien

Suggested advisory:
========================

The updated package fixes security vulnerabilities:

In sam2p 0.49.3, a heap-based buffer overflow exists in the pcxLoadImage24 function of the file in_pcx.cpp. (CVE-2017-14628)

In sam2p 0.49.3, the in_xpm_reader function in in_xpm.cpp has an integer signedness error, leading to a crash when writing to an out-of-bounds array element. (CVE-2017-14629)

In sam2p 0.49.3, an integer overflow exists in the pcxLoadImage24 function of the file in_pcx.cpp, leading to an invalid write operation. (CVE-2017-14630)

In sam2p 0.49.3, the pcxLoadRaster function in in_pcx.cpp has an integer signedness error leading to a heap-based buffer overflow. (CVE-2017-14631)

Because of an integer overflow in sam2p 0.49.3, a loop executes 0xffffffff times, ending with an invalid read of size 1 in the Image::Indexed::sortPal function in image.cpp. However, this also causes memory corruption because of an attempted write to the invalid d[0xfffffffe] array element. (CVE-2017-14636)

In sam2p 0.49.3, there is an invalid read of size 2 in the parse_rgb function in in_xpm.cpp. However, this can also cause a write to an illegal address. (CVE-2017-14637)

In sam2p 0.49.4, there are integer overflows (with resultant heap-based buffer overflows) in input-bmp.ci in the function ReadImage, because "width * height" multiplications occur unsafely. (CVE-2017-16663)

There is a heap-based buffer overflow in the LoadPCX function of in_pcx.cpp in sam2p 0.49.4. A Crafted input will lead to a denial of service or possibly unspecified other impact. (CVE-2018-7487)

There is an invalid free in MiniPS::delete0 in minips.cpp that leads to a Segmentation fault in sam2p 0.49.4. A crafted input will lead to a denial of service or possibly unspecified other impact. (CVE-2018-7551)

There is a heap-based buffer overflow in the pcxLoadRaster function of in_pcx.cpp in sam2p 0.49.4. A crafted input will lead to a denial of service or possibly unspecified other impact. (CVE-2018-7553)

There is an invalid free in ReadImage in input-bmp.ci that leads to a Segmentation fault in sam2p 0.49.4. A crafted input will lead to a denial of service or possibly unspecified other impact. (CVE-2018-7554)

There is a heap-based buffer overflow in bmp_compress1_row in appliers.cpp in sam2p 0.49.4 that leads to a denial of service or possibly unspecified other impact. (CVE-2018-12578)

There is a heap-based buffer overflow in ReadImage in input-tga.ci in sam2p 0.49.4 that leads to a denial of service or possibly unspecified other impact. (CVE-2018-12601)

References:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-14628
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-14629
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-14630
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-14631
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-14636
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-14637
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-16663
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-7487
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-7551
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-7553
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-7554
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-12578
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-12601
https://www.debian.org/lts/security/2018/dla-1463
========================

Updated package in core/updates_testing:
========================
sam2p-0.49.3-2.1.mga7

from SRPM:
sam2p-0.49.3-2.1.mga7.src.rpm

Version: Cauldron => 7
Status: NEW => ASSIGNED
CVE: CVE-2018-12601 => (none)
Assignee: pkg-bugs => qa-bugs
Whiteboard: MGA7TOO => (none)

Where did you find all of those additional CVEs?

In the tarball from Debian (http://security.debian.org/debian-security/pool/updates/main/s/sam2p/sam2p_0.49.2-3+deb8u3.debian.tar.xz).  I had to slightly modify a few of them because the version in Debian is 0.49.2.

Add these to References:
https://www.debian.org/lts/security/2017/dla-1127
https://www.debian.org/lts/security/2017/dla-1185
https://www.debian.org/lts/security/2018/dla-1340
https://www.debian.org/lts/security/2018/dla-1463

Testing this for mga7, x64.  In the process of assembling and testing poc files.  Shall attach test reports in due course.

CC: (none) => tarazed25

Created attachment 12083 [details]
Series of poc tests before sam2p update

Created attachment 12084 [details]
Results of poc tests after update of sam2p

Created attachment 12085 [details]
Series of poc tests on sam2p before update

Attachment 12083 is obsolete: 0 => 1

Ran poc tests before and after the update.  Two possible failures.

Used sam2p to transform input images into various output formats.$ sam2p jessica_1.tif PDF: jessica.pdf
This is sam2p 0.49.3.
Available Loaders: PS PDF JAI PNG JPEG TIFF PNM BMP LBM XPM PCX TGA.
Available Appliers: XWD Meta Empty BMP PNG TIFF6 TIFF6-JAI JPEG-JAI JPEG PNM XPM PSL1C PSL23+PDF PSL2+PDF-JAI P-TrOpBb.
sam2p: Notice: job: read InputFile: jessica_1.tif
sam2p: Notice: writeTTT: using template: p02bb
sam2p: Notice: applyProfile: applied OutputRule #22 using applier PSL23+PDF
sam2p: Notice: job: written OutputFile: jessica.pdf
Success.
$ xpdf jessica.pdf
<Works fine>
$ sam2p Glenview.png EPS: glenview.ps
$ gs glenview.ps
<Looks OK>
$ sam2p Pleiades_Fraile.jpg BMP: pleiades.bmp
$ display pleiades.bmp
<Perfect>

The conversions work.  Giving this the OK.

Whiteboard: (none) => MGA7-64-OK

Validating
Advisory pushed to SVN.

Keywords: (none) => advisory, validated_update
CC: (none) => sysadmin-bugs

An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGASA-2020-0459.html

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED