Bug 27573

Summary: AMD sensor fusion hub support removed on accident(?) for 5.7 kernel / no amd_mp2_pcie module
Product: Mageia Reporter: Christian Lohmaier <lohmaier+mageia>
Component: RPM PackagesAssignee: Kernel and Drivers maintainers <kernel>
Status: RESOLVED OLD QA Contact:
Severity: normal    
Priority: Normal CC: mageia, pterjan, thierry.vignaud
Version: 7Keywords: Triaged
Target Milestone: ---   
Hardware: All   
OS: Linux   
URL: https://svnweb.mageia.org/packages/updates/7/kernel/current/SPECS/kernel.spec?r1=1603190&r2=1611343
See Also: https://bugs.mageia.org/show_bug.cgi?id=24877
Whiteboard:
Source RPM: kernel-5.7.19-3.mga7.src.rpm CVE:
Status comment:

Description Christian Lohmaier 2020-11-06 15:12:58 CET
Description of problem:
Without the driver for the AMD SFH (sensor fusion hub), device rotation and orientation cannot be read by iio-sensor-proxy and hence convertible/tablet laptops cannot react to flipping the screen or putting the device in portrait mode.

Version-Release number of selected component (if applicable):
Happened with the first 5.7 kernel, see the kernel.spec bump

I suspect it was dropped because of the TTL 5.7 remark that then didn't happen - they were not included upstream in time for the 5.7 release.

functionality is hard to check for people without supported hardware, but of course you can always check for drivers/hid/amd-sfh-hid/ in the package... (or the amd-mp2-pcie.ko.xz and/or amd-sfhtp-hid.ko.xz kernel modules)

If it wasn't by accident, then there's a log message missing explaining why it was dropped....
Christian Lohmaier 2020-11-06 15:13:08 CET

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=24877

Comment 1 Christian Lohmaier 2020-11-06 15:22:06 CET
also might be worth updating to the current revision of the patches:
https://lkml.org/lkml/2020/10/9/1015
modules were simplified/renamed... and it will hopefully at some point be blessed for inclusion into upstream...
Comment 2 Aurelien Oudelet 2020-11-07 10:23:11 CET
Hi, thanks for reporting this bug.

Assigned to the Kernel and Drivers Group. Added recent commiters.

(Please set the status to 'assigned' if you are working on it)

CC: (none) => mageia, pterjan, thierry.vignaud
Assignee: bugsquad => kernel
Keywords: (none) => Triaged

Comment 3 Thomas Backlund 2020-11-16 09:44:13 CET
It was intentionally dropped here (on my request):
http://svnweb.mageia.org/packages?view=revision&revision=1601918

as it had various potential security and other issues related to memory corruption and null pointer derefs

And since Amd was not in a big rush back then to fix those up, it was the sanest /  only option to drop it while waiting for some newer fixed revisions...

As it now finally seems to have gotten fixed up and seems to be good enough to get merged upstream for upcoming 5.11 it could be added again...
Comment 4 Christian Lohmaier 2020-11-16 11:19:57 CET
thx for the reply. I though every commit would automatically end up in changelog entry, so apparently I'm wrong on that. I only did look at 
rpm -q --changelog kernel-desktop-5.7.19-3.mga7-1-1.mga7
for any hints of the removal, not into svn log - but good to know that it was not a random drop, but intentional - of course I hope it will be added back soon.
Comment 5 Thierry Vignaud 2020-11-17 11:32:05 CET
The above commit was done in cauldron.
I guess the backport to mga7 just smashed all the commits into one.
It would be easier with git but that's life
Comment 6 Thomas Backlund 2020-11-21 17:13:25 CET
AMD SFH driver re-added to upcoming Cauldron 5.9.9-2 kernel
Comment 7 Thomas Backlund 2020-11-28 12:12:54 CET
it's also coming to mga7 with

5.9.11-3.mga7 (or newer)
Comment 8 Christian Lohmaier 2020-11-30 15:46:59 CET
can confirm that with 5.9.11-3.mga7 from updates-testing repo automatic change of screen orientation works again. Thx for the backport
Comment 9 Aurelien Oudelet 2021-07-06 13:17:49 CEST
Mageia 7 is EOL since July 1st 2021.
There will not have any further bugfix for this release.

You are encouraged to upgrade to Mageia 8 as soon as possible.

@reporter, if this bug still apply with Mageia 8, please let us know it.

@packager, if you work on the Mageia 7 version of your package, please check the Mageia 8 package if issue is also present. In this case, please fix the Mageia 8 version instead.

This bug report will be closed OLD if there is no further notice within 1st September 2021.
Comment 10 Marja Van Waes 2021-09-07 14:11:21 CEST
Hi bug reporter and hi assignee and others involved,

Please reopen this bug report if it is still valid for Mageia 8 or 9(cauldron), and change "Version:" in the upper left of this report accordingly.

This report is being closed as OLD because it was filed against Mageia 7, for which  support ended on June 30th 2021.

Thanks,
Marja

Resolution: (none) => OLD
Status: NEW => RESOLVED