Bug 27229

Summary:	Installer selects incorrect swap partition from removable media
Product:	Mageia	Reporter:	David Walser <luigiwalser>
Component:	Installer	Assignee:	Mageia tools maintainers <mageiatools>
Status:	REOPENED ---	QA Contact:
Severity:	normal
Priority:	Normal	CC:	fri
Version:	Cauldron	Keywords:	Triaged
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	drakx-installer-stage2-18.21.1-2.mga7.src.rpm	CVE:
Status comment:

Description David Walser 2020-08-30 19:24:13 CEST

I typically do new Mageia installations bootstrapped via all.img with the repos on an external USB HDD.  It happens to also be the disk I use for backups and it has a swap partition on it.  Our installer not only enables its swap partition in fstab by default, which it should not, and causes the system to not boot later in the boot process if it is not present, now in Mageia 7 it also uses the UUID of this swap partition as the resume= value in /etc/default/grub, which makes the boot process fail at the very beginning with no helpful output indicating why.

The installer should not enable or use swap partitions detected on removable media unless the system is actually being installed onto said removable media.

Comment 1 Aurelien Oudelet 2020-08-31 22:11:25 CEST

Thanks for the bug report.

This is problematic. Installer found a swap partition on external drive, use it for itself and put it on /etc/fstab of the installed system.
Tried myself and my external USB harddrive appear as a /dev/sdc it can't be undifferentiated from an internal harddrive.

Assigning to Mageia Tools Maintainers.

(Please set the status to 'assigned' if you are working on it)

Keywords: (none) => Triaged
Assignee: bugsquad => mageiatools

Comment 2 David Walser 2020-08-31 22:15:58 CEST

Yeah, adding the external swap to fstab is an old problem, I think our installer has always done that since the beginning of time (still should get fixed), but using it as the resume= is much more nefarious and I don't remember having that problem through mga5 (never installed mga6).

Comment 3 Aurelien Oudelet 2020-08-31 22:18:03 CEST

And what about adding a swap partition on an internal harddrive within the Installer while having an other on the external?

I should test this, as soon as possible.

Comment 4 David Walser 2020-08-31 22:20:32 CEST

Yes that's exactly what I do.

Comment 5 Aurelien Oudelet 2020-09-20 17:45:03 CEST

Hi,
This bug is against our Installer DrakX.

@Developers/Packagers: Feel free to reassign to correct person.
Also, if you are working on this, please change the status of this bug to "Assigned".
Feel free to close this if already fixed.

@All
Thanks making DrakX even better.

Comment 6 Marja Van Waes 2021-09-07 14:09:44 CEST

Hi bug reporter and hi assignee and others involved,

Please reopen this bug report if it is still valid for Mageia 8 or 9(cauldron), and change "Version:" in the upper left of this report accordingly.

This report is being closed as OLD because it was filed against Mageia 7, for which  support ended on June 30th 2021.

Thanks,
Marja

Resolution: (none) => OLD
Status: NEW => RESOLVED

David Walser 2021-09-07 14:25:55 CEST

Status: RESOLVED => REOPENED
Resolution: OLD => (none)

David Walser 2021-09-07 14:26:51 CEST

Version: 7 => Cauldron

Morgan Leijström 2021-09-07 17:27:52 CEST

CC: (none) => fri