Bug 27090

Summary:	plymouth-start.service: KillMode=none is unsafe
Product:	Mageia	Reporter:	Bit Twister <bittwister2>
Component:	RPM Packages	Assignee:	Base system maintainers <basesystem>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	ouaurelien, tmb
Version:	Cauldron
Target Milestone:	---
Hardware:	All
OS:	Linux
URL:	https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/123
Whiteboard:
Source RPM:	plymouth-0.9.5-3.mga8.src.rpm	CVE:
Status comment:

Description Bit Twister 2020-08-12 13:26:31 CEST

Description of problem: mga8 dev0

systemd[1]: /usr/lib/systemd/system/plymouth-start.service:15: Unit configured to use KillMode=none. This is unsafe, as it disables systemd's process lifecycle management for the service. Please update your service to use a safer KillMode=, such as 'mixed' or 'control-group'. Support for KillMode=none is deprecated and will eventually be removed. 
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. boot system
2. journalctl --no-hostname | grep KillMode
3.

Comment 1 Aurelien Oudelet 2020-08-12 17:18:28 CEST

Confirmed.

See similars outputs since change to systemd 246.

Assigning to Basesystem maintainers.

CC: (none) => ouaurelien
Assignee: bugsquad => basesystem

Aurelien Oudelet 2020-08-24 11:29:37 CEST

CC: ouaurelien => (none)

Comment 2 Aurelien Oudelet 2020-08-24 11:42:59 CEST

Upstream plymouth has been updated on 2020-07-08
(https://www.freedesktop.org/software/plymouth/releases/)

This adds:
0.9.5

- Add new firmware-upgrade mode
- Deprecate some cruft, expunge some old code
- Add keyboard layout indicator
- Add translations
- Improve boot.log output
- Darmatically rework DRM renderer
- Add support for EFI vendor provided logos
- Theme updates
- Misc fixes

Issue reported by an Arch user. Also give some comment there.

URL: (none) => https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/123

Comment 3 Aurelien Oudelet 2020-10-30 13:51:38 CET

Upstream has release a commit on gitlab in master branch on Sept. 18th 2020.

https://gitlab.freedesktop.org/plymouth/plymouth/-/commit/b406b0895a95949db2adfedaeda451f36f2b51c3

Notable change:

systemd-units/plymouth-start.service.in
@@ -6,11 +6,12 @@
After=systemd-vconsole-setup.service systemd-udev-trigger.service systemd-udevd.
Before=systemd-ask-password-plymouth.service
ConditionKernelCommandLine=!plymouth.enable=0
ConditionVirtualization=!container
IgnoreOnIsolate=true     <==== Added

[Service]
ExecStart=@PLYMOUTH_DAEMON_DIR@/plymouthd --mode=boot --pid-file=@plymouthruntimedir@/pid --attach-to-session
ExecStartPost=-@PLYMOUTH_CLIENT_DIR@/plymouth show-splash
Type=forking
RemainAfterExit=yes
KillMode=mixed           <==== Modified
SendSIGKILL=no

We are currently at 0.9.5-1.mga8 release, in phase with upstream. Commit has been done after release.
Tested above changes: OK on my Cauldron.

CC: (none) => ouaurelien

Comment 4 Aurelien Oudelet 2021-02-01 17:27:53 CET

Still valid with Mageia 8 RC take 5.
See comments above for solving this unnecessary complain.

Affected version:
plymouth-0.9.5-3.mga8.src.rpm
CC'd tmb on this.

CC: (none) => tmb
Source RPM: plymouth-0.9.4-3.mga8.src.rpm => plymouth-0.9.5-3.mga8.src.rpm

Comment 5 Thomas Backlund 2021-02-01 17:37:51 CET

fix merged in  plymouth-0.9.5-5.mga8

Resolution: (none) => FIXED
Status: NEW => RESOLVED

Comment 6 Aurelien Oudelet 2021-02-01 17:55:48 CET

Thanks Thomas!