Bug 27012

Summary:	drak-net: /etc/sysconfig/clock is not used, code assumes it is
Product:	Mageia	Reporter:	Olav Vitters <olav>
Component:	RPM Packages	Assignee:	Mageia tools maintainers <mageiatools>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	Normal	CC:	thierry.vignaud
Version:	Cauldron
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	drakx-net-2.51-1.mga8.src.rpm, drakxtools-18.32-1.mga8.src.rpm	CVE:
Status comment:

Description Olav Vitters 2020-07-28 21:36:21 CEST

Description of problem:
drakx-net/lib/network/netconnect.pm reads from /etc/sysconfig/clock in the function detect_timezone. This file has not been used anymore. No package owns it. The code should be adjusted to whatever is the current method.


Version-Release number of selected component (if applicable):
git master, I think the package is drakx-net

How reproducible:


Steps to Reproduce:
1.
2.
3.

Comment 1 Olav Vitters 2020-07-28 21:37:14 CEST

Also affects: drakx/perl-install/timezone.pm, so the drakx package.

CC: (none) => thierry.vignaud

Comment 2 Lewis Smith 2020-07-29 20:57:45 CEST

Thanks for the report, Olav. I wonder how you noticed...

netconnect.pm is in pkg libdrakx-net in SRPM drakx-net.
timezone.pm is in pkg drakxtools-backend in SRPM drakxtools
(The same moodule name exists also in 'awstats', but is certainly not the same).

Assignee: bugsquad => mageiatools
Source RPM: (none) => drakx-net-2.51-1.mga8.src.rpm, drakxtools-18.32-1.mga8.src.rpm

Comment 3 Olav Vitters 2020-07-30 14:08:48 CEST

(In reply to Lewis Smith from comment #2)
> Thanks for the report, Olav. I wonder how you noticed...

I read and analyzed every commit to upstream initscripts between our packaged version and the latest version. One commit removed the documentation for this file. I mistakenly thought/assumed it also threw away the support code. So I grepped for the filename in the "all packages specfile" download, plus I have a few git checkout of Mageia software. The grep of that showed me.

So basically: trying to upgrade initscripts and being maybe a bit too thorough to avoid regressions