Bug 26863

Summary:	Update candidate: desktop-file-utils supports spec version 1.4
Product:	Mageia	Reporter:	Rémi Verschelde <rverschelde>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	andrewsfarm, sysadmin-bugs, tarazed25
Version:	7	Keywords:	advisory, has_procedure, validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	MGA7-64-OK
Source RPM:	desktop-file-utils-0.23-5.1.mga7	CVE:
Status comment:

Description Rémi Verschelde 2020-06-26 16:41:43 CEST

Advisory:
=========

Updated desktop-file-utils adds support for Desktop Entry Specification 1.4

  The desktop-file-utils 0.23 tool in Mageia 7 only supports up to version 1.1 of
  the Desktop Entry Specification, but the current version is 1.4.
  This update fixes it by providing desktop-file-utils 0.26.

References:

 - https://gitlab.freedesktop.org/xdg/desktop-file-utils/-/commits/0.26/

RPMs in core/updates_testing:
=============================

desktop-file-utils-0.26-1.mga7


SRPM in core/updates_testing:
=============================

desktop-file-utils-0.26-1.mga7


Testing procedure:
==================

You can use desktop-file-validate to validate .desktop files (e.g. from `/usr/share/applications`) and ensure that it works well before and after the update.

You can also confirm that the pre-update version fails to validate .desktop files using newer features from the spec, e.g.:

$ cat << EOF > org.godotengine.Godot.desktop 
[Desktop Entry]
Name=Godot Engine
GenericName=Libre game engine
Comment=Multi-platform 2D and 3D game engine with a feature-rich editor
Exec=godot %f
Icon=godot
Terminal=false
PrefersNonDefaultGPU=true
Type=Application
MimeType=application/x-godot-project;
Categories=Development;IDE;
EOF

$ desktop-file-validate org.godotengine.Godot.desktop 
org.godotengine.Godot.desktop: error: file contains key "PrefersNonDefaultGPU" in group "Desktop Entry", but keys extending the format should start with "X-"

The update should fix that.

This update is necessary to allow the Mageia 7-based infra to validate packages using such features.

Comment 1 Rémi Verschelde 2020-06-26 16:42:56 CEST

> This update is necessary to allow the Mageia 7-based infra to validate packages using such features.

@ Sysadmins: Should this also be pushed to infra_7, or would it automatically receive the normal core/updates packages and thus this update too?

CC: (none) => sysadmin-bugs

Rémi Verschelde 2020-06-28 12:35:16 CEST

Keywords: (none) => has_procedure

Comment 2 Len Lawrence 2020-06-28 17:26:45 CEST

mga7, x64

Before update:
$ desktop-file-validate org.godotengine.Godot.desktop 
org.godotengine.Godot.desktop: error: file contains key "PrefersNonDefaultGPU" in group "Desktop Entry", but keys extending the format should start with "X-"

After update:
$ rpm -q desktop-file-utils
desktop-file-utils-0.26-1.mga7
$ desktop-file-validate org.godotengine.Godot.desktop 
$

Thanks Rémi for the helpful procedure.

Whiteboard: (none) => MGA7-64-OK
CC: (none) => tarazed25

Comment 3 Thomas Andrews 2020-06-28 17:57:39 CEST

Well this is weird. I tried this one before the update, and couldn't find a desktop file that returned anything, so I went ahead and installed Remi's example. And that one didn't return anything, either! I installed the update, and there was no change. Still no error messages.0.

In the meantime, it worked for Len, so I'll go ahead and validate. But the reason why it didn't fail before the update for me is a mystery...

Advisory in Comment

CC: (none) => andrewsfarm
Keywords: (none) => validated_update

Comment 4 Thomas Andrews 2020-06-28 18:01:20 CEST

Advisory in Comment 0.

Comment 5 Rémi Verschelde 2020-07-03 10:10:09 CEST

(In reply to Thomas Andrews from comment #3)
> Well this is weird. I tried this one before the update, and couldn't find a
> desktop file that returned anything, so I went ahead and installed Remi's
> example. And that one didn't return anything, either! I installed the
> update, and there was no change. Still no error messages.0.

No error means that it all the desktop files you tested are valid for both the older and new versions, which is expected from files in /usr/share/applications as they have been validated using desktop-file-utils on our buildsystem.

The custom org.godotengine.Godot.desktop which I copied in comment 0 should make the original version fail (and prevents me from updating Godot in Cauldron and Mageia 7, hence this update).

Advisory uploaded.

Keywords: (none) => advisory

Comment 6 Mageia Robot 2020-07-04 23:37:43 CEST

An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2020-0152.html

Resolution: (none) => FIXED
Status: NEW => RESOLVED