| Summary: | rpm bug fix: fix detecting zstd magic | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Thierry Vignaud <thierry.vignaud> |
| Component: | RPM Packages | Assignee: | QA Team <qa-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | andrewsfarm, mageia, sysadmin-bugs, tmb |
| Version: | 7 | Keywords: | advisory, validated_update |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | MGA7-64-OK | ||
| Source RPM: | rpm-4.14.2.1-13.mga7 | CVE: | |
| Status comment: | |||
| Bug Depends on: | |||
| Bug Blocks: | 25992 | ||
|
Description
Thierry Vignaud
2019-12-28 07:54:39 CET
Thierry Vignaud
2019-12-30 03:34:33 CET
Blocks:
(none) =>
25992 Installed and tested without issue. Tests included listing/verifying/querying installed packages and installing/updating/uninstalling packages. ---------------- To satisfy dependencies, the following packages are going to be installed: Package Version Release Arch (medium "Core Updates Testing") lib64rpm8 4.14.2.1 13.mga7 x86_64 perl-URPM 5.23 1.mga7 x86_64 python2-rpm 4.14.2.1 13.mga7 x86_64 python3-rpm 4.14.2.1 13.mga7 x86_64 rpm 4.14.2.1 13.mga7 x86_64 rpm-plugin-ima 4.14.2.1 13.mga7 x86_64 rpm-plugin-syslog 4.14.2.1 13.mga7 x86_64 rpm-plugin-systemd-inhibit 4.14.2.1 13.mga7 x86_64 389KB of disk space will be freed. 996KB of packages will be retrieved. Proceed with the installation of the 8 packages? (Y/n) ---------------- $ uname -a Linux marte 5.4.6-desktop-2.mga7 #1 SMP Mon Dec 23 12:05:27 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux $ rpm -qa | grep -i rpm.*4.14 | sort lib64rpm8-4.14.2.1-13.mga7 lib64rpmbuild8-4.14.2.1-12.1.mga7 lib64rpmsign8-4.14.2.1-12.1.mga7 python2-rpm-4.14.2.1-13.mga7 python3-rpm-4.14.2.1-13.mga7 rpm-4.14.2.1-13.mga7 rpm-plugin-ima-4.14.2.1-13.mga7 rpm-plugin-syslog-4.14.2.1-13.mga7 rpm-plugin-systemd-inhibit-4.14.2.1-13.mga7 CC:
(none) =>
mageia Thierry, is there a zstd-compressed rpm that we can use to test this specifically, or are PC LX's tests sufficient for now? CC:
(none) =>
andrewsfarm Well any recent rpm from cauldron might be used (rpm -Uvh --test) But honestly, rpm supported those already. The bug only affected urpmi when reading zstd compressed metadata. You can test that by altering /bin/genhdlist2 to use zstd instead of xz (simple change or see my patch 1 or 2 weeks ago) Then create a dummy medium with an updated task-obsolete or null package (bumped rel should do it): 1) bump rel & rebuild task-obsolete 2) run genhdlist2 in that dir 3) try urpmi.addmedia TEST path_of_this_medium It should fail 4) update to new rpm + new perl-URPM (see depending bug #25992) 5) try again adding the medium It should now works Thank you for responding, Thierry. Unfortunately, while I have picked up a lot the last few years, even that simple procedure is beyond my meager capabilities. I'm going to send this and Bug 25992 along on the basis of PC LX's clean installs and tests. It doesn't appear to break anything currently used, and if the zstd support has a problem I'm sure it will show up quickly as Cauldron develops, at which point any needed changes will be passed along. Validating. Advisory in Comment 0. CC:
(none) =>
sysadmin-bugs
dropping validation for now...
does this actually fix anything ?
# rpm -q rpm
rpm-4.14.2.1-12.1.mga7
# rpm -qp --qf "%{NAME}-%{VERSION}-%{RELEASE}: %{PAYLOADCOMPRESSOR} %{PAYLOADFLAGS}\n" /home/tmb/x86_64/wireguard-tools-1.0.20200102-1.mga8.x86_64.rpm
wireguard-tools-1.0.20200102-1.mga8: zstd 19
# LANG=C rpm -ivh /home/tmb/x86_64/wireguard-tools-1.0.20200102-1.mga8.x86_64.rpm
Verifying... ################################# [100%]
Preparing... ################################# [100%]
Updating / installing...
So our current rpm already detects and installs zstd packed rpmsKeywords:
validated_update =>
feedback And answering myself.... it's needed for perl-URPM update to work, as without it we get: urpmi wireguard-tools invalid line <(�/�h=> problem reading synthesis for media "test" Hence the "enabling to switch mga8 to use zstd compressed metadata" in comment #0 :-) validating again after the metadata tests Keywords:
feedback =>
advisory, validated_update An update for this issue has been pushed to the Mageia Updates repository. https://advisories.mageia.org/MGAA-2020-0009.html Resolution:
(none) =>
FIXED |