Bug 2586

Summary: mgarepo ci should check in changes made in all directories
Product: Mageia Reporter: Olav Vitters <olav>
Component: RPM PackagesAssignee: Mageia Bug Squad <bugsquad>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: Normal CC: balcaen.john, doktor5000, marja11, sysadmin-bugs
Version: Cauldron   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: mgarepo CVE:
Status comment:

Description Olav Vitters 2011-09-01 16:55:39 CEST
I think it would be easier if "mgarepo ci" checks in the changes for all directories (SPECS + SOURCES). That would make it different from SVN, but I noticed that none of the instructions currently mention that you should do the "svn ci" from the main directory.

This resulted in me not committing changes properly. IMO the nicest fix is to make mgarepo ci behave nicely so people not using SVN or often using git do not have to care about the differences and can just rely on mgarepo doing whatever is required.
Comment 1 John Balcaen 2011-09-01 18:28:31 CEST
(In reply to comment #0)
> I think it would be easier if "mgarepo ci" checks in the changes for all
> directories (SPECS + SOURCES). That would make it different from SVN, but I
> noticed that none of the instructions currently mention that you should do the
> "svn ci" from the main directory.
hum it does work like this here.
The only things to handle in fact is the « source/patch updates » via a mgarepo sync -c (to commit immediatly) when we're adding/removing a binary, you can always add/remove a patch (or a text file in SOURCES folder) using svn add/del & after mgarepo ci should show all your changes.

There's a bug regarding mgarepo ci when you did play with svn mv before (i did not try recently so i'm not sure it's fixed) )

CC: (none) => balcaen.john

Comment 2 Marja Van Waes 2011-12-29 20:46:56 CET
pinging because this bug still has the NEW status and didn't show any activity in almost 4 months

@ sysadmin

Please set status to ASSIGNED if you think this bug was assigned correctly. If for work flow reasons you can't do that, then please put OK on the whiteboard instead.

CC: (none) => marja11

Comment 3 Nicolas Vigier 2012-01-13 23:37:56 CET
(In reply to comment #0)
> 
> This resulted in me not committing changes properly. IMO the nicest fix is to
> make mgarepo ci behave nicely so people not using SVN or often using git do not
> have to care about the differences and can just rely on mgarepo doing whatever
> is required.

This could be confusing for people used to svn and not git, who could unexpectedly commit some changes from an other directory. I think the "mgarepo ci" command is not very useful, it's better to use svn ci directly (or later git if we switch to git).

Status: NEW => ASSIGNED
CC: (none) => boklm

Nicolas Vigier 2013-09-21 16:16:04 CEST

Component: BuildSystem => RPM Packages
Version: unspecified => Cauldron
Assignee: sysadmin-bugs => boklm
Product: Infrastructure => Mageia

Nicolas Vigier 2014-03-24 10:52:44 CET

CC: boklm => (none)

Nicolas Vigier 2014-03-24 10:54:19 CET

Assignee: boklm => bugsquad

Florian Hubold 2015-12-19 14:34:03 CET

CC: (none) => doktor5000

Comment 4 Marja Van Waes 2016-08-01 11:17:38 CEST
(In reply to Nicolas Vigier from comment #3)
> (In reply to comment #0)
> > 
> > This resulted in me not committing changes properly. IMO the nicest fix is to
> > make mgarepo ci behave nicely so people not using SVN or often using git do not
> > have to care about the differences and can just rely on mgarepo doing whatever
> > is required.
> 
> This could be confusing for people used to svn and not git, who could
> unexpectedly commit some changes from an other directory. I think the
> "mgarepo ci" command is not very useful, it's better to use svn ci directly
> (or later git if we switch to git).

Closing as wontfix, then

Status: ASSIGNED => RESOLVED
Resolution: (none) => WONTFIX