Bug 2566

Summary: Change svnnotify options for packages-commits mailing list
Product: Infrastructure Reporter: Olav Vitters <olav>
Component: OthersAssignee: Sysadmin Team <sysadmin-bugs>
Status: ASSIGNED --- QA Contact:
Severity: enhancement    
Priority: Normal CC: marja11, sysadmin-bugs
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: CVE:
Status comment:
Bug Depends on:    
Bug Blocks: 858    

Description Olav Vitters 2011-08-30 09:55:36 CEST 
The following command line option would be nice:
  --subject-cx / -C

"A boolean value indicating whether or not to include a the context of the commit in the subject line of the email. In a commit that affects multiple files, the context will be the name of the shortest directory affected by the commit. This should indicate up to how high up the Subversion repository tree the commit had an effect. If the commit affects a single file, then the context will simply be the name of that file."


Then also (you might want to look into the ticket-map option to tweak the regexp it uses for matching bug numbers):
  --bugzilla-url 'https://bugs.mageia.org/show_bug.cgi?id=%s'

Then for svnweb:
  --viewcvs-url 'http://svnweb.mageia.org/packages/?revision=%s&view=revision'
Note: this seems to need the /packages/ bit!


It would also be nice if the From: was a bit more clearer. Ideally it should be something like:
  "$USERNAME" <root@mageia.org>

but I don't see an obvious easy way to do that. Perhaps something like:
  author=`svnlook author $REPOS -r $REV`
followed by:
  --from "\"$author\" <root@mageia.org>"
^^ I did not test above!!
Olav Vitters 2011-08-30 09:56:08 CEST

Summary: Change svnnotify options => Change svnnotify options for packages-commits mailing list

Comment 1 Nicolas Vigier 2011-08-30 12:04:38 CEST 
Currently we are using SVN::Notify::Config :
http://svnweb.mageia.org/adm/puppet/modules/subversion/templates/hook_sendmail.pl?revision=1882&view=markup

But doing some of those changes is not possible with SVN::Notify::Config, so we need to rewrite the script in shell or perl to use svnnotify.

CC: (none) => boklm

Comment 2 Marja Van Waes 2011-11-10 06:59:20 CET 
ping?

CC: (none) => marja11

Nicolas Vigier 2012-01-13 23:24:01 CET

Status: NEW => ASSIGNED
Blocks: (none) => 858

Nicolas Vigier 2014-03-24 10:52:30 CET

CC: boklm => (none)

Comment 3 Mageia Robot 2024-02-13 08:40:16 CET 
commit 1dcb5d027b9dda13ff5740e0be1a0dc86f97d8c7
Author: Dan Fandrich <danf@...>
Date:   Mon Feb 12 23:32:43 2024 -0800

    Improve the subversion commit messages (mga#2566)
    
    - Add the path to the subject
    - Add a link to Bugzilla for bugs
    - Add a link to svnweb
---
 Commit Link:
   https://gitweb.mageia.org/infrastructure/puppet/commit/?id=1dcb5d027b9dda13ff5740e0be1a0dc86f97d8c7
Comment 4 Mageia Robot 2024-02-13 17:47:56 CET 
commit 91628ccea644a422276e1a369251d35cbee0b67e
Author: Dan Fandrich <danf@...>
Date:   Tue Feb 13 08:46:15 2024 -0800

    Remove the ticket_map option in hook_sendmail.pl (mga#2566)
    
    It resulted in the svnlook error:
    
        Can't use string ("\bmga#(\d+)\b=https://bugs.magei"...) as a HASH
        ref while "strict refs" in use at
        /usr/share/perl5/vendor_perl/SVN/Notify.pm line 1789.
---
 Commit Link:
   https://gitweb.mageia.org/infrastructure/puppet/commit/?id=91628ccea644a422276e1a369251d35cbee0b67e
Comment 5 Mageia Robot 2024-02-16 03:48:37 CET 
commit 808578789e9f2fb6ea1575252fb47f808d6c5407
Author: Dan Fandrich <danf@...>
Date:   Thu Feb 15 18:43:51 2024 -0800

    Add a ticket_map for Bugzilla to hook_sendmail.pl (mga#2566)
    
    This time, use a YAML mapping, as I suspect that's what the code is
    looking for instead of a plain string.
---
 Commit Link:
   https://gitweb.mageia.org/infrastructure/puppet/commit/?id=808578789e9f2fb6ea1575252fb47f808d6c5407