Bug 25440

Summary: %configure fails because %__libtoolize isn't defined anymore
Product: Mageia Reporter: Jani Välimaa <jani.valimaa>
Component: RPM PackagesAssignee: Thierry Vignaud <thierry.vignaud>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal    
Version: Cauldron   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: rpm-4.15.0-0.rc1.5.mga8 CVE:
Status comment:
Attachments: Build log

Description Jani Välimaa 2019-09-14 15:23:11 CEST
Javapackages-tools build failed in BS because %configure macro is used.

%configure macro is broken because %__libtoolize isn't defined anymore.

%configure sets _legacy_autotools to 1 and calls %main_configure

%main configure calls %__libtoolize_configure and it's empty if %__libtoolize isn't defined.

%__libtoolize_configure %{?__libtoolize:(cd $CONFIGURE_TOP; [ ! -f configure.in -a ! -f configure.ac ] || %{__libtoolize} --copy --force)}

All this causes plain ; to be inserted to build script and it causes failure.

I think we should define __libtoolize again and/or ensure that %__libtoolize_configure returns something even when %__libtoolize isn't defined. Perhaps append %{?!__libtoolize:true} to it?
Comment 1 Jani Välimaa 2019-09-14 15:24:48 CEST
Created attachment 11278 [details]
Build log
Comment 2 Jani Välimaa 2019-09-14 15:37:38 CEST
__libtoolize was removed in upstream commmit https://github.com/rpm-software-management/rpm/commit/9f486b3
Comment 3 Lewis Smith 2019-09-14 20:32:32 CEST
Assigning to you, Thierry, for 'rpm'.

Assignee: bugsquad => thierry.vignaud

Comment 4 Thierry Vignaud 2019-09-19 11:39:28 CEST
Fixed in rpm-mageia-setup-2.41 (though we could live without that dumb macro...)

Resolution: (none) => FIXED
Status: NEW => RESOLVED