Bug 25174

Summary:	systemctl restart atop fails
Product:	Mageia	Reporter:	Hartmut Goebel <h.goebel>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	andrewsfarm, brtians1, geiger.david68210, sysadmin-bugs, tmb
Version:	7	Keywords:	advisory, validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	MGA7-64-OK
Source RPM:	atop-2.4.0-1.mga7.src.rpm	CVE:
Status comment:

Description Hartmut Goebel 2019-07-23 15:23:16 CEST

Description of problem:

Cron reports (via mail):

  Job for atop.service failed because the control process exited with error code.
  See "systemctl status atop.service" and "journalctl -xe" for details.

This cron job is run daily and thus this error is reported daily.

How reproducible: very easy, every time

Steps to Reproduce:
1. Install atop on Mageia 7,
2. run "systemctl restart atop":

   # systemctl restart atop
   Job for atop.service failed because the control process exited with error code.
   See "systemctl status atop.service" and "journalctl -xe" for details.
   # systemctl status atop | cat
   …
   atop.service: Failed at step EXEC spawning /usr/bin/atopd: No such file or directory
   …


Analysis:

/etc/cron.d/atop:
  0 0 * * * root systemctl restart atop

/usr/lib/systemd/system/atop.service:
   ExecStart=/usr/bin/atopd

but the atop package does not contain this executable:
  # rpm -ql atop
  /etc/atop/atop.daily
  /etc/cron.d/atop
  …
  /usr/bin/atop
  /usr/bin/atopsar
  /usr/lib/.build-id/a9/87b3d322484f11854e077b0fb6834cfe8b6477
  …

No other package provides atopd

  # urpmf atopd
  # urpmf bin/atop
  atop:/usr/bin/atop
  atop:/usr/bin/atopsar

Comment 1 Lewis Smith 2019-07-23 21:05:16 CEST

Assigning this globally as atop has no maintainer (but tv has been most involved in the past).

Assignee: bugsquad => pkg-bugs

Comment 2 David GEIGER 2019-11-10 09:03:25 CET

Please test new update of atop-2.5.0-1.mga7 in Core/Updates_testing repo!

I have made some improvements and fixes.

CC: (none) => geiger.david68210

Comment 3 Hartmut Goebel 2019-11-13 11:04:36 CET

Looks good. Thanks for fixing!

# systemctl status atop.service
● atop.service - Atop advanced performance monitor
   Loaded: loaded (/usr/lib/systemd/system/atop.service; disabled; vendor preset: d>
   Active: inactive (dead)
     Docs: man:atop(1)
# systemctl restart atop
# systemctl status atop.service
● atop.service - Atop advanced performance monitor
   Loaded: loaded (/usr/lib/systemd/system/atop.service; disabled; vendor preset: d>
   Active: active (running) since Wed 2019-11-13 11:02:50 CET; 17s ago
     Docs: man:atop(1)
  Process: 3248 ExecStartPre=/bin/sh -c test -n "$LOGINTERVAL" -a "$LOGINTERVAL" -e>
  Process: 3249 ExecStartPre=/bin/sh -c test -n "$LOGGENERATIONS" -a "$LOGGENERATIO>
  Process: 3252 ExecStartPost=/usr/bin/find ${LOGPATH} -name atop_* -mtime +${LOGGE>
 Main PID: 3250 (atop)
   Memory: 5.6M
   CGroup: /system.slice/atop.service
           └─3250 /usr/bin/atop -R -w /var/log/atop/atop_20191113 600

Nov 13 11:02:50 myhost systemd[1]: Starting Atop advanced performance monitor...
Nov 13 11:02:50 myhost systemd[1]: Started Atop advanced performance monitor.

Comment 4 David GEIGER 2019-11-13 17:33:00 CET

Assigning to QA,


Advisory:
========================

Current atop package fails to restart the atop systemd service due to some wrong configurations. So this update fixes this issue.

========================

Packages in 7/core/updates_testing:
========================
atop-2.5.0-1.mga7.i586.rpm
atop-2.5.0-1.mga7.x86_64.rpm

Source RPM: 
========================
atop-2.5.0-1.mga7.src.rpm

Assignee: pkg-bugs => qa-bugs

Comment 5 Brian Rockwell 2019-11-17 02:37:31 CET

MGA7 - on hardware - 64bit


root@localhost brian]# systemctl restart atop
[root@localhost brian]# ps -ef | grep atop
root      5509     1  2 19:36 ?        00:00:00 /usr/bin/atop -R -w /var/log/atop/atop_20191116 600


Ran the atop program from the command line as well.  Looks pretty interesting, another tool for performance monitoring - thanks

giving this a green light.

Whiteboard: (none) => MGA7-64-OK
CC: (none) => brtians1

Comment 6 Thomas Andrews 2019-11-18 22:34:13 CET

Validating. Advisory in Comment 4.

Keywords: (none) => validated_update
CC: (none) => andrewsfarm, sysadmin-bugs

Thomas Backlund 2019-11-19 18:51:40 CET

Keywords: (none) => advisory
CC: (none) => tmb

Comment 7 Mageia Robot 2019-11-19 22:18:09 CET

An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2019-0207.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED