Bug 24670

Summary: Upgrading M6.0 official to M7 B3 round 3 does not respect current timezone
Product: Mageia Reporter: Dick Gevers <dvgevers>
Component: InstallerAssignee: Thierry Vignaud <thierry.vignaud>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: fri, henk, mageia, marja11, shybluenight
Version: 7Keywords: 7beta3, PATCH
Target Milestone: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Source RPM: drakx-installer-stage2 CVE:
Status comment:
Attachments: Install of M6.0 bug report dated 20190414
report.bug from upgrade to M7 B3 Round 3 dated 20190415
Proposed patch

Description Dick Gevers 2019-04-15 11:52:54 CEST
Description of problem:

Steps to Reproduce:
* Install on real hardware Mageia 6.0 Official x86_64 classical iso
* Choose language en_GB, country The Netherlands, timezone UTC
* Reboot
* Remove 32 bit media, do NO updates at all.
* Change wireless regulatory domain in advanced settings to NL
* Upgrade with Classical iso Mageia7 Beta3 built 11th April 2019 (round 3)

When arriving at Installer Summary: Timezone defaults to western europe (or similar), zone of AMS terdam. 

This should be unchanged in upgrade from the timezone it was in at the start of the install. Not because the user cannot change it, but because the user expects the machine to have more correct information than the user. Showing a wrong default at this stage makes the user think the machine is stupid ;)

I shall attach report*.bug.xz for both installs.

Version-Release number of selected component (if applicable):
18.12-2
Comment 1 Dick Gevers 2019-04-15 11:56:04 CEST
Created attachment 10935 [details]
Install of M6.0 bug report dated 20190414
Comment 2 Dick Gevers 2019-04-15 11:57:06 CEST
Created attachment 10936 [details]
report.bug from upgrade to M7 B3 Round 3 dated 20190415
Dick Gevers 2019-04-15 11:57:41 CEST

CC: (none) => henk
Keywords: (none) => 7beta3, FOR_ERRATA7

Comment 3 Chris B 2019-04-15 13:54:01 CEST
Can't confirm this bug.
Tested yesterday a M6 (fully updated) to M7 upgrade, with the netinstall iso (afaik the same drakx-installer-stage2), language en_GB, country Netherlands, timezone was set in M6 to Europe/Amsterdam, the installer did respect the timezone, it was the same.

Difference: not on real hardware but in vbox, I did not touch the wireless regulatory domain, M6 was fully updated.

CC: (none) => shybluenight

Marja Van Waes 2019-04-15 18:43:24 CEST

Assignee: bugsquad => mageiatools
CC: (none) => marja11

Comment 4 Lewis Smith 2019-04-17 20:25:00 CEST
Using M7beta3 Classic ISO x64 real EFI hardware.
Locale English/GB, language Welsh, timezone Country/City = France/Paris.

I have just done the 6->7 upgrade with a charged 13Gb system, which I brought up-to-date beforehand. It took hours, and there were a few errors necessitating re-launching the upgrade stage, which eventually reached its end. At the summary screen, all the cited elements were still *correct*; and remain so in the upgraded system which I am using.
This is consistent with https://bugs.mageia.org/show_bug.cgi?id=24670#c3.
For us two at least, the reported problem is not manifest.

(In reply to Dick Gevers from comment #0)
> * Remove 32 bit media, do NO updates at all.
This raised an eyebrow, and made me wonder whether it was a factor. It is always stated that the system to upgrade should be up-to-date (at least to the date of the Classic ISO) before doing an upgrade.

P.S. I think bugs 24670 & 24671 could have been posted as one. If there is a problem, it is very probably the same cause.

CC: (none) => lewyssmith

Comment 5 Dick Gevers 2019-04-18 08:58:34 CEST
Replacing part of Bug#652

Assignee: mageiatools => thierry.vignaud

Comment 6 Martin Whitaker 2019-04-18 20:04:28 CEST
Tested this in VirtualBox, following Dick's instructions. For me the time zone (UTC) was retained, although the country/region was set to United Kingdom, as reported in bug 24671. I got the same result when fully updating the M6 installation prior to the M7 upgrade.

If you manually change the country/region at the Summary stage, that will change the time zone to match.

CC: (none) => mageia

Comment 7 Martin Whitaker 2019-04-18 21:23:25 CEST
Created attachment 10949 [details]
Proposed patch

The attached patch (untested) should prevent the time zone being automatically updated when you change the country in the Summary screen.
Martin Whitaker 2019-04-18 21:23:47 CEST

Keywords: (none) => PATCH

Comment 8 Lewis Smith 2019-04-18 23:41:02 CEST
@Dick
I am unclear whether the bugged timezone change comes from the upgrade itself, i.e. on the summary screen, is the timezone initially shown [un]changed before correcting the country? (because of bug 24671)
Or only changed due to correcting the country on the summary screen, re c6:
> If you manually change the country/region at the Summary stage,
> that will change the time zone to match
@Martin
If the latter, will the patch count as fixing this bug?
Comment 9 Dick Gevers 2019-05-24 19:03:20 CEST
The fix is okay for me testing with 6.0 > 7 RC round 3

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 10 Morgan Leijström 2019-06-29 16:08:19 CEST
So can FOR_ERRATA7 be removed?

CC: (none) => fri

Comment 11 Dick Gevers 2019-06-29 19:35:25 CEST
The fact that it is resolved | fixed does imply that, yes :))
Comment 12 Morgan Leijström 2019-06-30 00:51:43 CEST
Cleaning away the For Errata label then...

Keywords: FOR_ERRATA7 => (none)

Lewis Smith 2019-06-30 20:28:25 CEST

CC: lewyssmith => (none)