| Summary: | enigmail package missing / no clean update from mga6 | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Christian Lohmaier <lohmaier+mageia> |
| Component: | RPM Packages | Assignee: | José Jorge <lists.jjorge> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | release_blocker | CC: | doktor5000, marja11, nicolas.salguero |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://ml.mageia.org/l/arc/dev/2018-11/msg00046.html | ||
| Whiteboard: | |||
| Source RPM: | thunderbird-60.3.1-1.mga7.src.rpm | CVE: | |
| Status comment: | |||
|
Description
Christian Lohmaier
2018-11-28 12:37:28 CET
Setting this to release blocker for the missing enigmail. Please start a separate thread on dev ml about obsoleting, you can add that I'd like to better understand it, too! Assiging to Zézinho, who removed enigmail. CC'ing the registered maintainer. Severity:
normal =>
critical It just needs to be packaged separately, like fedora does : https://src.fedoraproject.org/rpms/thunderbird-enigmail/blob/master/f/thunderbird-enigmail.spec I will do it ASAP. (In reply to José Jorge from comment #2) > It just needs to be packaged separately, like fedora does : > > https://src.fedoraproject.org/rpms/thunderbird-enigmail/blob/master/f/ > thunderbird-enigmail.spec > > I will do it ASAP. Hi, I am sorry, I missed your comment and I added again enigmail into thunderbird.spec (version 60.3.3-3.mga7). Best regards, Nico CC:
(none) =>
nicolas.salguero FYI: Fixes the update-path for me, so could update my main desktop to cauldron now (needs the new HW-support for Ryzen w/ Vega).
One small issue:
The post / postun script seems broken / pointless.
both clear
/usr/lib64/thunderbird/components/compreg.dat and /usr/lib64/thunderbird/components/xpti.dat
(which arguably should never end up in /usr to begin with, and in fact do not exist in my install, so clearing that is OK)
but they also both try to run
HOME="$TB_TMPDIR" LD_LIBRARY_PATH="/usr/lib64/thunderbird" /usr/lib64/thunderbird/thunderbird-bin -nox -register
but that gives an error during installation:
Running Thunderbird as root in a regular user's session is not supported. ($XDG_RUNTIME_DIR is /run/user/1000 which is owned by cl.)
so likely the command didn't do anything.
The other issue is that the scripts don't distinguish between update and first unstall/final removal, and even worse it is not a postuninstall but *pre*uninstall, that for sure doesn't give the expected result.
I assume it is meant to update the list of installed extensions in some form. Thus updating will cause:
* Version_new's files get installed
→ postinstall script runs, with a potentially a handful of version_old's files still lying around
* preuninstall script of version_old gets run
→ doing exactly the same thing as the previous run, with a mix of the files of the new package, with not-yet-removed files of the old package still on disk
* version_old's files that are left over get removed
→ extension registry might potentially refer to no-longer existing files
so at least the preuninstall should be moved to postuninstall, so no mix of the extension's version shall exist anymore.
If you want to be extra thorough, check $1 (the number of packages on the system when the script runs) in the postinstall script, to skip it in the update case (since postuninstall of the old package will run it, and that is the point where the set of files is the one that should be considered)
################
tldr;
* /pre/uninstall for sure is wrong
* scripts don't seem to be necessary/they don't ensure a env where they run successfully and also the exit status is not checked
* ideally distinguish between update and installation/removal
Closing as we can use enigmail for long in MGA7 Status:
NEW =>
RESOLVED |