Bug 23904

Summary:	Installer partitioning window does not fit in main window
Product:	Mageia	Reporter:	Herman Viaene <herman.viaene>
Component:	Installer	Assignee:	Mageia tools maintainers <mageiatools>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	Normal	CC:	liquidzoo, mageia, marja11, pterjan, thierry.vignaud, yvesbrungard
Version:	Cauldron	Keywords:	7beta1, PATCH
Target Milestone:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Source RPM:	drakx-installer-stage2	CVE:
Status comment:
Attachments:	window install options does not fit in main window Proposed fix

Description Herman Viaene 2018-11-26 16:36:45 CET

Description of problem:
See attached image.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Comment 1 Herman Viaene 2018-11-26 16:39:01 CET

Created attachment 10506 [details]
window install options does not fit in main window

Comment 2 Herman Viaene 2018-11-26 16:39:35 CET

This Lenovo B50 laptop has Intel graphics.

Marja Van Waes 2018-11-29 07:49:44 CET

CC: (none) => marja11
Assignee: bugsquad => mageiatools
Summary: Window of installation options does not fit in main window => Installer partitioning window does not fit in main window
Source RPM: (none) => drakx-installer-stage2

Marja Van Waes 2018-11-29 07:50:19 CET

Keywords: (none) => 7beta1

Comment 3 papoteur 2019-01-02 13:40:28 CET

Hello,
I hit the same problem on a HP Pavillion, probably also an Intel graphic chipset.

CC: (none) => yves.brungard_mageia

Comment 4 Andrew Simmonds 2019-02-25 19:44:15 CET

Same here.  Dell Inspiron 15, 1366x768 resolution, intel graphics.  Pictures from Grub boot and from language selection screen.  Mageia 7 beta 2 ISO

https://imgur.com/a/xn6xbnR

The same Grub boot issue (on install) happens in fedora and OpenSUSE (at least, probably others too), but is not present in those installers.

CC: (none) => liquidzoo

Comment 5 Martin Whitaker 2019-02-26 22:49:28 CET

Created attachment 10797 [details]
Proposed fix

CC: (none) => mageia

Comment 6 Martin Whitaker 2019-02-26 22:52:09 CET

I believe the problem here is that the machine does not respect the vga=791 on the boot command line, and instead leaves the framebuffer at the native resolution of the panel. The installer only supports two fixed resolutions for the background images, 1024x768 and 800x600, but scales the dialogue windows according to the available screen size.

This can easily be reproduced - at least in VBox - by changing the boot command line to vga=794.

Ideally we would fix the installer to scale to the actual resolution, but that would require a change to the way the background is handled.

As an alternative, the attached patch centres the main window and fixes the size of the dialogue windows to keep them within the main window.

@Thierry, WDYT?

CC: (none) => thierry.vignaud
Keywords: (none) => PATCH

Comment 7 Martin Whitaker 2019-03-09 10:29:03 CET

No response, so I've pushed my simple fix to git.

Comment 8 Pascal Terjan 2023-05-06 21:48:16 CEST

I am seeing a crash here:

Uncaught exception from user code:
	Bareword "GTK_WIN_POS_CENTER_ALWAYS" not allowed while "strict subs" in use at install/gtk.pm line 167.
	Compilation failed in require at install/steps_gtk.pm line 22.
	BEGIN failed--compilation aborted at install/steps_gtk.pm line 22.
	Compilation failed in require at install/install2.pm line 754.

CC: (none) => pterjan

Comment 9 Pascal Terjan 2023-05-06 21:50:53 CEST

I just noticed the date of the commit, so probably something else changed since :)

Comment 10 Martin Whitaker 2023-05-06 22:10:55 CEST

No, it should have been quoted. But the "use strict" is stripped from all drakx modules in normal use, so I didn't spot that.