Bug 23773

Summary:	Check boxes not properly displayed in Firefox with dark applications theme
Product:	Mageia	Reporter:	aguador <waterbearer54>
Component:	RPM Packages	Assignee:	All Packagers <pkg-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	eatdirt, marja11
Version:	Cauldron
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	firefox-63.0-2.mga7.src.rpm	CVE:
Status comment:
Attachments:	FF with only corner of check boxes showing Basilisk showing check boxes correctly

Description aguador 2018-10-27 23:54:16 CEST

Since the advent of Quantum, Firefox has not played nicely with dark themes and on some sites check boxes have only a corner reproduced. (See files I will upload comparing Basilisk browser and FF checkboxes.)

The problem is even worse with FF-ESR in Mga6 where the boxes are completely invisible, but I decided to file against Cauldron as we seem to be heading toward a version release and not sure if the current or ESR versions will be used for release.

I assumed this was an upstream problem given all the FF bugs registered about dark themes. However, in testing a live version of MX Linux with Adwaita Dark I see that the boxes are correctly displayed (save some clipping of the right edge), so this issue may have a distro-level solution.

To reproduce this, run FF while you have a dark (general) application theme (not the FF theme which has no effect) and test on some sites with check boxes. The graphics in the attached files come from the folders of the gmx email web interface, but I have run into this on other sites before. (I wish I could be more precise, but I simply have not been visiting that many sites with interactive check boxes lately.)

Note my system is E22 with the Adwaita Dark theme (to have a theme that should be the most reliable) running, although the same thing happens with Vertex Dark.

Comment 1 aguador 2018-10-27 23:55:40 CEST

Created attachment 10435 [details]
FF with only corner of check boxes showing

Comment 2 aguador 2018-10-27 23:57:04 CEST

Created attachment 10436 [details]
Basilisk showing check boxes correctly

Comment 3 Marja Van Waes 2018-10-29 08:27:52 CET

Assigning to all packagers collectively, since there is no registered maintainer for Firefox.

CC'ing the enlightenment maintainer, in case the problem is with the DE

In case a packager is interested in "dark theme" bugs, there's bug 23745 (in Plasma5), too.

Assignee: bugsquad => pkg-bugs
CC: (none) => eatdirt, marja11

Comment 4 aguador 2018-12-01 17:34:38 CET

Part of the answer is with a change needed to adapt to dark themes. As those of us who use dark themes know, FF requires a /chrome subdirectory with theme information to work properly with dark themes. I have now found this discussion:

https://forum.manjaro.org/t/solved-firefox-check-boxes-are-invisible-or-hardly-there/28924

with a link to this fix for the userContent.css in the chrome subsidrectory:

https://raw.githubusercontent.com/oberon-manjaro/vertex-theme/82cff0c4780f59ebbb5f2445d071869d30111b5a/extra/Firefox/Vertex-Dark/chrome/userContent.css

It does fix the check boxes. However . . .

I am entering this from Basilisk on my Mga6 machine as this fix works for many things, but not bugzilla where the input boxes are black with black letters for some reason.

Comment 5 aguador 2018-12-04 16:59:38 CET

Having applied the suggested fixes to userContent.css, not only do the bugzilla input boxes have black-on-near-black, but text on some parts of some websites is now white-on-white. This, like my prior comment, is with 60.3.0esr as my Cauldron machine is currently on loan.

I have checked a live version of MX Linux in which Firefox current (63.x.x?) operates properly with a dark theme and does so with no /chrome folder to adapt to the dark theme.

Comment 6 aguador 2019-04-11 11:36:00 CEST

First, an aside: My prior comment was wrong. Further testing showed problems with FF there as well.

That said, there are now a couple of different ways of dealing with this: https://wiki.archlinux.org/index.php/Firefox/Tweaks#Unreadable_input_fields_with_dark_GTK+_themes

I have not tried the FF config settings yet, which is likely the better way to go, but I can confirm that this add-on works:

https://addons.mozilla.org/es/firefox/addon/text-contrast-for-dark-themes/

I am using it as I write and have white text on a black background. The preview, of course, shows black text on a light background.

The extension allows varying the level of contrast, something I have not tested as it works fine out of the box.

I was going to close this, but perhaps there is a way to set the configs in packaging that allows FF work with both light and dark themes?

Comment 7 aguador 2020-04-19 13:28:12 CEST

Closing this as it seems to be resolved in the latest release.

Status: NEW => RESOLVED
Resolution: (none) => FIXED