| Summary: | Unable to preview plymouth themes because x11.so is not being built | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Jeremiah Summers <JMiahMan> |
| Component: | RPM Packages | Assignee: | Stig-Ørjan Smelror <smelror> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | ghibomgx, mageia, marja11, olav, smelror, tmb, zen25000 |
| Version: | Cauldron | Keywords: | PATCH |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | plymouth-0.9.3-1.mga7.src.rpm | CVE: | |
| Status comment: | |||
| Attachments: | Patch to remove compile option from spec | ||
|
Description
Jeremiah Summers
2018-04-25 09:22:10 CEST
Created attachment 10104 [details]
Patch to remove compile option from spec
This patch bumps the release version, removed the compile option to allow x11.so to compile and updates the file section to include the x11.so library in the renderers library folder
Thanks for the report and patch, Jeremiah. I haven't managed to find a reason why gtk wasn't enabled in the changelog of plymouth (but have only searched for "gtk", "GTK", "x11" and "X11"). Assigning to all packagers collectively, since there is no registered maintainer for this package. CC'ing some committers. Assignee:
bugsquad =>
pkg-bugs
Stig-Ørjan Smelror
2018-04-25 14:34:54 CEST
Assignee:
pkg-bugs =>
smelror Hi. Thanks for the patch. An update has been pushed to the Build System, 0.9.3-2. Cheers, Stig Note that Suse (and Deb based distros) has this lib in it's own sub package plymouth-x11 and Fedora has it included in devel. This lib is not needed for Plymouth to work, but only to view Plymouth themes in X11. It's very helpful to have but if it causes issues Mageia may need to subpackage it and allow the user to install it if they want to mess with edit/creating Plymouth themes. The gtk=no came in with 0.9.2 update (partial sync with omdv) http://svnweb.mageia.org/packages/cauldron/plymouth/current/SPECS/plymouth.spec?r1=878073&r2=923177&pathrev=1222372 @Stig, you need to split out it as a plymouth-x11 subpackage to not bloat the deps on normal plymouth Thomas, There are two other libraries in Plymouth, drm.so and frame-buffer.so. Should these also be split into their own sub-packages? Cheers, Stig Frame-buffer should be fine where it's at and for the drm lib it's supported for anything that uses drm (kms) on boot. Both of these libs are boot focused, the x11 lib is not. There could be an argument made I think to remove drm and create it's own subpackage.. but I personally would not. There is however a conflicts issue. You're rel is 3 and you have the conflicts for x11 conflicting with anything less then 4, so the current release of plymouth conflicts with plymouth-x11 The description for x11, could be a bit more descriptive. I like Suse's description for the package so you could adopt that. "This package providesthe X11 renderer which allows to test plymouth behavior on environments with a valid DISPLAY." You can then bump the release for the description update and that would then fix your conflicts.. so: Release: %mkrel 3 to: Release: %mkrel 4 And you should be good. Please after these get built on the BS test and make sure they at least install. I can test anything further for you. Thanks. Issue rectified and pushed to the Build System. Cheers, Stig Fixed. Status:
NEW =>
RESOLVED |