Bug 22575

Summary:	handle -Wunused-result for monitor edid
Product:	Mageia	Reporter:	Till Maas <opensource>
Component:	RPM Packages	Assignee:	Shlomi Fish <shlomif>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	marja11
Version:	Cauldron
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	monitor-edid	CVE:
Status comment:
Attachments:	Patch to fix -Wwarn-unsed warning

Description Till Maas 2018-02-11 13:19:44 CET

Description of problem:
When compiling monitor-edid-3.1 this warning occurs:

monitor-get-edid-using-vbe.c: In function 'main':
monitor-get-edid-using-vbe.c:77:3: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
   write(1, edid, size);


The attached patch fixes this.

Comment 1 Till Maas 2018-02-11 13:20:17 CET

Created attachment 9979 [details]
Patch to fix -Wwarn-unsed warning

Comment 2 Marja Van Waes 2018-02-11 17:42:16 CET

@ Shlomi

I saw you just pushed monitor-edid in cauldron.

Can you please read this report and decide what should be done with it? (There is no registered maintainer for monitor-edid)

Assignee: bugsquad => shlomif
Source RPM: (none) => monitor-edid
CC: (none) => marja11

Comment 3 Shlomi Fish 2018-02-11 18:42:22 CET

Fixed in rel 10. Thanks!

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 4 Till Maas 2018-02-12 11:28:26 CET

Shlomi, where did you fix this? On IRC I was told that mageia is upstream for the tool and that the sources are at http://gitweb.mageia.org/software/monitor-edid/ - the commit does not appear there. Is there a different upstream repository?

Since you can fix things in monitor-edid, please see also the patch in https://bugs.mageia.org/show_bug.cgi?id=22293 and you could close https://bugs.mageia.org/show_bug.cgi?id=19198 as a duplicate of #22293.

Comment 5 Shlomi Fish 2018-02-12 12:50:59 CET

(In reply to Till Maas from comment #4)
> Shlomi, where did you fix this? On IRC I was told that mageia is upstream
> for the tool and that the sources are at
> http://gitweb.mageia.org/software/monitor-edid/ - the commit does not appear
> there. Is there a different upstream repository?
> 

i had fixed it as a patch to the cauldron .src.rpm but now pushed it to the git repo as well. Thanks!

> Since you can fix things in monitor-edid, please see also the patch in
> https://bugs.mageia.org/show_bug.cgi?id=22293 and you could close
> https://bugs.mageia.org/show_bug.cgi?id=19198 as a duplicate of #22293.