Bug 22453

Summary:	joe crashes when editing a particular file.
Product:	Mageia	Reporter:	PC LX <mageia>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	Normal	CC:	geiger.david68210, sysadmin-bugs
Version:	6	Keywords:	advisory, validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	MGA6-64-OK
Source RPM:	joe-4.3-1.mga6.src.rpm	CVE:
Status comment:
Attachments:	test.sh file that triggers the crash.

Description PC LX 2018-01-25 13:16:43 CET

Description of problem:

joe (version 4.3) crashes when editing the attached file.

Crash backtrace from gdb:
(gdb) bt
#0  0x000000000044adf5 in parse (syntax=syntax@entry=0x2e0000003d, line=line@entry=0x81c670, h_state=..., charmap=0x784810) at syntax.c:162
#1  0x0000000000451736 in lattr_get (db=0x84bf20, y=0x2e0000003d, p=p@entry=0x81c050, line=5) at lattr.c:303
#2  0x000000000042925d in get_context (bw=0x83c7f0, bw=0x83c7f0) at tw.c:72
#3  stagen (stalin=0x83b570 "\\i^[  I A  akregator-open.sh (sh)  ", bw=bw@entry=0x83c7f0, s=0x77e75b "x", fill=fill@entry=32 ' ') at tw.c:231
#4  0x000000000042a388 in disptw (w=0x82d220, flg=1) at tw.c:599
#5  0x0000000000414f78 in edupd (flg=flg@entry=1) at main.c:67
#6  0x00000000004150e4 in edloop (flg=flg@entry=0) at main.c:134
#7  0x000000000040374e in main (argc=<optimized out>, real_argv=<optimized out>, envv=<optimized out>) at main.c:678

I have compiled and tested the most up-to-date upstream version (4.5) and the issue seems to be resolved there. The upstream version 4.5 compiles cleanly in an up-to-date Mageia 6.

System: Mageia 6, x86_64, Intel CPU.

$ uname -a
Linux marte 4.14.13-desktop-1.mga6 #1 SMP Wed Jan 10 12:48:53 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux



Version-Release number of selected component (if applicable):

$ rpm -q joe
joe-4.3-1.mga6



How reproducible:

Always.



Steps to Reproduce:
1. Open the attached file (joe test.sh)
2. Move the cursor up/down until it passed the "MATCH_YOUTUBE=..." line.
3. See the crash (segmentation fault).

Comment 1 PC LX 2018-01-25 13:17:43 CET

Created attachment 9927 [details]
test.sh file that triggers the crash.

Comment 2 David GEIGER 2018-01-25 17:38:44 CET

Assigning to the registered maintainer.

CC: (none) => geiger.david68210
Assignee: bugsquad => shlomif

Comment 3 Shlomi Fish 2018-01-25 18:13:21 CET

I can reproduce it on my mga6 x64 vbox VM, but it is ok on Cauldron with joe-4.5. I think I'll send an upgrade update to mga6.

Comment 4 Shlomi Fish 2018-01-25 18:32:35 CET

(In reply to Shlomi Fish from comment #3)
> I can reproduce it on my mga6 x64 vbox VM, but it is ok on Cauldron with
> joe-4.5. I think I'll send an upgrade update to mga6.

submitted an update of joe version 4.6 to mageia 6 core/updates testing . Please test.

Comment 5 PC LX 2018-01-25 20:20:49 CET

Installed and tested. Issue is resolved on the updated version.

System: Mageia 6, x86_64, Intel CPU.

$ uname -a
Linux marte 4.14.13-desktop-1.mga6 #1 SMP Wed Jan 10 12:48:53 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
$ rpm -q joe
joe-4.6-1.mga6

Comment 6 Shlomi Fish 2018-01-25 21:47:30 CET

(In reply to PC LX from comment #5)
> Installed and tested. Issue is resolved on the updated version.
> 
> System: Mageia 6, x86_64, Intel CPU.
> 
> $ uname -a
> Linux marte 4.14.13-desktop-1.mga6 #1 SMP Wed Jan 10 12:48:53 UTC 2018
> x86_64 x86_64 x86_64 GNU/Linux
> $ rpm -q joe
> joe-4.6-1.mga6

Great, thanks! Assigning to QA - we need to write an advisory.

Assignee: shlomif => qa-bugs

Comment 7 PC LX 2018-01-26 19:27:49 CET

Already tested (see comment 5) so marking as OK for x86_64.

Whiteboard: (none) => MGA6-64-OK

Comment 8 PC LX 2018-01-26 19:43:52 CET

Here is my literary attempt at an advisory.

Suggested advisory:
========================

Updated joe package fix a segfault issue due to a buffer overrun, when a line with many backslashes appears in the status line context display, plus several other minor fixes and enhancements.

Comment 9 Lewis Smith 2018-01-26 21:16:08 CET

@PC_LX
Thank you for both the test and the Advisory Description. We normally need the SRPM also, but I got that from C5 and the bug RPMs link.
Validating.

Keywords: (none) => advisory, validated_update
CC: (none) => sysadmin-bugs

Comment 10 Mageia Robot 2018-01-27 10:19:49 CET

An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2018-0024.html

Resolution: (none) => FIXED
Status: NEW => RESOLVED