| Summary: | Add --enable-catch_segvs for wxWidgets libraries | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Olivier Delaune <olivier.delaune> |
| Component: | RPM Packages | Assignee: | Mageia Bug Squad <bugsquad> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | marja11 |
| Version: | Cauldron | Keywords: | Triaged |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | wxgtk2.8 | CVE: | |
| Status comment: | |||
|
Description
Olivier Delaune
2011-07-22 12:20:21 CEST
amule-2.3.1-0.rc1 builds OK on the BS (and I've just tested locally), what problems do you have when you try building it? Keywords:
(none) =>
NEEDINFO Hello,
so these packages are installed in my computer:
* lib64wxgtk2.8-2.8.11-4.mga1
* lib64wxgtku2.8-2.8.11-4.mga1
* lib64wxgtkgl2.8-2.8.11-4.mga1
* lib64wxgtkglu2.8-2.8.11-4.mga1
* wxgtk2.8-2.8.11-4.mga1
* lib64wxgtk2.8-devel-2.8.11-4.mga1
* lib64wxgtku2.8-devel-2.8.11-4.mga1
I got amule source for version 2.2.6 from official website.
configure is done without problem but when I do "make", I get this error
>Compiling amule.cpp
>amule.cpp: In member function âvirtual bool CamuleApp::OnInit()â:
>amule.cpp:486:31: erreur: âwxHandleFatalExceptionsâ was not declared in this scope
>make[3]: *** [amule-amule.o] Erreur 1
>make[2]: *** [all-recursive] Erreur 1
>make[1]: *** [all-recursive] Erreur 1
>make: *** [all] Erreur 2
I tried to compile myself wxWidgets libraries (wxgtk) specifying "--enable-catch_segvs" and I managed to compile aMule without this problem. So, I guess this problem comes from this option is not present in wxgtk libraries packages.
There's this patch for 2.2.6 http://svnweb.mageia.org/packages/cauldron/amule/current/SOURCES/aMule-2.2.6-fix-build-without-wx-segv-handler.patch?revision=95924&view=markup I do not know. Does it mean it is better to not add "--enable-catch_segvs" to wxgtk and to use this patch? FWIW, the only pro I've found for building with --disable-catch_segvs http://comments.gmane.org/gmane.linux.redhat.fedora.devel/135119 , ABRT related, and we don't have proper abrt integration to begin with. The package was built with --disable-catch_segvs http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages?view=revision&revision=569378 , but there's no explanation as to why the crash handler was disabled... I'll push a new wxgtk2.8 in Cauldron without disabling catch_segvs, let's hope it doesn't cause any trouble, we can have enough testing before mga2, and if there're any issues we can revert. Keywords:
NEEDINFO =>
Triaged (In reply to comment #5) > > I'll push a new wxgtk2.8 in Cauldron without disabling catch_segvs, let's hope > it doesn't cause any trouble, we can have enough testing before mga2, and if > there're any issues we can revert. @ Olivier It took some time, but the new wxgtk2.8 made in to Cauldron in september: *********************************************** Sun Sep 11 2011 fwang <fwang> 2.8.12-4.mga2 + Revision: 142256 - rebuild for new libpng + ahmad - Change the BR to pkgconfig BR style - Drop redundant BR libGConf2-devel - Don't promote LDFLAGS in wx-config (fwang) - Build with --enable-catch_segvs. The only pro I could find for disabling it is that it interferes with ABRT support[1], since we don't have ABRT support (either proper integration in the distro nor server side (bugzilla)) we can enable it for the time being. This should (fix mga#2232). [1] http://comments.gmane.org/gmane.linux.redhat.fedora.devel/135119 ************************************************************************* So closing this Bug report Status:
NEW =>
RESOLVED |