Bug 21594

Summary: Update request: Kodi 17.5
Product: Mageia Reporter: Stig-Ørjan Smelror <smelror>
Component: RPM PackagesAssignee: Anssi Hannula <anssi.hannula>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: Normal CC: eatdirt, marja11
Version: 6   
Target Milestone: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/xbmc/xbmc/releases
Whiteboard:
Source RPM: kodi CVE:
Status comment:
Attachments: Updated the CheckPerms patch for Kodi-17.5
kodi-add-mageia-systeminfo.patch
Screenshot of Kodi Version info

Description Stig-Ørjan Smelror 2017-08-22 16:44:26 CEST
Hi.

Kodi 17.4 has just been released. Is it possible to get it for MGA6?

TIA.

Cheers,
Stig
Comment 1 Marja Van Waes 2017-08-22 22:50:39 CEST
(In reply to Stig-Ørjan Smelror from comment #0)
> Hi.
> 
> Kodi 17.4 has just been released. Is it possible to get it for MGA6?
> 

Is it a bugfix-only release?

Source RPM: (none) => kodi
CC: (none) => marja11
Assignee: bugsquad => anssi.hannula

Comment 2 Stig-Ørjan Smelror 2017-08-22 22:55:35 CEST
(In reply to Marja van Waes from comment #1)
> (In reply to Stig-Ørjan Smelror from comment #0)
> > Hi.
> > 
> > Kodi 17.4 has just been released. Is it possible to get it for MGA6?
> > 
> 
> Is it a bugfix-only release?

Yes, only bugfixes.

https://kodi.tv/article/kodi-v174-final-just-bunch-fixes
Comment 3 Stig-Ørjan Smelror 2017-09-21 17:26:30 CEST
Hi.

Just a little ping to bump awareness to my request.
Comment 4 Stig-Ørjan Smelror 2017-10-23 08:55:27 CEST
Hi.

Distrowatch just notified me that, an hour or so ago, Martijn released Kodi 17.5.

It's mainly bugfixes backported from the git master as far as I can tell.

https://github.com/xbmc/xbmc/archive/17.5-Krypton.tar.gz

Cheers,
Stig

Summary: Update request: Kodi 17.4 => Update request: Kodi 17.5

Comment 5 Stig-Ørjan Smelror 2017-10-23 09:06:29 CEST
Created attachment 9748 [details]
Updated the CheckPerms patch for Kodi-17.5

It's based on the 17.3 patch, just updated to reflect the changes made in 17.5.
Comment 6 Stig-Ørjan Smelror 2017-10-23 09:23:34 CEST
Oh, and please disable Patch2. I don't think it's relevant now.
Comment 7 Stig-Ørjan Smelror 2017-10-24 23:08:17 CEST
Created attachment 9753 [details]
kodi-add-mageia-systeminfo.patch

Hi.

I've had a lot of fun hacking Kodi.

This new patch makes way for a fun little addition.
In Settings-System Information it will now show, bottom right, "Build: Kodi 17.5-rel.mkrel".

Will attach an image that shows how it looks on my machine.

What more needs to be done is to add:

Patch6: kodi-add-mageia-systeminfo.patch

%(echo "-%{rel}%{?dist}" > %{_sourcedir}/kodi-version-info.patch)
after the %endif of Release

# We need to create VERSION with our data
Source5:        kodi-version-info.patch

%__cp %{SOURCE5}        VERSION
before %autopatch

The src.rpm can be downloaded from my ftp-server
ftp://kekepower.myftp.org/linux/kekePower/SRPMS/kodi-17.5-4.kekePower.mga6.src.rpm


Cheers,
Stig
Comment 8 Stig-Ørjan Smelror 2017-10-24 23:09:41 CEST
Created attachment 9754 [details]
Screenshot of Kodi Version info
Comment 9 David Walser 2017-10-26 18:22:53 CEST
This is one of the packages that bundles ffmpeg, so we should try to keep it up to date if possible.
Comment 10 Stig-Ørjan Smelror 2017-10-26 18:42:42 CEST
(In reply to David Walser from comment #9)
> This is one of the packages that bundles ffmpeg, so we should try to keep it
> up to date if possible.

As far as I can tell, our Kodi builds towards system ffmpeg and doesn't use the built-in one.

I think it's better to use the bundled ffmpeg instead of compiling against the system.
There may be performance issues, audio/video issues and what-not if compiled against the system.

--- from kodi.spec ---
# build with internal ffmpeg, disabled by default (--with internal_ffmpeg)
%bcond_with     internal_ffmpeg

%if %with       internal_ffmpeg
# issue with 11.0 internal ffmpeg, haven't bothered with patching as it is
# not used in the default build anyway
%define Werror_cflags %nil
%endif
---

If we enable the internal ffmpeg, we have to download it and add it as a new source since the build process will try to download it automatically if not present.

See this comment from Martinj.
https://forum.kodi.tv/showthread.php?tid=322777&pid=2658586#pid2658586


Cheers,
Stig
Comment 11 Stig-Ørjan Smelror 2017-10-26 20:07:39 CEST
Hi all.

I've updated the spec file, added the kodi version of ffmpeg to the src.rpm file, built in mock without issues and uploaded the new file to my ftp server.

ftp://kekepower.myftp.org/linux/kekePower/SRPMS/kodi-17.5-5.mga6.src.rpm

A lot of old stuff has been removed since I believe they no longer apply.

The build I did in mock installed and runs fine on my HTPC.


Cheers,
Stig
Comment 12 Chris Denice 2017-10-26 22:55:17 CEST
Ok, I have packaged it for Cauldron, see mailing list.

Now, what it this bug? Is there a bug? Mageia 6 is not a rolling release, so unless we have a good reason to update kodi from 17.3 to 17.5 on mageia 6 the first thing to know is why!
All what I can see in the update log is "possible fix"...

I added your patch Stig on mageia but the only thing your patch is doing is removing the wording "Git:", that's far less than what we consider a bug.

What has been changed on the permissions? This is another bug, which is fixed! Is there any issue with it?

We have enough work to do on serious bugs and fixing Cauldron these days that I would be please to not be flooded with these kinds of request.

As far as I am concerned, this bug is invalid. Closing at such, open a real bug report on a real issue if this happens.

Cheers.

Status: NEW => RESOLVED
CC: (none) => eatdirt
Resolution: (none) => INVALID