| Summary: | libreadline should be linked to libncursesw instead of libncurses | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Antoine Pitrou <pitrou> |
| Component: | RPM Packages | Assignee: | Barry Jackson <zen25000> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | mageia, marja11, misc, n54, stormi-mageia, zen25000 |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | readline-6.2-1.mga1.src.rpm | CVE: | |
| Status comment: | |||
| Bug Depends on: | |||
| Bug Blocks: | 3053 | ||
| Attachments: | build log | ||
|
Description
Antoine Pitrou
2011-07-15 16:56:03 CEST
Antoine Pitrou
2011-07-15 16:57:02 CEST
CC:
(none) =>
misc Yep, should be doable in cauldron. Now, I would rather wait before backporting the fix on stable ( as it could have unintended side effects :/ ) (In reply to comment #1) > Yep, should be doable in cauldron. Now, I would rather wait before backporting > the fix on stable ( as it could have unintended side effects :/ ) Agreed, this is really a wish rather than a bug, and there's no point risking breakage by backporting it.
Samuel Verschelde
2011-10-01 03:26:39 CEST
CC:
(none) =>
stormi (In reply to comment #1) > Yep, should be doable in cauldron. @ misc No maintainer, are you willing to do this? CC:
(none) =>
mageia, marja11 He is working with this package https://bugs.mageia.org/show_bug.cgi?id=3053#c8 @misc I recently tried to re-build readline (after fixing a doc permission) and it won't now build against libncursesw. It does build OK against libncurses. Any ideas? Yes.
Start with the spec, for example here:
%build
export LDFLAGS="-I%{_includedir}/ncurses -lncurses"
export CFLAGS="%{optflags} -I%{_includedir}/ncurses -lncurses"
export CXXFLAGS="%{optflags} -I%{_includedir}/ncurses -lncurses"
use ncursesw for -I and -l
@ Barry Do you agree on having this bug assigned to you? CC:
(none) =>
zen25000 (In reply to comment #8) > @ Barry > > Do you agree on having this bug assigned to you? Yes - done Assignee:
bugsquad =>
zen25000 Well, when you mean "don't build", what does it say ? Created attachment 1212 [details] build log (In reply to comment #10) > Well, when you mean "don't build", what does it say ? Sorry - I should have been more specific. Build log attached. I think Kamil hit the nail on the head in #7. Replacing all instances of ncurses with ncursesw in those lines fixes the build in iurt. As you made the original switch from ncurses to ncursesw I would appreciate you reviewing the current spec in svn before I submit it. http://svnweb.mageia.org/packages/cauldron/readline/current/SPECS/readline.spec?view=markup It would have been better to document all change, ( and avoid to do some live move without telling in the changelog, because this make review harder ) After a quick look, I think the spec was buggy in the first place, '-lncurses' doesn't really belong to CFLAGS, since that's a linker option. And I see no one commented the patches, which sadden me a little as usual, but I guess none of these prevent the package from being shipped since it build fine. I also guess that we should investigate a proper fix to send it upstream so we do not have to fiddle with $CFLAGS :/ have you tried to build in iurt without touching to CFLAGS, maybe this work fine ? (In reply to comment #12) > I also guess that we should investigate a proper fix to send it upstream so we > do not have to fiddle with $CFLAGS :/ > have you tried to build in iurt without touching to CFLAGS, maybe this work > fine ? Good thought - it builds OK in iurt with only the LDFLAGS touched - so I'm removing the other two. I am a little concerned about it's Require on libncurses-devel - should that also now be changed to libncursesw-devel ?
Barry Jackson
2011-12-14 23:09:26 CET
Blocks:
(none) =>
3053 OK, pushed in Cauldron with the changes. Closing as fixed - please re-open if this causes any issues. Status:
NEW =>
RESOLVED |