| Summary: | Adwaita GTK+ theme is not selectable in GNOME tweak tool | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Martin Whitaker <mageia> |
| Component: | RPM Packages | Assignee: | GNOME maintainers <gnome> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | olav |
| Version: | Cauldron | ||
| Target Milestone: | Mageia 6 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | task-gnome, meta-task? | CVE: | |
| Status comment: | |||
| Attachments: |
gnome without adwaita-gtk2-theme
gnome with adwaita-gtk2-theme really gnome without adwaita-gtk2-theme |
||
|
Description
Martin Whitaker
2017-05-16 09:41:44 CEST
IIRC, we want to enforce Adwaita for GTK+2 on GNOME, so it should be installed by default. Assigning to the gnome@ maintainer group for confirmation and/or fix. Source RPM:
(none) =>
task-gnome, meta-task?
Rémi Verschelde
2017-05-16 09:48:17 CEST
Target Milestone:
--- =>
Mageia 6 (In reply to Rémi Verschelde from comment #1) > IIRC, we want to enforce Adwaita for GTK+2 on GNOME, so it should be > installed by default. Assigning to the gnome@ maintainer group for > confirmation and/or fix. Gnome maintainers or users, any comment to confirm whether it's a bug or wanted? If it's a bug it would be good to add a note about this in the Errata. No clue. gnome-tweak-tools should NOT depend on anything gtk+2.x. So maybe the bug is elsewhere. Maybe quick fix is to ensure it is installed via meta-task as a require seems wrong. CC:
(none) =>
olav Checked source, gnome-tweak-tool really only shows themes with GTK+2.x and GTK+3.x support. Ugh Olav, the issue is not the tweak-tool, but a default M6 Gnome (only) install does not include the adwaita-gtk2-theme package. All (by default) installed gtk+2 applications look horrible, f.e. Gimp. It's embarrasing :p With the theme installed they look good :) rpmsrate, meta-task or task-gnome could take care of it, I guess. For Gnome Live, Martin has already manually included the adwaita-gtk2, but the CI and netinstall are still affected. CC:
(none) =>
shybluenight Ok, then the solution should be a Recommends or Require on lib*gtk+2.x Created attachment 9483 [details]
gnome without adwaita-gtk2-theme
No, gnome needs the adwaita-gtk2-theme package.
See screenshots without the theme package, and with the package included.
Created attachment 9484 [details]
gnome with adwaita-gtk2-theme
screenshot gnome with adwaita-gtk2-theme package
You posted the with adwaita-gtk2 screenshot twice ;) Created attachment 9485 [details]
really gnome without adwaita-gtk2-theme
skip the first screenshot, here is the one without adwaita-gtk2-theme package installed.
(In reply to Chris B from comment #7) > No, gnome needs the adwaita-gtk2-theme package. > See screenshots without the theme package, and with the package included. You're posting a screenshot of GIMP. That's a gtk+2.x package which is NOT part of GNOME. By default GTK+3.x uses Adwaita. As such gtk+2.x should have Adwaita as well. That some other desktops prefer some other theme or have one extra dependency is because the theme is changed from the default. Gimp and other gtk+2 applications are part of our default single Gnome installation. You are not interested, how it looks? Fine with me, I'm not even a gnome user, just a member of the QA team. I'm giving up. (In reply to Olav Vitters from comment #11) > (In reply to Chris B from comment #7) > > No, gnome needs the adwaita-gtk2-theme package. > > See screenshots without the theme package, and with the package included. > > You're posting a screenshot of GIMP. That's a gtk+2.x package which is NOT > part of GNOME. By default GTK+3.x uses Adwaita. As such gtk+2.x should have > Adwaita as well. That some other desktops prefer some other theme or have > one extra dependency is because the theme is changed from the default. I feel like we've been discussing this for years and we're no closer to a resolution... GTK+3 uses Adwaita as default theme. GTK+2 uses Raleigh as default theme, and it's arguably very old fashioned, if not ugly. GTK+2/Raleigh applications in a GTK+3/Adwaita environment look very out of place, like e.g. GIMP or LibreOffice in the out-of-the-box GNOME environment on Mageia (but also on other DEs). So gtk+2.0 should recommend adwaita-gtk2-theme to ensure that we have a sane default theme, and meta-task should install it out of the box. If some users really don't want adwaita-gtk2, they can then uninstall it.
Chris B
2017-07-11 11:48:38 CEST
CC:
shybluenight =>
(none) (In reply to Chris B from comment #12) > I'm giving up. Great, then I'll fix this the way that I deem right. That means an additional dependency on gtk+2.x. The not caring: whatever, I proposed a solution and you rejected it, then stating you're only QA. adwaita-gtk2-theme is present on all the 7-beta2 ISOs. Resolution:
(none) =>
FIXED |