| Summary: | Remove warning in identity.m.o about the encoding parameter | ||
|---|---|---|---|
| Product: | Infrastructure | Reporter: | Frédéric "LpSolit" Buclin <LpSolit> |
| Component: | Others | Assignee: | Frédéric "LpSolit" Buclin <LpSolit> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | Low | CC: | sysadmin-bugs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | CVE: | ||
| Status comment: | |||
| Attachments: |
proposed fix
patch patch #2 |
||
|
Description
Frédéric "LpSolit" Buclin
2017-04-17 14:12:19 CEST
Created attachment 9210 [details]
proposed fix
I bumped the min version of Catalyst::Runtime to 5.90042 which has the Unicode::Encoding plugin in core, and also defined the 'encoding' parameter to UTF-8, as specified in the warning above. Now the warning is gone. I also removed the <meta name="keywords"> tag as it's no longer used by search engines. Ideally, we should require Catalyst::Runtime 5.90080 which has a better support for UTF8, but Mageia 5 only has 5.90071. Created attachment 9211 [details]
patch
Looks like I cannot commit this patch myself, so here is a new patch using "format-patch".
Attachment 9210 is obsolete:
0 =>
1 commit 9981494a9e4f2272b85eb3a5672b8b7392d52ca1
Author: Frédéric Buclin <LpSolit@...>
Date: Mon Apr 17 15:00:08 2017 +0200
Remove a warning about the encoding parameter (mga#20687)
---
Commit Link:
http://gitweb.mageia.org/web/identity/commit/?id=9981494a9e4f2272b85eb3a5672b8b7392d52ca1
commit 3f0349b374e0883fe4ddada7286aef73da1e376e
Author: Frédéric Buclin <LpSolit@...>
Date: Mon Apr 17 15:00:08 2017 +0200
Remove a warning about the encoding parameter (mga#20687)
---
Commit Link:
http://gitweb.mageia.org/web/identity/commit/?id=3f0349b374e0883fe4ddada7286aef73da1e376e
fixed Resolution:
(none) =>
FIXED Created attachment 9212 [details]
patch #2
I just realized that the charset meta tag is wrong. This 2nd patch fixed it.
commit 095c37d101b02508b745ff12e6f48e8e3458cdf2
Author: Frédéric Buclin <LpSolit@...>
Date: Mon Apr 17 15:31:03 2017 +0200
Fix the charset meta tag (mga#20687)
---
Commit Link:
http://gitweb.mageia.org/web/identity/commit/?id=095c37d101b02508b745ff12e6f48e8e3458cdf2
commit 7c020a3bc61a5922f607734e65f33bf7d6523f5b
Author: Frédéric Buclin <LpSolit@...>
Date: Mon Apr 17 15:31:03 2017 +0200
Fix the charset meta tag (mga#20687)
---
Commit Link:
http://gitweb.mageia.org/web/identity/commit/?id=7c020a3bc61a5922f607734e65f33bf7d6523f5b
|