Bug 20540

Summary:	mgapplet on KDE Plasma 5 on startx does not do anything on mouse double-click / right-click.
Product:	Mageia	Reporter:	Shlomi Fish <shlomif>
Component:	RPM Packages	Assignee:	Frédéric "LpSolit" Buclin <LpSolit>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	LpSolit, jani.valimaa, marja11
Version:	Cauldron
Target Milestone:	Mageia 6
Hardware:	x86_64
OS:	Linux
Whiteboard:
Source RPM:	mgaonline	CVE:
Status comment:

Description Shlomi Fish 2017-03-20 17:38:20 CET

mgapplet on KDE Plasma 5 on startx does not do anything on mouse double-click / right-click. It pops the tooltip on hover fine. Other panel applets such as hexchat, pidgin or klipper work fine.

How reproducible:

Always.

Steps to Reproduce:
1. Make sure you have out-of-date packages.
2. Start Plasma5 using startx.
3. doubleclick or right click on the mgaaplet.

Comment 1 Shlomi Fish 2017-03-20 17:59:39 CET

I've now tried it in Plasma 5 started from prefdm (the default display manager) and this problem does not happen there. So it seems to be startx-specific.

Comment 2 Rémi Verschelde 2017-03-20 17:59:52 CET

The detection of whether the DE is Plasma is done here: http://gitweb.mageia.org/software/mgaonline/tree/mgaapplet#n176
with `$ENV{DESKTOP_SESSION} =~ /plasma$/i`

So if startx does not define DESKTOP_SESSION, it would indeed fail and fallback to the GtkStatusIcon system that does not work on Plasma.

We might need to find a better way to find if we're running Plasma.

Marja Van Waes 2017-03-20 21:48:23 CET

CC: (none) => marja11
Assignee: bugsquad => kde

Rémi Verschelde 2017-03-20 22:32:38 CET

Assignee: kde => mageiatools
Source RPM: plasma-workspace-5.8.6-5.mga6.src.rpm => mgaonline

Comment 3 Jani Välimaa 2017-03-21 19:21:00 CET

Someone should check 'env | sort' output from both start methods (dm and startx) to figure out common env variable to use.

CC: (none) => jani.valimaa

Frédéric "LpSolit" Buclin 2017-03-21 21:12:03 CET

CC: (none) => LpSolit

Comment 4 Frédéric "LpSolit" Buclin 2017-03-21 21:22:45 CET

Does it only affect mgaapplet? net_applet is not affected?

Comment 5 Frédéric "LpSolit" Buclin 2017-05-08 19:40:39 CEST

I think I know what's going on.

Target Milestone: --- => Mageia 6
Assignee: mageiatools => LpSolit
Status: NEW => ASSIGNED

Comment 6 Mageia Robot 2017-05-12 17:36:09 CEST

commit 891f99fe81b5c4584dbf01f7fa9605aac28e5aaf
Author: Frédéric Buclin <LpSolit@...>
Date:   Fri May 12 17:25:50 2017 +0200

    Correctly detect right-clicks before the first check for updates (mga#20540)
    
    It uses exactly the same code as net_applet, see 20410
---
 Commit Link:
   http://gitweb.mageia.org/software/mgaonline/commit/?id=891f99fe81b5c4584dbf01f7fa9605aac28e5aaf

Comment 7 Frédéric "LpSolit" Buclin 2017-05-12 17:42:33 CEST

Fixed!

I also fixed another problem hidden by this bug. If the user wanted mgaapplet to look for updates in the first 5 minutes (i.e. before the first automatic check), then notifications stopped working despite updates were found. You had to kill and restart mgaapplet to get notifications back. Now it works fine.

http://gitweb.mageia.org/software/mgaonline/commit/?id=dff4b9f555ac102fa9280a3362865eb33fd9ae5e

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED